linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Howard Chu <howardchu95@gmail.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
	Alan Maguire <alan.maguire@oracle.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Kan Liang <kan.liang@linux.intel.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-perf-users@vger.kernel.org
Subject: perf trace: substruct BTF based pretty printing
Date: Wed, 11 Sep 2024 17:25:14 -0300	[thread overview]
Message-ID: <ZuH8qhuZB6mr9JvR@x1> (raw)

Hi Howard,

	Not really a requirement on you to do work, just a some notes to
add to our discussion/experiment on using BTF to pretty print syscall
(and tracepoints/whatever) arguments:

root@number:~# perf trace -e setitimer -p 5444 |& head -5
     0.000 ( 0.017 ms): Xwayland/5444 setitimer(value: (struct __kernel_old_itimerval){})                   = 0
     0.050 ( 0.004 ms): Xwayland/5444 setitimer(value: (struct __kernel_old_itimerval){})                   = 0
     0.142 ( 0.005 ms): Xwayland/5444 setitimer(value: (struct __kernel_old_itimerval){})                   = 0
     0.174 ( 0.004 ms): Xwayland/5444 setitimer(value: (struct __kernel_old_itimerval){})                   = 0
     0.293 ( 0.004 ms): Xwayland/5444 setitimer(value: (struct __kernel_old_itimerval){})                   = 0
root@number:~# strace -e setitimer -p 5444 |& head -5
strace: Process 5444 attached
setitimer(ITIMER_REAL, {it_interval={tv_sec=0, tv_usec=5000}, it_value={tv_sec=0, tv_usec=5000}}, NULL) = 0
setitimer(ITIMER_REAL, {it_interval={tv_sec=0, tv_usec=0}, it_value={tv_sec=0, tv_usec=0}}, NULL) = 0
setitimer(ITIMER_REAL, {it_interval={tv_sec=0, tv_usec=5000}, it_value={tv_sec=0, tv_usec=5000}}, NULL) = 0
setitimer(ITIMER_REAL, {it_interval={tv_sec=0, tv_usec=0}, it_value={tv_sec=0, tv_usec=0}}, NULL) = 0
root@number:~# 
root@number:~# 
root@number:~# grep -w value /sys/kernel/tracing/events/syscalls/sys_enter_rseq/format 
root@number:~# grep -w value /sys/kernel/tracing/events/syscalls/sys_enter_setitimer/format 
	field:struct __kernel_old_itimerval * value;	offset:24;	size:8;	signed:0;
print fmt: "which: 0x%08lx, value: 0x%08lx, ovalue: 0x%08lx", ((unsigned long)(REC->which)), ((unsigned long)(REC->value)), ((unsigned long)(REC->ovalue))
root@number:~# pahole __kernel_old_itimerval
struct __kernel_old_itimerval {
	struct __kernel_old_timeval it_interval;         /*     0    16 */
	struct __kernel_old_timeval it_value;            /*    16    16 */

	/* size: 32, cachelines: 1, members: 2 */
	/* last cacheline: 32 bytes */
};

root@number:~# pahole -E __kernel_old_itimerval
struct __kernel_old_itimerval {
	struct __kernel_old_timeval {
		/* typedef __kernel_long_t */ long int           tv_sec;                 /*     0     8 */
		/* typedef __kernel_long_t */ long int           tv_usec;                /*     8     8 */
	} it_interval; /*     0    16 */
	struct __kernel_old_timeval {
		/* typedef __kernel_long_t */ long int           tv_sec;                 /*    16     8 */
		/* typedef __kernel_long_t */ long int           tv_usec;                /*    24     8 */
	} it_value; /*    16    16 */

	/* size: 32, cachelines: 1, members: 2 */
	/* last cacheline: 32 bytes */
};

root@number:~#

             reply	other threads:[~2024-09-11 20:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-11 20:25 Arnaldo Carvalho de Melo [this message]
2024-09-12  1:29 ` perf trace: substruct BTF based pretty printing Howard Chu
2024-09-23 17:42   ` Howard Chu
2024-09-23 17:47     ` Alan Maguire
2024-09-23 18:17       ` Howard Chu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZuH8qhuZB6mr9JvR@x1 \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alan.maguire@oracle.com \
    --cc=howardchu95@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).