From: Andi Kleen <ak@linux.intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-perf-users@vger.kernel.org, adrian.hunter@intel.com,
namhyung@kernel.org
Subject: Re: [PATCH v1 01/10] perf: Avoid buffer overflow in python register interface
Date: Thu, 12 Sep 2024 07:38:21 -0700 [thread overview]
Message-ID: <ZuL83U3PsOl44bvJ@tassilo> (raw)
In-Reply-To: <ZuLhk6yGrr2HET6d@x1>
On Thu, Sep 12, 2024 at 09:41:55AM -0300, Arnaldo Carvalho de Melo wrote:
> On Wed, Sep 04, 2024 at 06:50:09PM -0700, Andi Kleen wrote:
> > Running a script that processes PEBS records gives buffer overflows
> > in valgrind. The problem is that the allocation of the register
> > string doesn't include the terminating 0 byte. Fix this. I also replaced
> > the very magic "28" with a more reasonable larger buffer that should
> > fit all registers. There's no need to conserve memory here.
>
> I applied this one already.
>
> But you used the wrong list address, perf-tools-users@vger, I'm fixing
> this up now to linux-perf-users@vger so that the message reaches the
> mailing list.
>
> I waited a bit for reviewers but then realized the problem with the list
> address when trying to use b4 to fetch it from lore :-\
I sent it twice. The second version had the right address.
But you were in cc and got both versions, sorry.
-Andi
next prev parent reply other threads:[~2024-09-12 14:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240905015300.2124798-1-ak@linux.intel.com>
[not found] ` <20240905015300.2124798-2-ak@linux.intel.com>
2024-09-12 12:41 ` [PATCH v1 01/10] perf: Avoid buffer overflow in python register interface Arnaldo Carvalho de Melo
2024-09-12 14:38 ` Andi Kleen [this message]
2024-09-12 14:53 ` Arnaldo Carvalho de Melo
[not found] ` <20240905015300.2124798-3-ak@linux.intel.com>
2024-09-12 12:51 ` [PATCH v1 02/10] perf: Support discriminator in addr2line Arnaldo Carvalho de Melo
2024-09-12 14:58 ` Andi Kleen
2024-09-05 15:07 [RESEND] More dwarf support in python interface Andi Kleen
2024-09-05 15:07 ` [PATCH v1 01/10] perf: Avoid buffer overflow in python register interface Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuL83U3PsOl44bvJ@tassilo \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).