From: Namhyung Kim <namhyung@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: "Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@kernel.org>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"Kan Liang" <kan.liang@linux.intel.com>,
"John Garry" <john.g.garry@oracle.com>,
"Will Deacon" <will@kernel.org>,
"James Clark" <james.clark@linaro.org>,
"Mike Leach" <mike.leach@linaro.org>,
"Leo Yan" <leo.yan@linux.dev>,
"Ravi Bangoria" <ravi.bangoria@amd.com>,
"Weilin Wang" <weilin.wang@intel.com>,
"Jing Zhang" <renyu.zj@linux.alibaba.com>,
"Xu Yang" <xu.yang_2@nxp.com>,
"Sandipan Das" <sandipan.das@amd.com>,
"Benjamin Gray" <bgray@linux.ibm.com>,
"Athira Jajeev" <atrajeev@linux.vnet.ibm.com>,
"Howard Chu" <howardchu95@gmail.com>,
"Dominique Martinet" <asmadeus@codewreck.org>,
"Yang Jihong" <yangjihong@bytedance.com>,
"Colin Ian King" <colin.i.king@gmail.com>,
"Veronika Molnarova" <vmolnaro@redhat.com>,
"Dr. David Alan Gilbert" <linux@treblig.org>,
"Oliver Upton" <oliver.upton@linux.dev>,
"Changbin Du" <changbin.du@huawei.com>,
"Ze Gao" <zegao2021@gmail.com>, "Andi Kleen" <ak@linux.intel.com>,
"Clément Le Goffic" <clement.legoffic@foss.st.com>,
"Sun Haiyong" <sunhaiyong@loongson.cn>,
"Junhao He" <hejunhao3@huawei.com>,
"Tiezhu Yang" <yangtiezhu@loongson.cn>,
"Yicong Yang" <yangyicong@hisilicon.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 00/13] Tool and hwmon PMUs
Date: Thu, 12 Sep 2024 15:50:15 -0700 [thread overview]
Message-ID: <ZuNwJ07GyMVIT0Qi@google.com> (raw)
In-Reply-To: <20240912190341.919229-1-irogers@google.com>
On Thu, Sep 12, 2024 at 12:03:27PM -0700, Ian Rogers wrote:
> Rather than have fake and tool PMUs being special flags in an evsel,
> create special PMUs. This allows, for example, duration_time to also
> be tool/duration_time/. Once adding events to the tools PMU is just
> adding to an array, add events for nearly all the expr literals like
> num_cpus_online. Rather than create custom logic for finding and
> describing the tool events use json and add a notion of common json
> for the tool events.
>
> Following the convention of the tool PMU, create a hwmon PMU that
> exposes hwmon data for reading. For example, the following shows
> reading the CPU temperature and 2 fan speeds alongside the uncore
> frequency:
> ```
> $ perf stat -e temp_cpu,fan1,hwmon_thinkpad/fan2/,tool/num_cpus_online/ -M UNCORE_FREQ -I 1000
> 1.001153138 52.00 'C temp_cpu
> 1.001153138 2,588 rpm fan1
> 1.001153138 2,482 rpm hwmon_thinkpad/fan2/
> 1.001153138 8 tool/num_cpus_online/
> 1.001153138 1,077,101,397 UNC_CLOCK.SOCKET # 1.08 UNCORE_FREQ
> 1.001153138 1,012,773,595 duration_time
> ...
> ```
>
> Additional data on the hwmon events is in perf list:
> ```
> $ perf list
> ...
> hwmon:
> ...
> temp_core_0 OR temp2
> [Temperature in unit coretemp named Core 0. crit=100'C,max=100'C crit_alarm=0'C. Unit:
> hwmon_coretemp]
> ...
> ```
>
> v2: Address Namhyung's review feedback. Rebase dropping 4 patches
> applied by Arnaldo, fix build breakage reported by Arnaldo.
>
> Ian Rogers (13):
> perf pmu: Simplify an asprintf error message
> perf pmu: Allow hardcoded terms to be applied to attributes
> perf parse-events: Expose/rename config_term_name
> perf tool_pmu: Factor tool events into their own PMU
> perf tool_pmu: Rename enum perf_tool_event to tool_pmu_event
> perf tool_pmu: Rename perf_tool_event__* to tool_pmu__*
> perf tool_pmu: Move expr literals to tool_pmu
> perf jevents: Add tool event json under a common architecture
> perf tool_pmu: Switch to standard pmu functions and json descriptions
> perf tests: Add tool PMU test
> perf hwmon_pmu: Add a tool PMU exposing events from hwmon in sysfs
> perf test: Add hwmon "PMU" test
> perf docs: Document tool and hwmon events
For patch 1-10,
Acked-by: Namhyung Kim <namhyung@kernel.org>
I'll take a look at hwmon patches later, but I think it'd be nice if you
could split the change into pieces.
Thanks,
Namhyung
>
> tools/perf/Documentation/perf-list.txt | 15 +
> tools/perf/arch/arm64/util/pmu.c | 5 +-
> tools/perf/arch/x86/util/intel-pt.c | 3 +-
> tools/perf/arch/x86/util/tsc.c | 18 +-
> tools/perf/builtin-list.c | 13 +-
> tools/perf/builtin-stat.c | 7 +-
> .../pmu-events/arch/common/common/tool.json | 74 ++
> tools/perf/pmu-events/empty-pmu-events.c | 208 +++--
> tools/perf/pmu-events/jevents.py | 16 +-
> tools/perf/tests/Build | 2 +
> tools/perf/tests/builtin-test.c | 2 +
> tools/perf/tests/hwmon_pmu.c | 243 ++++++
> tools/perf/tests/pmu.c | 3 +-
> tools/perf/tests/tests.h | 2 +
> tools/perf/tests/tool_pmu.c | 111 +++
> tools/perf/util/Build | 2 +
> tools/perf/util/evsel.c | 287 +-----
> tools/perf/util/evsel.h | 28 +-
> tools/perf/util/expr.c | 93 +-
> tools/perf/util/hwmon_pmu.c | 818 ++++++++++++++++++
> tools/perf/util/hwmon_pmu.h | 154 ++++
> tools/perf/util/metricgroup.c | 35 +-
> tools/perf/util/parse-events.c | 62 +-
> tools/perf/util/parse-events.h | 5 +-
> tools/perf/util/parse-events.l | 11 -
> tools/perf/util/parse-events.y | 16 -
> tools/perf/util/pmu.c | 104 ++-
> tools/perf/util/pmu.h | 9 +-
> tools/perf/util/pmus.c | 16 +
> tools/perf/util/pmus.h | 3 +
> tools/perf/util/print-events.c | 36 +-
> tools/perf/util/print-events.h | 1 -
> tools/perf/util/stat-display.c | 14 +-
> tools/perf/util/stat-shadow.c | 22 +-
> tools/perf/util/tool_pmu.c | 508 +++++++++++
> tools/perf/util/tool_pmu.h | 56 ++
> tools/perf/util/tsc.h | 2 +-
> 37 files changed, 2376 insertions(+), 628 deletions(-)
> create mode 100644 tools/perf/pmu-events/arch/common/common/tool.json
> create mode 100644 tools/perf/tests/hwmon_pmu.c
> create mode 100644 tools/perf/tests/tool_pmu.c
> create mode 100644 tools/perf/util/hwmon_pmu.c
> create mode 100644 tools/perf/util/hwmon_pmu.h
> create mode 100644 tools/perf/util/tool_pmu.c
> create mode 100644 tools/perf/util/tool_pmu.h
>
> --
> 2.46.0.662.g92d0881bb0-goog
>
next prev parent reply other threads:[~2024-09-12 22:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 19:03 [PATCH v2 00/13] Tool and hwmon PMUs Ian Rogers
2024-09-12 19:03 ` [PATCH v2 01/13] perf pmu: Simplify an asprintf error message Ian Rogers
2024-09-12 19:18 ` Arnaldo Carvalho de Melo
2024-09-12 19:03 ` [PATCH v2 02/13] perf pmu: Allow hardcoded terms to be applied to attributes Ian Rogers
2024-09-12 19:03 ` [PATCH v2 03/13] perf parse-events: Expose/rename config_term_name Ian Rogers
2024-09-12 19:03 ` [PATCH v2 04/13] perf tool_pmu: Factor tool events into their own PMU Ian Rogers
2024-09-12 19:03 ` [PATCH v2 05/13] perf tool_pmu: Rename enum perf_tool_event to tool_pmu_event Ian Rogers
2024-09-12 19:03 ` [PATCH v2 06/13] perf tool_pmu: Rename perf_tool_event__* to tool_pmu__* Ian Rogers
2024-09-12 19:03 ` [PATCH v2 07/13] perf tool_pmu: Move expr literals to tool_pmu Ian Rogers
2024-09-12 19:03 ` [PATCH v2 08/13] perf jevents: Add tool event json under a common architecture Ian Rogers
2024-09-12 19:03 ` [PATCH v2 09/13] perf tool_pmu: Switch to standard pmu functions and json descriptions Ian Rogers
2024-09-12 19:03 ` [PATCH v2 10/13] perf tests: Add tool PMU test Ian Rogers
2024-09-12 19:03 ` [PATCH v2 11/13] perf hwmon_pmu: Add a tool PMU exposing events from hwmon in sysfs Ian Rogers
2024-09-12 19:03 ` [PATCH v2 12/13] perf test: Add hwmon "PMU" test Ian Rogers
2024-09-12 19:03 ` [PATCH v2 13/13] perf docs: Document tool and hwmon events Ian Rogers
2024-09-12 22:50 ` Namhyung Kim [this message]
2024-09-13 14:34 ` [PATCH v2 00/13] Tool and hwmon PMUs Ian Rogers
2024-09-26 19:47 ` Ian Rogers
2024-09-27 17:22 ` Namhyung Kim
2024-09-27 18:09 ` Ian Rogers
2024-09-29 7:21 ` Namhyung Kim
2024-10-01 4:56 ` Ian Rogers
2024-10-01 23:39 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuNwJ07GyMVIT0Qi@google.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=asmadeus@codewreck.org \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=bgray@linux.ibm.com \
--cc=changbin.du@huawei.com \
--cc=clement.legoffic@foss.st.com \
--cc=colin.i.king@gmail.com \
--cc=hejunhao3@huawei.com \
--cc=howardchu95@gmail.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux@treblig.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=oliver.upton@linux.dev \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=renyu.zj@linux.alibaba.com \
--cc=sandipan.das@amd.com \
--cc=sunhaiyong@loongson.cn \
--cc=vmolnaro@redhat.com \
--cc=weilin.wang@intel.com \
--cc=will@kernel.org \
--cc=xu.yang_2@nxp.com \
--cc=yangjihong@bytedance.com \
--cc=yangtiezhu@loongson.cn \
--cc=yangyicong@hisilicon.com \
--cc=zegao2021@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).