From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56B2B194088 for ; Thu, 19 Sep 2024 10:17:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726741068; cv=none; b=fYzMLU74m+99VOGeyAkIRAv3ezr8+tj9ZB1ir6UyJM9KfW7IB2Ymy3ZKhGvdhcBIf8wySQPaDVcckRH4gHRFplxNm8E0n7p+Smf+ftmXKDUsakK6UcWKSALBEeBZpJvQRunbTFmDwTu7I+jqeutVsCLDL2m9g3p8en1oKV1B1kc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726741068; c=relaxed/simple; bh=JRE51gP5UxLcgAGuT2g5r97Z6STrbAowK6q6kqli0ZU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F541x9B4/tsgYQy9e8MMwsz61uJQH1DC4QpYOHM5ewtz0AZejP2qUiPq4XOXOYLEXaRBKwXJzeroBt9rV/Lwe9P0ZbgtlRtdj5ZNhrunZT6+19RVGgvoS9xSAPwvaOT02fJx/74H3n0L0nWpXKh/fIoTOkHqZ2N5+zX5/Ej/56g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=D6x6BKht; arc=none smtp.client-ip=91.218.175.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="D6x6BKht" Date: Thu, 19 Sep 2024 03:17:38 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1726741064; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I1mckTS2FV38bbZ879rd+/BowKPTlDKekDspILq4S7U=; b=D6x6BKhtU1AsDKi/4KqvcONlUrTfddheLB6mjS/liWOZikXBBbl320OPz8mgGIKM4WllXD +wY9aYHdLlkmHh4egDXFCzDa+mmurZ3C2W/5Yn9b7oeoiOBTG25PlxVj4C73Kx3idnOFp+ Vxq68Xs1nMkSJWGZkP3uhgfHcFJ6DPg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Colton Lewis Cc: kvm@vger.kernel.org, Sean Christopherson , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Will Deacon , Russell King , Catalin Marinas , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org Subject: Re: [PATCH v3 0/5] Correct perf sampling with Guest VMs Message-ID: References: <20240912205133.4171576-1-coltonlewis@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240912205133.4171576-1-coltonlewis@google.com> X-Migadu-Flow: FLOW_OUT On Thu, Sep 12, 2024 at 08:51:28PM +0000, Colton Lewis wrote: > v3: > * Clarify final commit message further > * Remove an unused variable in perf_arch_misc_flags() > > v2: > https://lore.kernel.org/kvm/20240911222433.3415301-1-coltonlewis@google.com/ > > v1: > https://lore.kernel.org/kvm/20240904204133.1442132-1-coltonlewis@google.com/ > > This series cleans up perf recording around guest events and improves > the accuracy of the resulting perf reports. Please fix the intermediate build issue, and also test that each patch in the series compiles. With that corrected, for the series: Reviewed-by: Oliver Upton A nice follow-up on the arm64 side would be to further constrain kvm_arch_pmi_in_guest() to return true iff we exited the guest due to an IRQ. -- Thanks, Oliver