From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41E901A0BDC; Thu, 26 Sep 2024 22:42:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727390562; cv=none; b=lIwJCeEPbGvo7Xc9MQe2DRwFzKYBakhUf63J+EUcI5W08QuN1roGBQG+RS7K0cUPRt1Rr+3AnXro7ZqVrKxhFWUPQjKlmlFfZ+gWcxiQcuzfO6PNjDQb13P6ssCi1DUQ7wRrUu5plevNzxSOQbIqQpT+YpyadC/Q7PAoXNLtUBs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727390562; c=relaxed/simple; bh=iMQd4vC0wBqBiHHWq2fDgAlgawGJPNJVlMLXitCl8Ho=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lDyzI4irSyBb4pfaaH4LErb7G3H+ifcNgsIICrOPEpMLLeIsS0c2MgQUqRGGQIprwzG1UiAb0YjVb1jWvJefhvjwRsFytqufVHfk4eJ3ySY9T5Vcq5wxLP25w9OJ8hRCiKsNYzfqnWMpIUFh0VDNKReBYaElKhsDtCGhPu6OS2M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hmPY/c61; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hmPY/c61" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7178AC4CEC5; Thu, 26 Sep 2024 22:42:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727390561; bh=iMQd4vC0wBqBiHHWq2fDgAlgawGJPNJVlMLXitCl8Ho=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hmPY/c61WPV7SP61jSFY8I8d7af1S6R2tT6/okrYGiDrYZOV8OLv4Rg/rZ4lUyudx zbyfhtRAU2wPF8FcNy5qhpOj0loYhEykgi+2a75Pjt4opidMLw+sr1+WJGDquPxNZQ PIQWVpFBvOagO37LZ9UKRQzLNGnWUsAkaxaM/jE4FYQXZPnfakW75B3k5iX7m9rR/8 CRkr6aj+K9l4JPK6N8l9/iVvl1RpeX6TfUJ0oNMk2yzzBsCvdadoZEbDycvW54kxnu oIU2KpmUkDs3LVnvOYYAMq/He232EtIlReagkZkvR8hdisRaNDyuTXsKGVBzXWGAiW N8ddPG4A60AgA== Date: Thu, 26 Sep 2024 15:42:40 -0700 From: Namhyung Kim To: Thomas Richter Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, acme@kernel.org, agordeev@linux.ibm.com, gor@linux.ibm.com, sumanthk@linux.ibm.com, hca@linux.ibm.com Subject: Re: [PATCH] perf/test: perf test 86 fails on s390 repo linux-next Message-ID: References: <20240916125718.3024270-1-tmricht@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240916125718.3024270-1-tmricht@linux.ibm.com> Hello, On Mon, Sep 16, 2024 at 02:57:18PM +0200, Thomas Richter wrote: > Command perf test 86 fails on s390 using linux-next repository: > # perf test -F 86 > ping 868299 [007] 28248.013596: probe_libc:inet_pton_1: (3ff95948020) > 3ff95948020 inet_pton+0x0 (inlined) > 3ff9595e6e7 text_to_binary_address+0x1007 (inlined) > 3ff9595e6e7 gaih_inet+0x1007 (inlined) > FAIL: expected backtrace entry \ > "main\+0x[[:xdigit:]]+[[:space:]]\(.*/bin/ping.*\)$" > got "3ff9595e6e7 gaih_inet+0x1007 (inlined)" > 86: probe libc's inet_pton & backtrace it with ping : FAILED! > # > > The root cause is a new stack layout, some functions have been added > as seen below. Add text_to_binary_address and friends to the > list of expected functions. > > # perf script | tac | grep -m1 '^ping' -B9 | tac > ping 866856 [007] 25979.494921: probe_libc:inet_pton: (3ff8ec48020) > 3ff8ec48020 inet_pton+0x0 (inlined) > 3ff8ec5e6e7 text_to_binary_address+0x1007 (inlined) > 3ff8ec5e6e7 gaih_inet+0x1007 (inlined) > 3ff8ec5e6e7 getaddrinfo+0x1007 (/usr/lib64/libc.so.6) > 2aa3fe04bf5 main+0xff5 (/usr/bin/ping) > 3ff8eb34a5b __libc_start_call_main+0x8b (/usr/lib64/libc.so.6) > 3ff8eb34b5d __libc_start_main@GLIBC_2.2+0xad (inlined) > 2aa3fe06a1f [unknown] (/usr/bin/ping) Is it because of a kernel change? What about old kernels then? > > # > > Output after: > # perf test -F 86 > 86: probe libc's inet_pton & backtrace it with ping : Ok > # > > Signed-off-by: Thomas Richter > --- > tools/perf/tests/shell/record+probe_libc_inet_pton.sh | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/perf/tests/shell/record+probe_libc_inet_pton.sh b/tools/perf/tests/shell/record+probe_libc_inet_pton.sh > index f38c8ead0b03..bc6e2fe1d999 100755 > --- a/tools/perf/tests/shell/record+probe_libc_inet_pton.sh > +++ b/tools/perf/tests/shell/record+probe_libc_inet_pton.sh > @@ -40,6 +40,8 @@ trace_libc_inet_pton_backtrace() { > case "$(uname -m)" in > s390x) > eventattr='call-graph=dwarf,max-stack=4' > + echo "text_to_binary_address\+0x[[:xdigit:]]+[[:space:]]\($libc|inlined\)$" >> $expected > + echo "gaih_inet\+0x[[:xdigit:]]+[[:space:]]\($libc|inlined\)$" >> $expected Is it possible to make it this part conditional and only have it for the new kernels? Thanks, Namhyung > echo "(__GI_)?getaddrinfo\+0x[[:xdigit:]]+[[:space:]]\($libc|inlined\)$" >> $expected > echo "main\+0x[[:xdigit:]]+[[:space:]]\(.*/bin/ping.*\)$" >> $expected > ;; > -- > 2.46.0 >