From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ian Rogers <irogers@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] perf vdso: Missed put on 32-bit dsos
Date: Fri, 27 Sep 2024 15:39:59 -0300 [thread overview]
Message-ID: <Zvb7_9Z9QGOVuOD6@x1> (raw)
In-Reply-To: <ZvH4p3-kdnZfij_4@google.com>
On Mon, Sep 23, 2024 at 04:24:23PM -0700, Namhyung Kim wrote:
> On Mon, Sep 23, 2024 at 12:01:23PM -0700, Ian Rogers wrote:
> > On Thu, Sep 12, 2024 at 12:31 PM Ian Rogers <irogers@google.com> wrote:
> > >
> > > On Thu, Sep 12, 2024 at 12:15 PM Arnaldo Carvalho de Melo
> > > <acme@kernel.org> wrote:
> > > >
> > > > On Thu, Sep 12, 2024 at 11:27:57AM -0700, Ian Rogers wrote:
> > > > > If the dso type doesn't match then NULL is returned but the dso should
> > > > > be put first.
> > > >
> > > > I guess we can add:
> > > >
> > > > Fixes: f649ed80f3cabbf1 ("perf dsos: Tidy reference counting and locking")
> > > >
> > > > ?
> > >
> > > Yep, that's the one that added the reference count increment.
> >
> > Noticed this isn't in the tree yet, do I need to resend for the fixes tag?
>
> Arnaldo, can you please pick this up to perf-tools?
Right, I just did that, b4 was nice enough to notice the Fixes tag I
suggested, its in my local branch, will push out soon.
- Arnaldo
prev parent reply other threads:[~2024-09-27 18:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 18:27 [PATCH v1] perf vdso: Missed put on 32-bit dsos Ian Rogers
2024-09-12 19:15 ` Arnaldo Carvalho de Melo
2024-09-12 19:31 ` Ian Rogers
2024-09-23 19:01 ` Ian Rogers
2024-09-23 23:24 ` Namhyung Kim
2024-09-27 18:39 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zvb7_9Z9QGOVuOD6@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).