From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D3DA372; Fri, 11 Oct 2024 00:06:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728605179; cv=none; b=R9lYeWszCIdMTImtW30Wd5cmBI+eZ/qQNbb/cqiqJmn9jgFd3+97WAt646a5rZEUxJ5tqsZsLb+RvTn9z7HEuyBpwpTn4jkaXyPLxA/DgP9Q+aKrMgzj7Vmc0N4tCgFR88vOqHOPf/7/59vcPmTdzMhV5f/CzUZf0wqkEHnjZ/o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728605179; c=relaxed/simple; bh=ulLpKeu0JdsifZZ5CO6ykZ9G7j9XUv412TFM6Gaf+AA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=W2CHardYsqq6UpZila5XrvZwltbjrV5xGnT4MobS7dNb4GMph0I2V68z3D3hrxGUch0tWzyTy1m9+GDEDzhjBJnLBU5XPrOEzZ5784w0rXfJxNXANSqsKjqvgc4zzhr9G9gm11do7zG9aBJ+eEPRxNjZIemaxHzanq5yS8nt8ek= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=axBYIlF9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="axBYIlF9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E4A6C4CEC5; Fri, 11 Oct 2024 00:06:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728605177; bh=ulLpKeu0JdsifZZ5CO6ykZ9G7j9XUv412TFM6Gaf+AA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=axBYIlF9JxLfcuEjGuhkra8E1hQeG1RlXakc6BdWCIz2v+8fU3jESS93vJRvwTmBj aHUQH2uoavv9j1/JdnBBRQOeVBhdXFGARN2R/e6pslsG/wDTlsYf2UeQyi6hvteXuM ijWJ/40ashiKU/K/Ei6VxHuT8hae6PaxxkP+hqzil7Hel4onJK51SFbHier1jV4D3Y vDkroJFWcce1w+7LM8Vd2H5+rKAE9FXIyJzVvD1ZQtwyap0gFx9iZfKXiwqLFUP07p rT+80jFReFJfF/P0PxCkb2VFmMluGUPyA4lcPl0NqebRA1/7FZ2mm0MWakbNZS0kwM ByGvRYj4kHfZg== Date: Thu, 10 Oct 2024 17:06:15 -0700 From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ian Rogers , Kan Liang , Jiri Olsa , Adrian Hunter , Peter Zijlstra , Ingo Molnar , LKML , linux-perf-users@vger.kernel.org, Masami Hiramatsu , Michael Petlan , Veronika Molnarova Subject: Re: [PATCH] perf test: Fix probe testsuite with a new error message Message-ID: References: <20241010051620.1066407-1-namhyung@kernel.org> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Thu, Oct 10, 2024 at 09:48:47AM -0300, Arnaldo Carvalho de Melo wrote: > On Wed, Oct 09, 2024 at 10:16:20PM -0700, Namhyung Kim wrote: > > On my system, it's constantly failing because of new error message from > > perf probe. It should update the regex pattern to match the message - > > "A function DIE doesn't have decl_line. Maybe broken DWARF?". > > > > $ sudo head -n 2 /sys/kernel/debug/kprobes/blacklist | cut -f2 > > warn_thunk_thunk > > asm_exc_divide_error > > > > $ sudo perf probe warn_thunk_thunk > > A function DIE doesn't have decl_line. Maybe broken DWARF? > > A function DIE doesn't have decl_line. Maybe broken DWARF? > > Probe point 'warn_thunk_thunk' not found. > > Error: Failed to add events. > > > > $ sudo perf probe asm_exc_overflow > > Failed to find scope of probe point. > > Error: Failed to add events. > > We discussed this in the past, I came up with a similar patch, Veronika > rightly pointed out that this may point to a real problem, Masami said > that since these are for DWARF from assembly those are known issues, I > suggested Veronika checked if the CU where the function came from was > generated from Assembly (there are DWARF tags that have that info), IIRC > she said she would try to do it. Oh ok. I was lost in the thread. :) > > I'll try to find out the threads and see what happened. Thanks, I will wait for the next step. Namhyung > > > Cc: Masami Hiramatsu > > Cc: Michael Petlan > > Cc: Veronika Molnarova > > Signed-off-by: Namhyung Kim > > --- > > tools/perf/tests/shell/base_probe/test_adding_blacklisted.sh | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/tools/perf/tests/shell/base_probe/test_adding_blacklisted.sh b/tools/perf/tests/shell/base_probe/test_adding_blacklisted.sh > > index b5dc10b2a73810b3..01e5e09053c37e46 100755 > > --- a/tools/perf/tests/shell/base_probe/test_adding_blacklisted.sh > > +++ b/tools/perf/tests/shell/base_probe/test_adding_blacklisted.sh > > @@ -42,7 +42,8 @@ REGEX_ERROR_MESSAGE="Error: Failed to add events." > > REGEX_INVALID_ARGUMENT="Failed to write event: Invalid argument" > > REGEX_SYMBOL_FAIL="Failed to find symbol at $RE_ADDRESS" > > REGEX_OUT_SECTION="$BLACKFUNC is out of \.\w+, skip it" > > -../common/check_all_lines_matched.pl "$REGEX_SKIP_MESSAGE" "$REGEX_NOT_FOUND_MESSAGE" "$REGEX_ERROR_MESSAGE" "$REGEX_SCOPE_FAIL" "$REGEX_INVALID_ARGUMENT" "$REGEX_SYMBOL_FAIL" "$REGEX_OUT_SECTION" < $LOGS_DIR/adding_blacklisted.err > > +REGEX_BROKEN_DWARF="A function DIE doesn\'t have decl_line\. Maybe broken DWARF\?" > > +../common/check_all_lines_matched.pl "$REGEX_SKIP_MESSAGE" "$REGEX_NOT_FOUND_MESSAGE" "$REGEX_ERROR_MESSAGE" "$REGEX_SCOPE_FAIL" "$REGEX_INVALID_ARGUMENT" "$REGEX_SYMBOL_FAIL" "$REGEX_OUT_SECTION" "$REGEX_BROKEN_DWARF" < $LOGS_DIR/adding_blacklisted.err > > CHECK_EXIT_CODE=$? > > > > print_results $PERF_EXIT_CODE $CHECK_EXIT_CODE "adding blacklisted function $BLACKFUNC" > > -- > > 2.47.0.rc0.187.ge670bccf7e-goog