From: Namhyung Kim <namhyung@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
John Garry <john.g.garry@oracle.com>,
Will Deacon <will@kernel.org>,
James Clark <james.clark@linaro.org>,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linux.dev>,
Yicong Yang <yangyicong@hisilicon.com>,
Weilin Wang <weilin.wang@intel.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
Thomas Richter <tmricht@linux.ibm.com>,
Sumanth Korikkar <sumanthk@linux.ibm.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/8] CSV/JSON metric thresholds, fix printf modifiers
Date: Thu, 17 Oct 2024 09:55:16 -0700 [thread overview]
Message-ID: <ZxFBdCMFZ50oo-s2@google.com> (raw)
In-Reply-To: <CAP-5=fWMkF-z5t6-Oz8e8YRuW0rsMg7JXj4vSHqLZFe0y3=sUA@mail.gmail.com>
On Thu, Oct 17, 2024 at 09:44:08AM -0700, Ian Rogers wrote:
> On Thu, Oct 17, 2024 at 9:39 AM Namhyung Kim <namhyung@kernel.org> wrote:
> >
> > On Wed, 16 Oct 2024 10:53:42 -0700, Ian Rogers wrote:
> >
> > > Metric thresholds are being computed for CSV and JSON output but not
> > > displayed. Rename the color that encodes the threshold as enum values
> > > and use to generate string constants in a CSV column or json
> > > dictionary value.
> > >
> > > Add printf attribute to functions in color.h that could support
> > > it. Fix bad printf format strings that this detected.
> > >
> > > [...]
> >
> > Applied to perf-tools-next, thanks!
>
> Sorry for the trouble, could we switch to the v4 series due to issues
> on hypervisors with not counted events in CSV output missing a column:
> https://lore.kernel.org/lkml/20241016215139.212939-1-irogers@google.com/
> The patch set drops the CSV output metric threshold support.
Oops, sorry for missing v4. And I also noticed a build error on i386.
I'll drop this for now and push perf-tools-next soon.
Thanks,
Namhyung
next prev parent reply other threads:[~2024-10-17 16:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 17:53 [PATCH v3 0/8] CSV/JSON metric thresholds, fix printf modifiers Ian Rogers
2024-10-16 17:53 ` [PATCH v3 1/8] perf color: Add printf format checking and resolve issues Ian Rogers
2024-10-16 17:53 ` [PATCH v3 2/8] perf stat: Fix/add parameter names for print_metric Ian Rogers
2024-10-16 17:53 ` [PATCH v3 3/8] perf stat: Display "none" for NaN with metric only json Ian Rogers
2024-10-16 17:53 ` [PATCH v3 4/8] perf stat: Drop metric-unit if unit is NULL Ian Rogers
2024-10-16 17:53 ` [PATCH v3 5/8] perf stat: Change color to threshold in print_metric Ian Rogers
2024-10-16 17:53 ` [PATCH v3 6/8] perf stat: Display metric threshold value in CSV output Ian Rogers
2024-10-16 17:53 ` [PATCH v3 7/8] perf stat: Add metric-threshold to json output Ian Rogers
2024-10-16 17:53 ` [PATCH v3 8/8] perf stat: Disable metric thresholds for CSV/JSON metric-only mode Ian Rogers
2024-10-16 20:53 ` [PATCH v3 0/8] CSV/JSON metric thresholds, fix printf modifiers Ian Rogers
2024-10-17 16:39 ` Namhyung Kim
2024-10-17 16:44 ` Ian Rogers
2024-10-17 16:55 ` Namhyung Kim [this message]
2024-10-17 17:05 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxFBdCMFZ50oo-s2@google.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sumanthk@linux.ibm.com \
--cc=tim.c.chen@linux.intel.com \
--cc=tmricht@linux.ibm.com \
--cc=weilin.wang@intel.com \
--cc=will@kernel.org \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).