From: Namhyung Kim <namhyung@kernel.org>
To: James Clark <james.clark@linaro.org>
Cc: Ian Rogers <irogers@google.com>,
linux-perf-users <linux-perf-users@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>
Subject: Re: Can perf record make buildid-mmap the default
Date: Mon, 4 Nov 2024 10:28:42 -0800 [thread overview]
Message-ID: <ZykSWgPFytI0e3FE@google.com> (raw)
In-Reply-To: <b53d4d92-7d2d-4bb2-b9b4-9ecf353cf80f@linaro.org>
On Mon, Nov 04, 2024 at 10:25:53AM +0000, James Clark wrote:
>
>
> On 03/11/2024 6:03 am, Ian Rogers wrote:
> > Hi,
> >
> > Without command line flags perf record will post process samples
> > adding DSO buildid events with samples it will also populate the
> > buildid cache. The --buildid-mmap option is superior as mmap events
> > have buildids within them and the buildid cache isn't generated. As
> > buildid-mmap has been available since 5.12, a full major release, can
> > we just make its defaults the defaults for perf record?
> >
> > Thanks,
> > Ian
> >
>
> There's already the perf_can_record_build_id() check when it's requested, so
> seems easy enough to have it on by default only when it's supported.
Probably we can move it to the missing feature detection and enable it
by default.
Thanks,
Namhyung
>
> Ubuntu 20 is still in support and on 5.4 kernel so there could be a small
> potential to break someones workflow if we had it on unconditionally.
>
>
>
>
prev parent reply other threads:[~2024-11-04 18:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-03 6:03 Can perf record make buildid-mmap the default Ian Rogers
2024-11-04 10:25 ` James Clark
2024-11-04 18:28 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZykSWgPFytI0e3FE@google.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).