From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 514741ABEBA; Mon, 4 Nov 2024 23:30:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730763056; cv=none; b=VjdjF/al3ANStG8o0BT/lzfsG0EqYRANEiDxs5Tr7A5nzZvmDFe2lswlOgDPsNA4vMvykmXPoq+YJZCq+uNChfSjeZ+EZ5hN12WhTTCmwHpMV61z7gfChgRpuJECkd2R9xrRwXYSF346FMYJ5olElC4FsKR18qFZcZ96yPKJT9s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730763056; c=relaxed/simple; bh=hJhl8MJ+oO5wSq1y/pplD9Xg9rKSnY+dmsRkSF8q9Cc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BuHzpMOsqZPMYG7izJn60LbQRm5bsQT0Ri4PTU5oESxipqAkME85Kg9mEELlAcipMHl/TrCbomO2nBFdy+dkie7L1tMwWNRkkIemKAMELgFh812Ns+neeBo7584w1gVpGF8YBLes2Y9fDMFcRJtYYrMV6n0TGmBE83Do5q4L4es= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rtJ1tpx4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rtJ1tpx4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D404C4CECE; Mon, 4 Nov 2024 23:30:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730763056; bh=hJhl8MJ+oO5wSq1y/pplD9Xg9rKSnY+dmsRkSF8q9Cc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rtJ1tpx4rPV0jJfZc0b84WvJulNkkE+gfGhAGanvG18jmx3L4B8dQ8vnfNKzLdHMt zU0B3PrQ7FnllNNgNmDRGmoRcj8BKXYDy7U5vxjOmtWSEgZVGiQn0FkNogsBX7+5x6 410+Tq4zU+EBKobHXIgQYsxRZw3Uanm50ySr2YcqQFqyqiz1J5fX0pf4i6Ktbc17dF 1n4cck6PHPNghxhlZkWqjnlvh8+8kQdECdJ/iR48EoVmBeWc6VqDevkHQt1Duoc9Yk oaukCRjmpHSAsnOB/LIxSdr8EH2yPcreaQkZ7ubtuSA8wOrVb8wsNDIpI7ub0zx6tE jJpM6QgJw3LnQ== Date: Mon, 4 Nov 2024 15:30:53 -0800 From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , Thomas Gleixner , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , Athira Rajeev , Howard Chu , James Clark , Leo Yan , Thomas Richter , Veronika Molnarova Subject: Re: [PATCH 2/2] perf test: Don't build the python binding builtin test case with NO_LIBPYTHON=1 Message-ID: References: <20241104175953.535202-1-acme@kernel.org> <20241104175953.535202-3-acme@kernel.org> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20241104175953.535202-3-acme@kernel.org> On Mon, Nov 04, 2024 at 02:59:53PM -0300, Arnaldo Carvalho de Melo wrote: > From: Arnaldo Carvalho de Melo > > The python_use test suite was being built even when the python binding > that it is designed to test is not being built, fix it. Can we keep the test and skip it instead? It'd be helpful to maintain the test number consistent and to give a clear message why it skipped. Thanks, Namhyung > > Testing this patch: > > When building with NO_LIBPYTHON=1, i.e. explicitely disabling linking > against libpython and thus not building the python binding: > > $ perf check feature libpython > libpython: [ OFF ] # HAVE_LIBPYTHON_SUPPORT > $ perf test "import perf" > $ > > Not disabling linking with libpython, the default, that results in the > python binding being built: > > $ perf check feature libpython > libpython: [ on ] # HAVE_LIBPYTHON_SUPPORT > $ perf test "import perf" > 17: 'import perf' in python : Ok > $ perf test -vv "import perf" > Couldn't bump rlimit(MEMLOCK), failures may take place when creating BPF maps, etc > 17: 'import perf' in python: > --- start --- > test child forked, pid 533419 > python usage test: "'/usr/bin/python3' -c "import sys ; sys.path.insert(0, '/tmp/build/perf-tools-next/python'); import perf" " > ---- end(0) ---- > 17: 'import perf' in python : Ok > $ strace -s1024 -f -e execve perf test 17 > execve("/home/acme/bin/perf", ["perf", "test", "17"], 0x7ffe04832040 /* 38 vars */) = 0 > strace: Process 533458 attached > 17: 'import perf' in python : Running (1 active) > strace: Process 533459 attached > [pid 533459] execve("/bin/sh", ["sh", "-c", "--", "'/usr/bin/python3' -c \"import sys ; sys.path.insert(0, '/tmp/build/perf-tools-next/python'); import perf\" 2> /dev/null"], 0x133179a0 /* 40 vars */) = 0 > strace: Process 533460 attached > [pid 533460] execve("/usr/bin/python3", ["/usr/bin/python3", "-c", "import sys ; sys.path.insert(0, '/tmp/build/perf-tools-next/python'); import perf"], 0x5566715c7280 /* 40 vars */) = 0 > [pid 533460] +++ exited with 0 +++ > [pid 533459] --- SIGCHLD {si_signo=SIGCHLD, si_code=CLD_EXITED, si_pid=533460, si_uid=1000, si_status=0, si_utime=4 /* 0.04 s */, si_stime=2 /* 0.02 s */} --- > [pid 533459] +++ exited with 0 +++ > [pid 533458] --- SIGCHLD {si_signo=SIGCHLD, si_code=CLD_EXITED, si_pid=533459, si_uid=1000, si_status=0, si_utime=0, si_stime=0} --- > [pid 533458] +++ exited with 0 +++ > 17: 'import perf' in python : Ok > +++ exited with 0 +++ > $ > > Cc: Adrian Hunter > Cc: Athira Rajeev > Cc: Howard Chu > Cc: Ian Rogers > Cc: James Clark > Cc: Jiri Olsa > Cc: Kan Liang > Cc: Leo Yan > Cc: Namhyung Kim > Cc: Thomas Richter > Cc: Veronika Molnarova > Signed-off-by: Arnaldo Carvalho de Melo > --- > tools/perf/tests/Build | 2 +- > tools/perf/tests/builtin-test.c | 2 ++ > tools/perf/tests/tests.h | 2 ++ > 3 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/tests/Build b/tools/perf/tests/Build > index 01ed9335db4dba4e..8596616907adf244 100644 > --- a/tools/perf/tests/Build > +++ b/tools/perf/tests/Build > @@ -20,7 +20,7 @@ perf-test-y += hists_link.o > perf-test-y += hists_filter.o > perf-test-y += hists_output.o > perf-test-y += hists_cumulate.o > -perf-test-y += python-use.o > +perf-test-$(CONFIG_LIBPYTHON) += python-use.o > perf-test-y += bp_signal.o > perf-test-y += bp_signal_overflow.o > perf-test-y += bp_account.o > diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c > index d2cabaa8ad922d68..13f7b24694d1d0b0 100644 > --- a/tools/perf/tests/builtin-test.c > +++ b/tools/perf/tests/builtin-test.c > @@ -79,7 +79,9 @@ static struct test_suite *generic_tests[] = { > &suite__syscall_openat_tp_fields, > #endif > &suite__hists_link, > +#ifdef HAVE_LIBPYTHON_SUPPORT > &suite__python_use, > +#endif > &suite__bp_signal, > &suite__bp_signal_overflow, > &suite__bp_accounting, > diff --git a/tools/perf/tests/tests.h b/tools/perf/tests/tests.h > index af284dd47e5c7855..3144c7916532825c 100644 > --- a/tools/perf/tests/tests.h > +++ b/tools/perf/tests/tests.h > @@ -99,7 +99,9 @@ DECLARE_SUITE(dso_data_cache); > DECLARE_SUITE(dso_data_reopen); > DECLARE_SUITE(parse_events); > DECLARE_SUITE(hists_link); > +#ifdef HAVE_LIBPYTHON_SUPPORT > DECLARE_SUITE(python_use); > +#endif > DECLARE_SUITE(bp_signal); > DECLARE_SUITE(bp_signal_overflow); > DECLARE_SUITE(bp_accounting); > -- > 2.47.0 >