linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Kan Liang <kan.liang@linux.intel.com>,
	Athira Jajeev <atrajeev@linux.vnet.ibm.com>,
	James Clark <james.clark@linaro.org>,
	Dominique Martinet <asmadeus@codewreck.org>,
	Yang Li <yang.lee@linux.alibaba.com>,
	Colin Ian King <colin.i.king@gmail.com>,
	Yang Jihong <yangjihong@bytedance.com>,
	"Steinar H. Gunderson" <sesse@google.com>,
	Oliver Upton <oliver.upton@linux.dev>,
	Ilkka Koskinen <ilkka@os.amperecomputing.com>,
	Ze Gao <zegao2021@gmail.com>, Weilin Wang <weilin.wang@intel.com>,
	Ben Gainey <ben.gainey@arm.com>,
	zhaimingbing <zhaimingbing@cmss.chinamobile.com>,
	Zixian Cai <fzczx123@gmail.com>, Andi Kleen <ak@linux.intel.com>,
	Paran Lee <p4ranlee@gmail.com>,
	Thomas Falcon <thomas.falcon@intel.com>,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	"Steven Rostedt (Google)" <rostedt@goodmis.org>
Subject: Re: [PATCH v2 6/6] perf tests: Enable tests disabled due to tracepoint parsing
Date: Tue, 5 Nov 2024 14:47:31 -0300	[thread overview]
Message-ID: <ZypaM8PoTDQXS61s@x1> (raw)
In-Reply-To: <20241102165400.75785-7-irogers@google.com>

On Sat, Nov 02, 2024 at 09:54:00AM -0700, Ian Rogers wrote:
> Tracepoint parsing required libtraceevent but no longer does. Remove
> the Build logic and #ifdefs that caused the tests not to be run. Test
> code that directly uses libtraceevent is still guarded.

Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>

- Arnaldo

root@x1:~# perf check feature libtraceevent
         libtraceevent: [ OFF ]  # HAVE_LIBTRACEEVENT
root@x1:~# perf test openat
  2: Detect openat syscall event                                     : Ok
  3: Detect openat syscall event on all cpus                         : Ok
root@x1:~# perf test -vv openat
  2: Detect openat syscall event:
--- start ---
test child forked, pid 820095
------------------------------------------------------------
perf_event_attr:
Using CPUID GenuineIntel-6-BA-3
  type                             2 (tracepoint)
  size                             136
  config                           0x2e6 (syscalls:sys_enter_openat)
  { sample_period, sample_freq }   1
  sample_type                      TIME|CPU|PERIOD|RAW
------------------------------------------------------------
sys_perf_event_open: pid 820095  cpu -1  group_fd -1  flags 0x8 = 3
---- end(0) ----
  2: Detect openat syscall event                                     : Ok
  3: Detect openat syscall event on all cpus:
--- start ---
test child forked, pid 820096
------------------------------------------------------------
perf_event_attr:
Using CPUID GenuineIntel-6-BA-3
  type                             2 (tracepoint)
  size                             136
  config                           0x2e6 (syscalls:sys_enter_openat)
  { sample_period, sample_freq }   1
  sample_type                      TIME|CPU|PERIOD|RAW
------------------------------------------------------------
sys_perf_event_open: pid 820096  cpu 0  group_fd -1  flags 0x8 = 8
sys_perf_event_open: pid 820096  cpu 1  group_fd -1  flags 0x8 = 9
sys_perf_event_open: pid 820096  cpu 2  group_fd -1  flags 0x8 = 10
sys_perf_event_open: pid 820096  cpu 3  group_fd -1  flags 0x8 = 11
sys_perf_event_open: pid 820096  cpu 4  group_fd -1  flags 0x8 = 12
sys_perf_event_open: pid 820096  cpu 5  group_fd -1  flags 0x8 = 13
sys_perf_event_open: pid 820096  cpu 6  group_fd -1  flags 0x8 = 14
sys_perf_event_open: pid 820096  cpu 7  group_fd -1  flags 0x8 = 15
sys_perf_event_open: pid 820096  cpu 8  group_fd -1  flags 0x8 = 16
sys_perf_event_open: pid 820096  cpu 9  group_fd -1  flags 0x8 = 17
sys_perf_event_open: pid 820096  cpu 10  group_fd -1  flags 0x8 = 18
sys_perf_event_open: pid 820096  cpu 11  group_fd -1  flags 0x8 = 19
---- end(0) ----
  3: Detect openat syscall event on all cpus                         : Ok
root@x1:~#

      reply	other threads:[~2024-11-05 17:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-02 16:53 [PATCH v2 0/6] Avoid parsing tracepoint format just for id Ian Rogers
2024-11-02 16:53 ` [PATCH v2 1/6] tool api fs: Correctly encode errno for read/write open failures Ian Rogers
2024-11-05 17:18   ` Arnaldo Carvalho de Melo
2024-11-02 16:53 ` [PATCH v2 2/6] perf trace-event: Constify print arguments Ian Rogers
2024-11-05 17:18   ` Arnaldo Carvalho de Melo
2024-11-02 16:53 ` [PATCH v2 3/6] perf trace-event: Always build trace-event-info.c Ian Rogers
2024-11-05 17:22   ` Arnaldo Carvalho de Melo
2024-11-02 16:53 ` [PATCH v2 4/6] perf evsel: Add/use accessor for tp_format Ian Rogers
2024-11-05 17:36   ` Arnaldo Carvalho de Melo
2024-11-05 19:33     ` Ian Rogers
2024-11-05 19:52       ` Arnaldo Carvalho de Melo
2024-11-05 21:04         ` Ian Rogers
2024-11-02 16:53 ` [PATCH v2 5/6] perf evsel: Allow evsel__newtp without libtraceevent Ian Rogers
2024-11-05 17:45   ` Arnaldo Carvalho de Melo
2024-11-02 16:54 ` [PATCH v2 6/6] perf tests: Enable tests disabled due to tracepoint parsing Ian Rogers
2024-11-05 17:47   ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZypaM8PoTDQXS61s@x1 \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=asmadeus@codewreck.org \
    --cc=atrajeev@linux.vnet.ibm.com \
    --cc=ben.gainey@arm.com \
    --cc=colin.i.king@gmail.com \
    --cc=fzczx123@gmail.com \
    --cc=ilkka@os.amperecomputing.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=p4ranlee@gmail.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sesse@google.com \
    --cc=thomas.falcon@intel.com \
    --cc=weilin.wang@intel.com \
    --cc=yang.lee@linux.alibaba.com \
    --cc=yangjihong@bytedance.com \
    --cc=zegao2021@gmail.com \
    --cc=zhaimingbing@cmss.chinamobile.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).