From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-172.mta0.migadu.com (out-172.mta0.migadu.com [91.218.175.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9116209F27 for ; Wed, 6 Nov 2024 20:02:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730923339; cv=none; b=i9/UVHHomCFFIYJKJl7ZG42qWdW6iLnr3i9z3DAZBM7SUtUBQeHd3U8NT4ImJsIhrGGmWMk0y7dKtm+0vtQUVRrfoEJAIs2pHRleaKDKw7j1Kn3kg7SLrXBajExx+HNySgCp/JeLRYLZs5DxZYlTwiVVwYCd+f9iv8WrMEXIOUg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730923339; c=relaxed/simple; bh=kr2hSk9kD/Q1HlbZ6L5rhE0nc4/U9zvSmMbYZicmkng=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qMEPwmj9Ax34fPCUKnmBd8L6JnmtBWsSNPAqeirN4AYdToEuh36S7mNlFoxSxbbMs8cCMCGzTlJllcT6TVnZo5tgRPbdvpmZqBU1P/kqTfzYz7qutOu1IO6ZQ4YtBe0S2PKx+zc1d5wY4WLyXezXzlfOsVptZYPJ5FMSaisEBwA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Ev2IHzSQ; arc=none smtp.client-ip=91.218.175.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Ev2IHzSQ" Date: Wed, 6 Nov 2024 12:02:02 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1730923334; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SOBsyQjKR+aopD9T4x3Q0P1OVO7qyX9T6pAaFYsEySE=; b=Ev2IHzSQp/e4ZHbWSktOjEbNH4Qrutu7t3FQZgZAUdjLZ2w0IRzdDpE0H0/CbqWzpKlYQ9 YoBodBX6TP/KL8N4d4CPCs7LoHILZ6KO7RZoORayqY7Bdtm+n+C1UqxpuBYqJothRojsuy YXhRfwcYbNxEKBIQGEpmwmMsXoiL+Q4= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: "Liang, Kan" Cc: Colton Lewis , kvm@vger.kernel.org, Sean Christopherson , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Will Deacon , Russell King , Catalin Marinas , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org Subject: Re: [PATCH v6 4/5] x86: perf: Refactor misc flag assignments Message-ID: References: <20241105195603.2317483-1-coltonlewis@google.com> <20241105195603.2317483-5-coltonlewis@google.com> <65675ed8-e569-47f8-b1eb-40c853751bfb@linux.intel.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <65675ed8-e569-47f8-b1eb-40c853751bfb@linux.intel.com> X-Migadu-Flow: FLOW_OUT On Wed, Nov 06, 2024 at 11:03:10AM -0500, Liang, Kan wrote: > > +static unsigned long common_misc_flags(struct pt_regs *regs) > > +{ > > + if (regs->flags & PERF_EFLAGS_EXACT) > > + return PERF_RECORD_MISC_EXACT_IP; > > + > > + return 0; > > +} > > + > > +unsigned long perf_arch_guest_misc_flags(struct pt_regs *regs) > > +{ > > + unsigned long guest_state = perf_guest_state(); > > + unsigned long flags = common_misc_flags(regs); > > + > > + if (guest_state & PERF_GUEST_USER) > > + flags |= PERF_RECORD_MISC_GUEST_USER; > > + else if (guest_state & PERF_GUEST_ACTIVE) > > + flags |= PERF_RECORD_MISC_GUEST_KERNEL; > > + > > The logic of setting the GUEST_KERNEL flag is implicitly changed here. > > For the current code, the GUEST_KERNEL flag is set for !PERF_GUEST_USER, > which include both guest_in_kernel and guest_in_NMI. Where is the "guest_in_NMI" state coming from? KVM only reports user v. kernel mode. -- Thanks Oliver