From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] perf test: Add missing __exit calls in tool/hwmon tests
Date: Sat, 16 Nov 2024 16:29:44 -0300 [thread overview]
Message-ID: <ZzjyqGH_tAzJh7vz@x1> (raw)
In-Reply-To: <20241115201258.509477-1-irogers@google.com>
On Fri, Nov 15, 2024 at 12:12:58PM -0800, Ian Rogers wrote:
> Address sanitizer flagged the missing parse_events_error__exit when
> testing on ARM.
Thanks, applied to perf-tools-next,
- Arnaldo
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/tests/hwmon_pmu.c | 1 +
> tools/perf/tests/tool_pmu.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/tools/perf/tests/hwmon_pmu.c b/tools/perf/tests/hwmon_pmu.c
> index 5c4114354c65..9f44093f18df 100644
> --- a/tools/perf/tests/hwmon_pmu.c
> +++ b/tools/perf/tests/hwmon_pmu.c
> @@ -194,6 +194,7 @@ static int do_test(size_t i, bool with_pmu, bool with_alias)
> }
>
> out:
> + parse_events_error__exit(&err);
> evlist__delete(evlist);
> return ret;
> }
> diff --git a/tools/perf/tests/tool_pmu.c b/tools/perf/tests/tool_pmu.c
> index 46896b485abf..187942b749b7 100644
> --- a/tools/perf/tests/tool_pmu.c
> +++ b/tools/perf/tests/tool_pmu.c
> @@ -66,6 +66,7 @@ static int do_test(enum tool_pmu_event ev, bool with_pmu)
> }
>
> out:
> + parse_events_error__exit(&err);
> evlist__delete(evlist);
> return ret;
> }
> --
> 2.47.0.338.g60cca15819-goog
prev parent reply other threads:[~2024-11-16 19:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 20:12 [PATCH v1] perf test: Add missing __exit calls in tool/hwmon tests Ian Rogers
2024-11-16 19:29 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzjyqGH_tAzJh7vz@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox