From: "Liang, Kan" <kan.liang@linux.intel.com>
To: Ian Rogers <irogers@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Ravi Bangoria <ravi.bangoria@amd.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>,
Weilin Wang <weilin.wang@intel.com>
Subject: Re: [PATCH v1 0/4] Intel metric fixes and event updates
Date: Tue, 1 Aug 2023 13:48:45 -0400 [thread overview]
Message-ID: <a0d5ec0a-e5d9-5938-fa6b-1d60b2aac019@linux.intel.com> (raw)
In-Reply-To: <20230801053634.1142634-1-irogers@google.com>
On 2023-08-01 1:36 a.m., Ian Rogers wrote:
> The metric tma_info_pipeline_retire contains uops_retired.slots with
> perf metric events. Patch 1 fixes this event sorting so that
> uops_retired.slots isn't made a group leader as that needs to be
> topdown.slots.
>
> Patch 2 and 3 update the meteorlake and sapphirerapids events.
>
> Patch 4 addresses an issue with event grouping discussed in:
> https://lore.kernel.org/lkml/20230719001836.198363-3-irogers@google.com/
> by adding and altering metric constraints. The constraints avoid
> groups for metrics where the kernel PMU fails to not open the group
> (the trigger for the weak group being removed).
>
> Ian Rogers (4):
> perf parse-events x86: Avoid sorting uops_retired.slots
> perf vendor events intel: Update meteorlake to 1.04
> perf vendor events intel: Update sapphirerapids to 1.15
> perf vendor events intel: Update Icelake+ metric constraints
>
Thanks Ian.
Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Thanks,
Kan
> tools/perf/arch/x86/util/evlist.c | 7 +-
> tools/perf/arch/x86/util/evsel.c | 7 +-
> .../arch/x86/alderlake/adl-metrics.json | 11 +-
> .../arch/x86/alderlaken/adln-metrics.json | 2 +
> .../arch/x86/icelake/icl-metrics.json | 10 +-
> .../arch/x86/icelakex/icx-metrics.json | 10 +-
> tools/perf/pmu-events/arch/x86/mapfile.csv | 4 +-
> .../pmu-events/arch/x86/meteorlake/cache.json | 165 ++++++++++++++++++
> .../arch/x86/meteorlake/floating-point.json | 8 +
> .../arch/x86/meteorlake/frontend.json | 56 ++++++
> .../arch/x86/meteorlake/memory.json | 80 +++++++++
> .../pmu-events/arch/x86/meteorlake/other.json | 16 ++
> .../arch/x86/meteorlake/pipeline.json | 159 +++++++++++++++++
> .../arch/x86/rocketlake/rkl-metrics.json | 10 +-
> .../arch/x86/sapphirerapids/other.json | 18 ++
> .../arch/x86/sapphirerapids/spr-metrics.json | 9 +-
> .../arch/x86/tigerlake/tgl-metrics.json | 10 +-
> 17 files changed, 549 insertions(+), 33 deletions(-)
>
next prev parent reply other threads:[~2023-08-01 17:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 5:36 [PATCH v1 0/4] Intel metric fixes and event updates Ian Rogers
2023-08-01 5:36 ` [PATCH v1 1/4] perf parse-events x86: Avoid sorting uops_retired.slots Ian Rogers
2023-08-01 15:40 ` Liang, Kan
2023-08-01 15:54 ` Ian Rogers
2023-08-01 17:48 ` Liang, Kan
2023-08-01 5:36 ` [PATCH v1 2/4] perf vendor events intel: Update meteorlake to 1.04 Ian Rogers
2023-08-01 5:36 ` [PATCH v1 3/4] perf vendor events intel: Update sapphirerapids to 1.15 Ian Rogers
2023-08-01 5:36 ` [PATCH v1 4/4] perf vendor events intel: Update Icelake+ metric constraints Ian Rogers
2023-08-01 17:48 ` Liang, Kan [this message]
2023-08-01 18:51 ` [PATCH v1 0/4] Intel metric fixes and event updates Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0d5ec0a-e5d9-5938-fa6b-1d60b2aac019@linux.intel.com \
--to=kan.liang@linux.intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=weilin.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).