From: Yang Jihong <yangjihong@bytedance.com>
To: Ian Rogers <irogers@google.com>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
namhyung@kernel.org, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
adrian.hunter@intel.com, kan.liang@linux.intel.com,
james.clark@arm.com, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf build: Specify libtraceevent dir to rpath for asan/msan build
Date: Mon, 13 May 2024 15:53:37 +0800 [thread overview]
Message-ID: <a476b77f-4d7d-4dbb-b58f-cfc39c07e91e@bytedance.com> (raw)
In-Reply-To: <CAP-5=fXYH4JnfQH98vPRttViBfYAWGA-aoGXO7q+R_Wt8AqFSw@mail.gmail.com>
Hello,
On 5/9/24 07:18, Ian Rogers wrote:
> On Mon, May 6, 2024 at 1:17 AM Yang Jihong <yangjihong@bytedance.com> wrote:
>>
>> perf built by asan/msan will not search for shared libraries in the
>> -L directory. For cross-compilation, we assume that sanitizers is
>> generally not enabled and add libtraceevent dir to rpath in a simple way.
>>
>> 1. msan build
>>
>> Before:
>> $ make -C tools/perf O=/tmp/perf DEBUG=1 EXTRA_CFLAGS="-O0 -g -fno-omit-frame-pointer -fsanitize=memory -fsanitize-memory-track-origins" CC=clang CXX=clang++ HOSTCC=clang NO_LIBELF=1 BUILD_BPF_SKEL=0 NO_LIBPFM=1 LIBTRACEEVENT_DIR=/opt/libtraceevent
>> ...
>> $ /tmp/perf/perf
>> /tmp/perf/perf: error while loading shared libraries: libtraceevent.so.1: cannot open shared object file: No such file or directory
>>
>> After:
>> $ make -C tools/perf O=/tmp/perf DEBUG=1 EXTRA_CFLAGS="-O0 -g -fno-omit-frame-pointer -fsanitize=memory -fsanitize-memory-track-origins" CC=clang CXX=clang++ HOSTCC=clang NO_LIBELF=1 BUILD_BPF_SKEL=0 NO_LIBPFM=1 LIBTRACEEVENT_DIR=/opt/libtraceevent
>> ...
>> $ /tmp/perf/perf --build-options
>> perf version 6.9.0-rc5
>> <SNIP>
>> libtraceevent: [ on ] # HAVE_LIBTRACEEVENT
>> <SNIP>
>>
>> 2. asan build
>>
>> Before:
>> $ make DEBUG=1 EXTRA_CFLAGS='-fno-omit-frame-pointer -fsanitize=address' LIBTRACEEVENT_DIR=/opt/libtraceevent
>> ...
>> $ ./perf
>> ./perf: error while loading shared libraries: libtraceevent.so.1: cannot open shared object file: No such file or directory
>>
>> After:
>> $ make DEBUG=1 EXTRA_CFLAGS='-fno-omit-frame-pointer -fsanitize=address' LIBTRACEEVENT_DIR=/opt/libtraceevent
>> ...
>> $ ./perf --build-options
>> perf version 6.9.0-rc5
>> <SNIP>
>> libtraceevent: [ on ] # HAVE_LIBTRACEEVENT
>> <SNIP>
>>
>> Signed-off-by: Yang Jihong <yangjihong@bytedance.com>
>> ---
>> tools/perf/Makefile.config | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
>> index 7f1e016a9253..a9a923358604 100644
>> --- a/tools/perf/Makefile.config
>> +++ b/tools/perf/Makefile.config
>> @@ -188,6 +188,10 @@ TRACEEVENTLIBS := -ltraceevent
>> ifdef LIBTRACEEVENT_DIR
>> LIBTRACEEVENT_CFLAGS := -I$(LIBTRACEEVENT_DIR)/include
>> LIBTRACEEVENT_LDFLAGS := -L$(LIBTRACEEVENT_DIR)/lib
>> + # Specify rpath for asan/msan build. Generally, cross-compilation will not enable sanitizers.
>> + ifeq ($(findstring -fsanitize=,${EXTRA_CFLAGS}),-fsanitize=)
>> + LIBTRACEEVENT_LDFLAGS += -Wl,-rpath,$(LIBTRACEEVENT_DIR)/lib
>> + endif
>
> Thanks for this! I found I need the following to make it work:
> ```
> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> index a9a923358604..bcf4ab292462 100644
> --- a/tools/perf/Makefile.config
> +++ b/tools/perf/Makefile.config
> @@ -190,7 +190,11 @@ ifdef LIBTRACEEVENT_DIR
> LIBTRACEEVENT_LDFLAGS := -L$(LIBTRACEEVENT_DIR)/lib
> # Specify rpath for asan/msan build. Generally, cross-compilation
> will not enable sanitizers.
> ifeq ($(findstring -fsanitize=,${EXTRA_CFLAGS}),-fsanitize=)
> - LIBTRACEEVENT_LDFLAGS += -Wl,-rpath,$(LIBTRACEEVENT_DIR)/lib
> + ifeq (${IS_64_BIT}, 1)
> + LIBTRACEEVENT_LDFLAGS += -Wl,-rpath,$(LIBTRACEEVENT_DIR)/lib64
> + else
> + LIBTRACEEVENT_LDFLAGS += -Wl,-rpath,$(LIBTRACEEVENT_DIR)/lib
> + endif
> endif
> endif
> FEATURE_CHECK_CFLAGS-libtraceevent := $(LIBTRACEEVENT_CFLAGS)
> ```
>
> My libtraceevent build command is:
> $ make EXTRA_CFLAGS="-O0 -g -fsanitize=address" DESTDIR=~/libtrace install
My build environment only uses make, not make install, so the library
path is lib, not lib64, which leads to this difference.
# cd /opt/libtraceevent
# CROSS_COMPILE=aarch64-linux-gnu- make
In order to be compatible with both situations, would it be better for
us to also add the lib64 path to -L and rpath?
I have sent the v2 version and added it to path2. Please help me see if
this solution is OK:
https://lore.kernel.org/all/20240513074910.1660373-1-yangjihong@bytedance.com/
Thanks,
Yang
next prev parent reply other threads:[~2024-05-13 7:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 8:16 [PATCH] perf build: Specify libtraceevent dir to rpath for asan/msan build Yang Jihong
2024-05-08 23:18 ` Ian Rogers
2024-05-13 7:53 ` Yang Jihong [this message]
2024-05-13 17:57 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a476b77f-4d7d-4dbb-b58f-cfc39c07e91e@bytedance.com \
--to=yangjihong@bytedance.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).