From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE827C77B61 for ; Fri, 28 Apr 2023 15:14:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230421AbjD1PO1 (ORCPT ); Fri, 28 Apr 2023 11:14:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346371AbjD1POS (ORCPT ); Fri, 28 Apr 2023 11:14:18 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D65DE1FED for ; Fri, 28 Apr 2023 08:13:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682694811; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=depf0vqfZUKkwnLh+yDxi5hRj+V4M9FQr1DR9klBV44=; b=YBR+a4bCr546xC8Qfw2+Ob92cSF3mkMSZCkJ/pPAQpsEzqASHEpJoDy3AkRfg7p3MkmvNg Zl8Qz4hAslxthDXN8ulQU4oD5Ndkvb3lPFMpLnB8UYQmyIFgyJOKNrLW0KM/eq5gS5vKOD drnCVy19/Np6PG9UPVoBKbUqSdsUBOw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-539-1rvUiaL6N7S9MTylmwbYig-1; Fri, 28 Apr 2023 11:13:24 -0400 X-MC-Unique: 1rvUiaL6N7S9MTylmwbYig-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3f173bd0d1bso64312365e9.3 for ; Fri, 28 Apr 2023 08:13:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682694791; x=1685286791; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=depf0vqfZUKkwnLh+yDxi5hRj+V4M9FQr1DR9klBV44=; b=FHnypUa7xJK11lXRTgrt/wT5+Isaun7NMEOfjZhtVhI8xDUhIIPIV0h7LjCdvo2lqR z1UFmP0ELXDQazjssTyTir+5gYzlvEomKUqnXvwvUwYhcl4Cd6qFGX/PtmTJns8dUnDW E+8KsJfrKOhUv6jQS8vDIhfLD4pKA7hTngrULBjFd/he+s+KHthQ3WhBOx4hChwVehI/ itp/JPYOrsYLJRiQDBiA/GqU8wuZv+/9fQErSV8n39jRKsAE2PwvdFcj7JN14EmkRFFe jtm74Q9XlvlhhibXL1y5c/ek4V1+GarKYPd1iwTPCG5fvHoQhlwI5qWJaPtA11BqnHAs BBMA== X-Gm-Message-State: AC+VfDxInvG9nybao7zT4q4Y4rhCiSkKDQRlJ5Yl0SJM/mgcQ7MQp2KX CdGGKs00FrM0yCDkeNRG20dgzH4/guummdvmPx6LDg/yJNXgtBozBxzCUErVRWG+4YIgTQ2WizO vviSG5280ICtai14lY74Bynbb2++MnA== X-Received: by 2002:a7b:cb8f:0:b0:3f1:885f:2e52 with SMTP id m15-20020a7bcb8f000000b003f1885f2e52mr4523093wmi.16.1682694790742; Fri, 28 Apr 2023 08:13:10 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5A46oc6/5KsPhnjzI9jqw0Qx/rYGoBNxjyg10n7h76H5Gcv8U/7NgNFGUbNeZYthhJy5Najw== X-Received: by 2002:a7b:cb8f:0:b0:3f1:885f:2e52 with SMTP id m15-20020a7bcb8f000000b003f1885f2e52mr4523060wmi.16.1682694790337; Fri, 28 Apr 2023 08:13:10 -0700 (PDT) Received: from ?IPV6:2003:cb:c726:9300:1711:356:6550:7502? (p200300cbc72693001711035665507502.dip0.t-ipconnect.de. [2003:cb:c726:9300:1711:356:6550:7502]) by smtp.gmail.com with ESMTPSA id k18-20020a05600c0b5200b003edf2dc7ca3sm24464915wmr.34.2023.04.28.08.13.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Apr 2023 08:13:09 -0700 (PDT) Message-ID: Date: Fri, 28 Apr 2023 17:13:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v5] mm/gup: disallow GUP writing to file-backed mappings by default Content-Language: en-US To: Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Jason Gunthorpe , Jens Axboe , Matthew Wilcox , Dennis Dalessandro , Leon Romanovsky , Christian Benvenuti , Nelson Escobar , Bernard Metzler , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Bjorn Topel , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Christian Brauner , Richard Cochran , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Oleg Nesterov , Jason Gunthorpe , John Hubbard , Jan Kara , "Kirill A . Shutemov" , Pavel Begunkov , Mika Penttila , David Howells , Christoph Hellwig References: <6b73e692c2929dc4613af711bdf92e2ec1956a66.1682638385.git.lstoakes@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org [...] >> This change has the potential to break existing setups. Simple example: >> libvirt domains configured for file-backed VM memory that also has a vfio >> device configured. It can easily be configured by users (evolving VM >> configuration, copy-paste etc.). And it works from a VM perspective, because >> the guest memory is essentially stale once the VM is shutdown and the pages >> were unpinned. At least we're not concerned about stale data on disk. >> >> With your changes, such VMs would no longer start, breaking existing user >> setups with a kernel update. > > Which vfio vm_ops are we talking about? vfio_pci_mmap_ops for example > doesn't specify page_mkwrite or pfn_mkwrite. Unless you mean some arbitrary > file system in the guest? Sorry, you define a VM to have its memory backed by VM memory and, at the same time, define a vfio-pci device for your VM, which will end up long-term pinning the VM memory. > > I may well be missing context on this so forgive me if I'm being a little > dumb here, but it'd be good to get a specific example. I was giving to little details ;) [...] >> >> I know, Jason und John will disagree, but I don't think we want to be very >> careful with changing the default. >> >> Sure, we could warn, or convert individual users using a flag (io_uring). >> But maybe we should invest more energy on a fix? > > This is proactively blocking a cleanup (eliminating vmas) that I believe > will be useful in moving things forward. I am not against an opt-in option > (I have been responding to community feedback in adapting my approach), > which is the way I implemented it all the way back then :) There are alternatives: just use a flag as Jason initially suggested and use that in io_uring code. Then, you can also bail out on the GUP-fast path as "cannot support it right now, never do GUP-fast". IMHO, this patch is not a prereq. > > But given we know this is both entirely broken and a potential security > issue, and FOLL_LONGTERM is about as egregious as you can get (user > explicitly saying they'll hold write access indefinitely) I feel it is an > important improvement and makes clear that this is not an acceptable usage. > > I see Jason has said more on this also :) > >> >> >> >> >>> Suggested-by: Jason Gunthorpe >>> Signed-off-by: Lorenzo Stoakes >>> --- >>> include/linux/mm.h | 1 + >>> mm/gup.c | 41 ++++++++++++++++++++++++++++++++++++++++- >>> mm/mmap.c | 36 +++++++++++++++++++++++++++--------- >>> 3 files changed, 68 insertions(+), 10 deletions(-) >>> >>> diff --git a/include/linux/mm.h b/include/linux/mm.h >>> index 37554b08bb28..f7da02fc89c6 100644 >>> --- a/include/linux/mm.h >>> +++ b/include/linux/mm.h >>> @@ -2433,6 +2433,7 @@ extern unsigned long move_page_tables(struct vm_area_struct *vma, >>> #define MM_CP_UFFD_WP_ALL (MM_CP_UFFD_WP | \ >>> MM_CP_UFFD_WP_RESOLVE) >>> >>> +bool vma_needs_dirty_tracking(struct vm_area_struct *vma); >>> int vma_wants_writenotify(struct vm_area_struct *vma, pgprot_t vm_page_prot); >>> static inline bool vma_wants_manual_pte_write_upgrade(struct vm_area_struct *vma) >>> { >>> diff --git a/mm/gup.c b/mm/gup.c >>> index 1f72a717232b..d36a5db9feb1 100644 >>> --- a/mm/gup.c >>> +++ b/mm/gup.c >>> @@ -959,16 +959,51 @@ static int faultin_page(struct vm_area_struct *vma, >>> return 0; >>> } >>> >>> +/* >>> + * Writing to file-backed mappings which require folio dirty tracking using GUP >>> + * is a fundamentally broken operation, as kernel write access to GUP mappings >>> + * do not adhere to the semantics expected by a file system. >>> + * >>> + * Consider the following scenario:- >>> + * >>> + * 1. A folio is written to via GUP which write-faults the memory, notifying >>> + * the file system and dirtying the folio. >>> + * 2. Later, writeback is triggered, resulting in the folio being cleaned and >>> + * the PTE being marked read-only. >>> + * 3. The GUP caller writes to the folio, as it is mapped read/write via the >>> + * direct mapping. >>> + * 4. The GUP caller, now done with the page, unpins it and sets it dirty >>> + * (though it does not have to). >>> + * >>> + * This results in both data being written to a folio without writenotify, and >>> + * the folio being dirtied unexpectedly (if the caller decides to do so). >>> + */ >>> +static bool writeable_file_mapping_allowed(struct vm_area_struct *vma, >>> + unsigned long gup_flags) >>> +{ >>> + /* If we aren't pinning then no problematic write can occur. */ >>> + if (!(gup_flags & (FOLL_GET | FOLL_PIN))) >>> + return true; >> >> FOLL_LONGTERM only applies to FOLL_PIN. This check can be dropped. > > I understand that of course (well maybe not of course, but I mean I do, I > have oodles of diagrams referencing this int he book :) This is intended to > document the fact that the check isn't relevant if we don't pin at all, > e.g. reading this you see:- > > - (implicit) if not writing or anon we're good > - if not pin we're good > - ok we are only currently checking one especially egregious case > - finally, perform the dirty tracking check. > > So this is intentional. > >> >>> + >>> + /* We limit this check to the most egregious case - a long term pin. */ >>> + if (!(gup_flags & FOLL_LONGTERM)) >>> + return true; >>> + >>> + /* If the VMA requires dirty tracking then GUP will be problematic. */ >>> + return vma_needs_dirty_tracking(vma); >>> +} >>> + >>> static int check_vma_flags(struct vm_area_struct *vma, unsigned long gup_flags) >>> { >>> vm_flags_t vm_flags = vma->vm_flags; >>> int write = (gup_flags & FOLL_WRITE); >>> int foreign = (gup_flags & FOLL_REMOTE); >>> + bool vma_anon = vma_is_anonymous(vma); >>> >>> if (vm_flags & (VM_IO | VM_PFNMAP)) >>> return -EFAULT; >>> >>> - if (gup_flags & FOLL_ANON && !vma_is_anonymous(vma)) >>> + if ((gup_flags & FOLL_ANON) && !vma_anon) >>> return -EFAULT; >>> >>> if ((gup_flags & FOLL_LONGTERM) && vma_is_fsdax(vma)) >>> @@ -978,6 +1013,10 @@ static int check_vma_flags(struct vm_area_struct *vma, unsigned long gup_flags) >>> return -EFAULT; >>> >>> if (write) { >>> + if (!vma_anon && >>> + !writeable_file_mapping_allowed(vma, gup_flags)) >>> + return -EFAULT; >>> + >>> if (!(vm_flags & VM_WRITE)) { >>> if (!(gup_flags & FOLL_FORCE)) >>> return -EFAULT; >>> diff --git a/mm/mmap.c b/mm/mmap.c >>> index 536bbb8fa0ae..7b6344d1832a 100644 >>> --- a/mm/mmap.c >> >> >> I'm probably missing something, why don't we have to handle GUP-fast (having >> said that, it's hard to handle ;) )? The sequence you describe above should >> apply to GUP-fast as well, no? >> >> 1) Pin writable mapped page using GUP-fast >> 2) Trigger writeback >> 3) Write to page via pin >> 4) Unpin and set dirty > > You're right, and this is an excellent point. I worry about other GUP use > cases too, but we're a bit out of luck there because we don't get to check > the VMA _at all_ (which opens yet another Pandora's box about how safe it > is to do unlocked pinning :) > > But again, this comes down to the fact we're trying to make things > _incrementally__ better rather than throwing our hands up and saying one > day my ship will come in... That's not how security fixes are supposed to work IMHO, sorry. -- Thanks, David / dhildenb