From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15A0CC43217 for ; Thu, 10 Nov 2022 19:31:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229622AbiKJTbL (ORCPT ); Thu, 10 Nov 2022 14:31:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229655AbiKJTbK (ORCPT ); Thu, 10 Nov 2022 14:31:10 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id EC2102B623; Thu, 10 Nov 2022 11:31:08 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DDEC61FB; Thu, 10 Nov 2022 11:31:14 -0800 (PST) Received: from [10.1.28.168] (e127744.cambridge.arm.com [10.1.28.168]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7F2163F73D; Thu, 10 Nov 2022 11:31:06 -0800 (PST) Subject: Re: [PATCH 10/12] perf test: Replace brstack test workload From: German Gomez To: Namhyung Kim , Arnaldo Carvalho de Melo , Jiri Olsa Cc: Ingo Molnar , Peter Zijlstra , LKML , Ian Rogers , Adrian Hunter , linux-perf-users@vger.kernel.org, Leo Yan , Zhengjun Xing , James Clark , Athira Jajeev References: <20221110181920.84900-1-namhyung@kernel.org> <20221110181920.84900-11-namhyung@kernel.org> <1036a42b-b438-67b2-c4ca-0e440d266d6d@arm.com> Message-ID: Date: Thu, 10 Nov 2022 19:31:00 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <1036a42b-b438-67b2-c4ca-0e440d266d6d@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On 10/11/2022 19:20, German Gomez wrote: > Hi Namhyung, thanks for doing the refactor, it looks a lot cleaner > > On 10/11/2022 18:19, Namhyung Kim wrote: >> So that it can get rid of requirement of a compiler. Also rename the >> symbols to match with the perf test workload. >> >> Cc: German Gomez >> Signed-off-by: Namhyung Kim >> --- >> tools/perf/tests/shell/test_brstack.sh | 66 +++++--------------------- >> 1 file changed, 12 insertions(+), 54 deletions(-) >> >> diff --git a/tools/perf/tests/shell/test_brstack.sh b/tools/perf/tests/shell/test_brstack.sh >> index ec801cffae6b..a8a182dea25f 100755 >> --- a/tools/perf/tests/shell/test_brstack.sh >> +++ b/tools/perf/tests/shell/test_brstack.sh >> @@ -4,18 +4,12 @@ >> # SPDX-License-Identifier: GPL-2.0 >> # German Gomez , 2022 >> >> -# we need a C compiler to build the test programs >> -# so bail if none is found >> -if ! [ -x "$(command -v cc)" ]; then >> - echo "failed: no compiler, install gcc" >> - exit 2 >> -fi >> - >> # skip the test if the hardware doesn't support branch stack sampling >> # and if the architecture doesn't support filter types: any,save_type,u >> perf record -b -o- -B --branch-filter any,save_type,u true > /dev/null 2>&1 || exit 2 Hmm I was wondering why this command was failing for me and always skipping the test. Is the -b conflicting with the --branch-filter here?