From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88A911B3956 for ; Wed, 14 May 2025 22:51:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747263114; cv=none; b=JbmuNT6CZ/qZCthkH7Mm87idVpuBrFkkVTdfvcTJFeYL0hWs8F1BHozvgsKQKQzWXnZyh4FeyumJJbhxvgjzvWENpogwtK0gOcglGbds1sv4tvgJSfKXFqJft+6XzlJK+iFSyuVXOvzQYB+c4FiK0nr2x99LIdb19sD44vhJABQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747263114; c=relaxed/simple; bh=Yx+Zjd8gx710Elu7lbxjIezJyJKnaGlVtZTgTBUAk5U=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=KaHhcHQRqTFhhiN0XiI634mfhkMSgN47YR60jIwjCNHbpSuoUVkm2/XWWV6i1kZt+Zw1L0rQPYS6V4L+5V0N0iBRkuNGFgChpBIt7APLeXFHa/4OqMXEBQe511rceappjlxnBDKJngq+8RWZu/eVci1ixsiEJeO+9QNZyV2H2TQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=zHwJj5sP; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="zHwJj5sP" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-30c8c9070d2so509827a91.0 for ; Wed, 14 May 2025 15:51:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747263113; x=1747867913; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=B0WOTyEDxpBiCPv/Xdx7yM3kU9rNcMVnr1WH3Yxgiaw=; b=zHwJj5sPB+wVJnHx8XBE0J9CpK8+pIwdmKYZ6JwznOTr2IZ4LF1tbmCeWUeak481by ndoJBkUgYaO7V0PmAXrmPl9u51iydjwjvXxiGb/l6qwgsBI2oc3I3xep9fO3jpTgrTzV xuXF8uzuVGeQnAfY11SC3fuf3wrHVIXC4e0i1B7vUJIz1iT9/oPxua98vZUdUiShtqFL c1EZ+2isAW6s/YXRjMbxQGXeTR2JkcbNqPTYHNjxchQIsw3h0VLVUm5El9ESPuadKuff 8xUSpeVH9xuI/TjWtEhnq52f0vJ5azqjVR5R90kiuyAeZCdy9LaxKshWAiGgln9mwtYc wbjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747263113; x=1747867913; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=B0WOTyEDxpBiCPv/Xdx7yM3kU9rNcMVnr1WH3Yxgiaw=; b=EiR49mRLHU78sb3p7Rwyuhrh3Zes+muQp9HedqVJGagjRlfms89LkzFT2MSkQQIYtg AghHVDOm4e/z2Ccp1IHnCzifAEWjJs+p80klGtGsDPPU0cO9Vu40Xi//4+h9Jth5IlbB CH0OSF5U9u2zVTJFPlmwnUTpP3GKStYRMsMiy1eJRjuPMvW0Un9NCNnjA2KNlSjjyFpH NUPFeux31Y3k/hRGONMRljBoErfXG4gVdPC30QbRi5VcNrGK4uN/bnYwbwBWnonLjosb ns7OonrcSz8543glVKZpBejEZEoCQaEdHO1EiCsJKEtCzfzWYW5sqsrh/z1zpwwqMZeq a2Rw== X-Forwarded-Encrypted: i=1; AJvYcCWvqU8Oo+w1sLVGfFEm7+FIgPtde8XuXtqvKGrOa2jI5pdCTfeVNXSAs4bM/O2QxKtRpyj/6tyPUwl/aJfwWvm3@vger.kernel.org X-Gm-Message-State: AOJu0YzhFb64g56IuupKazNbCu/0lYgzqXqudNDessR0ep0OqM/S/8io lj73CIvGcLLE29gRCCavz34f0fIq5yhAtZmSYifdBF9EW/wfAkrjR8SKVT+DV7hCacL+Sgc4F4z ndg== X-Google-Smtp-Source: AGHT+IFm68kMFpJ/kQ76jO9savH4B9EySo+tG8YG2y7wJxByjQiqkMjXPWcqCUmtRI40yW50UEhrsS4l6KE= X-Received: from pjbqc8.prod.google.com ([2002:a17:90b:2888:b0:2fc:2ee0:d38a]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:5403:b0:309:e351:2e3d with SMTP id 98e67ed59e1d1-30e2e5bb679mr9123064a91.12.1747263112755; Wed, 14 May 2025 15:51:52 -0700 (PDT) Date: Wed, 14 May 2025 15:51:51 -0700 In-Reply-To: <20250324173121.1275209-5-mizhang@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250324173121.1275209-1-mizhang@google.com> <20250324173121.1275209-5-mizhang@google.com> Message-ID: Subject: Re: [PATCH v4 04/38] perf: Add a EVENT_GUEST flag From: Sean Christopherson To: Mingwei Zhang Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Paolo Bonzini , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Liang@google.com, Kan , "H. Peter Anvin" , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, Yongwei Ma , Xiong Zhang , Dapeng Mi , Jim Mattson , Sandipan Das , Zide Chen , Eranian Stephane , Shukla Manali , Nikunj Dadhania Content-Type: text/plain; charset="us-ascii" On Mon, Mar 24, 2025, Mingwei Zhang wrote: > +{ > + if (event->attr.exclude_guest && __this_cpu_read(perf_in_guest)) { My vote is for s/perf_in_guest/guest_ctx_loaded, because "perf in guest" doesn't accurately describe just the mediated PMU case. E.g. perf itself is running in KVM guests when using an emulated vPMU, or no vPMU at all. And with a Kconfig to guard the mediated PMU, this check (and others) can be elided at compile time for architectures that don't support a mediated PMU (or if KVM is disabled). > + /* > + * (now + times[total].offset) - (now + times[guest].offset) := > + * times[total].offset - times[guest].offset > + */ > + return READ_ONCE(times[T_TOTAL].offset) - READ_ONCE(times[T_GUEST].offset); > + } > + > + return now + READ_ONCE(times[T_TOTAL].offset); > +} > +