From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Leo Yan <leo.yan@arm.com>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>,
James Clark <james.clark@linaro.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tests switch-tracking: Fix timestamp comparison
Date: Thu, 22 May 2025 22:51:47 -0300 [thread overview]
Message-ID: <aC_Us1xcKCmYFy_5@x1> (raw)
In-Reply-To: <aC_UKwuokMuf-kzD@x1>
On Thu, May 22, 2025 at 10:49:31PM -0300, Arnaldo Carvalho de Melo wrote:
> On Mon, May 19, 2025 at 06:52:45PM -0700, Namhyung Kim wrote:
> > Hi Leo,
> >
> > On Fri, May 16, 2025 at 04:31:58PM +0100, Leo Yan wrote:
> > > Hi Ian, Namhyung,
> > >
> > > [ - Mailing list ]
> > >
> > > On Wed, Apr 02, 2025 at 10:05:16AM +0100, Leo Yan wrote:
> > > > On Tue, Apr 01, 2025 at 12:54:12PM -0700, Ian Rogers wrote:
> > > > > On Tue, Apr 1, 2025 at 2:14 AM Leo Yan <leo.yan@arm.com> wrote:
> > > > > >
> > > > > > On Mon, Mar 31, 2025 at 01:18:31PM -0700, Ian Rogers wrote:
> > > > > >
> > > > > > [...]
> > > > > >
> > > > > > > I'm reminded of a Java check I wrote for this:
> > > > > >
> > > > > > Nice short article.
> > > > > >
> > > > > > > In clang -Wshorten-64-to-32 looks to cover this. I'll see if we can
> > > > > > > clean those warnings up a bit.
> > > > > >
> > > > > > I checked a bit and seems GCC has no this flag, but it makes sense for
> > > > > > me to enable the flag for Clang.
> > > > > >
> > > > > > > Reviewed-by: Ian Rogers <irogers@google.com>
> > > > > >
> > > > > > Thanks a lot, Ian.
> > > > >
> > > > > I made a small variation to the change in:
> > > > > https://lore.kernel.org/lkml/20250401182347.3422199-10-irogers@google.com/
> > > > > to avoid a subtract and just directly compare the values.
> > >
> > > Do you mind to pick up my this patch? :) Our internal CI reports the
> > > test case 109_Track_with_sched_switch failure daily, I am just wandering
> > > if we could apply the fix quickly.
> >
> > Arnaldo is taking care of patches for v6.15.
> >
> > Arnaldo, can you please take this?
>
> >From what I understood it people agreed to pick Ian's patch, ok.
But that is part of a larger patch, so since Ian reviewed Leo's patch,
I'll end up picking the more contained one, no bandwidth to check all
the other parts now.
- Arnaldo
next prev parent reply other threads:[~2025-05-23 1:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 17:27 [PATCH] perf tests switch-tracking: Fix timestamp comparison Leo Yan
2025-03-31 20:18 ` Ian Rogers
2025-04-01 9:14 ` Leo Yan
2025-04-01 19:54 ` Ian Rogers
2025-04-02 9:05 ` Leo Yan
2025-05-16 15:31 ` Leo Yan
2025-05-20 1:52 ` Namhyung Kim
2025-05-23 1:49 ` Arnaldo Carvalho de Melo
2025-05-23 1:51 ` Arnaldo Carvalho de Melo [this message]
2025-05-23 1:55 ` Arnaldo Carvalho de Melo
2025-05-23 1:57 ` Arnaldo Carvalho de Melo
2025-05-23 8:10 ` Leo Yan
2025-05-23 16:52 ` Ian Rogers
2025-05-23 17:12 ` Arnaldo Carvalho de Melo
2025-05-27 9:49 ` Leo Yan
2025-05-28 13:08 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aC_Us1xcKCmYFy_5@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).