From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: John Hubbard <jhubbard@nvidia.com>,
linux-kernel@vger.kernel.org,
Adrian Hunter <adrian.hunter@intel.com>,
Ian Rogers <irogers@google.com>,
James Clark <james.clark@linaro.org>,
Jiri Olsa <jolsa@kernel.org>,
Kan Liang <kan.liang@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/1 fyi] tools headers UAPI: Sync linux/prctl.h with the kernel sources to pick FUTEX knob
Date: Wed, 11 Jun 2025 10:24:45 -0300 [thread overview]
Message-ID: <aEmDnb4oBXkGGtIh@x1> (raw)
In-Reply-To: <20250611084326.X-sUHsGX@linutronix.de>
On Wed, Jun 11, 2025 at 10:43:26AM +0200, Sebastian Andrzej Siewior wrote:
> On 2025-06-10 17:40:26 [-0300], Arnaldo Carvalho de Melo wrote:
> > tldr; Just FYI, I'm carrying this on the perf tools tree.
>
> Thank you.
>
> > $ tools/perf/trace/beauty/prctl_option.sh > before
> > $ cp include/uapi/linux/prctl.h tools/perf/trace/beauty/include/uapi/linux/prctl.h
> > $ tools/perf/trace/beauty/prctl_option.sh > after
>
> Ah. I missed that copy of prctl.h
>
> …
> > This addresses this perf build warning:
> >
> > Warning: Kernel ABI header differences:
> > diff -u tools/include/uapi/linux/prctl.h include/uapi/linux/prctl.h
>
> But I did cover this one.
I fixed up the warning message being addressed, the attempt was at
having what used in perf just in
tools/perf/trace/beauty/include/uapi/linux/prctl.h, i.e. just for
scrapping, not for building things with it.
But then:
commit c142850fbc956058ff2f2987d3d11eb2c628f710
Author: John Hubbard <jhubbard@nvidia.com>
Date: Mon Jun 17 19:24:21 2024 -0700
selftests/mm: kvm, mdwe fixes to avoid requiring "make headers"
this adds another copy there.
I think we should then remove the
tools/perf/trace/beauty/include/uapi/linux/prctl.h one and make
tools/perf/check_headers.sh to go back to check
tools/include/uapi/linux/prctl.h.
But then, as mentioned in tools/include/uapi/README, its better for
people updating the kernel original files not to update the copy, as it
may break tools/ code if it, for instance, starts including some other
header, etc.
tools people should notice the warning from tools/perf/check_headers.sh
(that now probably should be moved to tools/ as these copies are not
used just by perf...) and check how to update it.
- Arnaldo
parent reply other threads:[~2025-06-11 13:24 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20250611084326.X-sUHsGX@linutronix.de>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEmDnb4oBXkGGtIh@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=bigeasy@linutronix.de \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jhubbard@nvidia.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox