From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
Kan Liang <kan.liang@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v3 5/8] perf annotate: Add --code-with-type support for TUI
Date: Wed, 23 Jul 2025 13:10:16 -0300 [thread overview]
Message-ID: <aIEJaKDNBor71jIn@x1> (raw)
In-Reply-To: <CAP-5=fV=E4_9RVvf1CW0GM0VY+ubr8sOvnXc+xhGW66PhMFCnA@mail.gmail.com>
On Wed, Jul 16, 2025 at 01:42:13PM -0700, Ian Rogers wrote:
> affects sorting. In general I think we should move away from file
> paths, inodes and the like as the build IDs will avoid races, work
> across systems, etc. I think in this case we could add:
<SNIP>
> but in the future we can find the debuginfo off of the build ID and paths, etc.
Yeah, agreed, we better move to make build-id the primary means of
getting what is needed, when that isn't possible, fall back to
filenames.
Then we should check if the hostname in the perf.data header is the same
as the machine running to warn the user about that, other options are to
check the time the perf.data file was created to warn that its likely
updates took place, so take the results with a grain of salt, etc.
If the architecture or distro is different, things we can also see from
the perf.data files, outright refuse to use filenames :-)
- Arnaldo
next prev parent reply other threads:[~2025-07-23 16:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 5:00 [PATCHSET v3 0/8] perf annotate: Support --code-with-type on TUI Namhyung Kim
2025-07-16 5:00 ` [PATCH v3 1/8] perf annotate: Rename to __hist_entry__tui_annotate() Namhyung Kim
2025-07-16 20:16 ` Arnaldo Carvalho de Melo
2025-07-17 0:55 ` Namhyung Kim
2025-07-16 5:00 ` [PATCH v3 2/8] perf annotate: Remove __annotation_line__write() Namhyung Kim
2025-07-16 5:00 ` [PATCH v3 3/8] perf annotate: Pass annotation_print_data to annotation_line__write() Namhyung Kim
2025-07-16 5:00 ` [PATCH v3 4/8] perf annotate: Simplify width calculation in annotation_line__write() Namhyung Kim
2025-07-16 5:00 ` [PATCH v3 5/8] perf annotate: Add --code-with-type support for TUI Namhyung Kim
2025-07-16 15:00 ` Ian Rogers
2025-07-16 17:27 ` Namhyung Kim
2025-07-16 20:42 ` Ian Rogers
2025-07-23 16:10 ` Arnaldo Carvalho de Melo [this message]
2025-07-25 18:28 ` Namhyung Kim
2025-07-23 16:04 ` Arnaldo Carvalho de Melo
2025-07-23 16:20 ` Arnaldo Carvalho de Melo
2025-07-16 5:00 ` [PATCH v3 6/8] perf annotate: Add 'T' hot key to toggle data type display Namhyung Kim
2025-07-16 5:00 ` [PATCH v3 7/8] perf annotate: Show warning when debuginfo is not available Namhyung Kim
2025-07-16 5:00 ` [PATCH v3 8/8] perf annotate: Hide data-type for stack operation and canary Namhyung Kim
2025-07-16 15:02 ` [PATCHSET v3 0/8] perf annotate: Support --code-with-type on TUI Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIEJaKDNBor71jIn@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).