From: Namhyung Kim <namhyung@kernel.org>
To: Yuzhuo Jing <yuzhuo@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Liang Kan <kan.liang@linux.intel.com>,
Yuzhuo Jing <yzj@umich.edu>,
Andrea Parri <parri.andrea@gmail.com>,
Palmer Dabbelt <palmer@rivosinc.com>,
Charlie Jenkins <charlie@rivosinc.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Barret Rhoden <brho@google.com>,
Alexandre Ghiti <alexghiti@rivosinc.com>,
Guo Ren <guoren@kernel.org>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v1 0/7] perf bench: Add qspinlock benchmark
Date: Wed, 30 Jul 2025 21:51:49 -0700 [thread overview]
Message-ID: <aIr2ZdxmuBoCmDhw@google.com> (raw)
In-Reply-To: <20250729022640.3134066-1-yuzhuo@google.com>
Hello,
On Mon, Jul 28, 2025 at 07:26:33PM -0700, Yuzhuo Jing wrote:
> As an effort to improve the perf bench subcommand, this patch series
> adds benchmark for the kernel's queued spinlock implementation.
>
> This series imports necessary kernel definitions such as atomics,
> introduces userspace per-cpu adapter, and imports the qspinlock
> implementation from the kernel tree to tools tree, with minimum
> adaptions.
But I'm curious how you handled difference in kernel vs. user space.
For example, normally kernel spinlocks imply no preemption but we cannot
guarantee that in userspace.
>
> This subcommand enables convenient commands to investigate the
> performance of kernel lock implementations, such as using sampling:
>
> perf record -- ./perf bench sync qspinlock -t5
> perf report
It'd be nice if you can share an example output of the change.
Thanks,
Namhyung
>
> Yuzhuo Jing (7):
> tools: Import cmpxchg and xchg functions
> tools: Import smp_cond_load and atomic_cond_read
> tools: Partial import of prefetch.h
> tools: Implement userspace per-cpu
> perf bench: Import qspinlock from kernel
> perf bench: Add 'bench sync qspinlock' subcommand
> perf bench sync: Add latency histogram functionality
>
> tools/arch/x86/include/asm/atomic.h | 14 +
> tools/arch/x86/include/asm/cmpxchg.h | 113 +++++
> tools/include/asm-generic/atomic-gcc.h | 47 ++
> tools/include/asm/barrier.h | 58 +++
> tools/include/linux/atomic.h | 27 ++
> tools/include/linux/compiler_types.h | 30 ++
> tools/include/linux/percpu-simulate.h | 128 ++++++
> tools/include/linux/prefetch.h | 41 ++
> tools/perf/bench/Build | 2 +
> tools/perf/bench/bench.h | 1 +
> .../perf/bench/include/mcs_spinlock-private.h | 115 +++++
> tools/perf/bench/include/mcs_spinlock.h | 19 +
> tools/perf/bench/include/qspinlock-private.h | 204 +++++++++
> tools/perf/bench/include/qspinlock.h | 153 +++++++
> tools/perf/bench/include/qspinlock_types.h | 98 +++++
> tools/perf/bench/qspinlock.c | 411 ++++++++++++++++++
> tools/perf/bench/sync.c | 329 ++++++++++++++
> tools/perf/builtin-bench.c | 7 +
> tools/perf/check-headers.sh | 32 ++
> 19 files changed, 1829 insertions(+)
> create mode 100644 tools/include/linux/percpu-simulate.h
> create mode 100644 tools/include/linux/prefetch.h
> create mode 100644 tools/perf/bench/include/mcs_spinlock-private.h
> create mode 100644 tools/perf/bench/include/mcs_spinlock.h
> create mode 100644 tools/perf/bench/include/qspinlock-private.h
> create mode 100644 tools/perf/bench/include/qspinlock.h
> create mode 100644 tools/perf/bench/include/qspinlock_types.h
> create mode 100644 tools/perf/bench/qspinlock.c
> create mode 100644 tools/perf/bench/sync.c
>
> --
> 2.50.1.487.gc89ff58d15-goog
>
next prev parent reply other threads:[~2025-07-31 4:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 2:26 [PATCH v1 0/7] perf bench: Add qspinlock benchmark Yuzhuo Jing
2025-07-29 2:26 ` [PATCH v1 1/7] tools: Import cmpxchg and xchg functions Yuzhuo Jing
2025-07-31 4:52 ` Namhyung Kim
2025-08-08 6:11 ` kernel test robot
2025-07-29 2:26 ` [PATCH v1 2/7] tools: Import smp_cond_load and atomic_cond_read Yuzhuo Jing
2025-07-29 2:26 ` [PATCH v1 3/7] tools: Partial import of prefetch.h Yuzhuo Jing
2025-07-31 4:54 ` Namhyung Kim
2025-07-29 2:26 ` [PATCH v1 4/7] tools: Implement userspace per-cpu Yuzhuo Jing
2025-07-31 5:07 ` Namhyung Kim
2025-07-29 2:26 ` [PATCH v1 5/7] perf bench: Import qspinlock from kernel Yuzhuo Jing
2025-07-29 2:26 ` [PATCH v1 6/7] perf bench: Add 'bench sync qspinlock' subcommand Yuzhuo Jing
2025-07-31 5:16 ` Namhyung Kim
2025-07-31 13:19 ` Yuzhuo Jing
2025-07-29 2:26 ` [PATCH v1 7/7] perf bench sync: Add latency histogram functionality Yuzhuo Jing
2025-07-31 5:18 ` Namhyung Kim
2025-07-31 5:24 ` Namhyung Kim
2025-07-31 4:51 ` Namhyung Kim [this message]
2025-08-04 14:28 ` [PATCH v1 0/7] perf bench: Add qspinlock benchmark Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIr2ZdxmuBoCmDhw@google.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexghiti@rivosinc.com \
--cc=ast@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=brho@google.com \
--cc=charlie@rivosinc.com \
--cc=guoren@kernel.org \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=memxor@gmail.com \
--cc=mingo@redhat.com \
--cc=palmer@rivosinc.com \
--cc=parri.andrea@gmail.com \
--cc=peterz@infradead.org \
--cc=yuzhuo@google.com \
--cc=yzj@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).