From: Paul Chaignon <paul.chaignon@gmail.com>
To: Jiri Olsa <jolsa@kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
syzbot+a9ed3d9132939852d0df@syzkaller.appspotmail.com,
bpf@vger.kernel.org, linux-perf-users@vger.kernel.org,
Martin KaFai Lau <kafai@fb.com>,
Eduard Zingerman <eddyz87@gmail.com>,
Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
Hao Luo <haoluo@google.com>
Subject: Re: [PATCHv2 bpf] bpf: Check the helper function is valid in get_helper_proto
Date: Thu, 14 Aug 2025 15:53:14 +0200 [thread overview]
Message-ID: <aJ3qSru3r1is9lxy@mail.gmail.com> (raw)
In-Reply-To: <20250813133832.755428-1-jolsa@kernel.org>
On Wed, Aug 13, 2025 at 03:38:32PM +0200, Jiri Olsa wrote:
> From: Jiri Olsa <olsajiri@gmail.com>
>
> syzbot reported an verifier bug [1] where the helper func pointer
> could be NULL due to disabled config option.
>
> As Alexei suggested we could check on that in get_helper_proto
> directly. Excluding tail_call helper from the check, because it
> is NULL by design and valid in all configs.
>
> [1] https://lore.kernel.org/bpf/68904050.050a0220.7f033.0001.GAE@google.com/
> Reported-by: syzbot+a9ed3d9132939852d0df@syzkaller.appspotmail.com
The same bug was reported before by the kernel test robot at
https://lore.kernel.org/oe-lkp/202507160818.68358831-lkp@intel.com, so
I guess we'll need:
Reported-by: kernel test robot <oliver.sang@intel.com>
Closes: https://lore.kernel.org/oe-lkp/202507160818.68358831-lkp@intel.com
With that,
Acked-by: Paul Chaignon <paul.chaignon@gmail.com>
[...]
next prev parent reply other threads:[~2025-08-14 13:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 13:38 [PATCHv2 bpf] bpf: Check the helper function is valid in get_helper_proto Jiri Olsa
2025-08-13 22:44 ` Andrii Nakryiko
2025-08-14 7:29 ` Jiri Olsa
2025-08-14 13:53 ` Paul Chaignon [this message]
2025-08-14 14:18 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJ3qSru3r1is9lxy@mail.gmail.com \
--to=paul.chaignon@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kafai@fb.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=syzbot+a9ed3d9132939852d0df@syzkaller.appspotmail.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox