From: Ryan Chung <seokwoo.chung130@gmail.com>
To: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
namhyung@kernel.org
Cc: mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
kan.liang@linux.intel.com, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] event/core.c: fix warning format specifier to use %llu instead of %lld for u64 values.
Date: Fri, 15 Aug 2025 00:40:00 +0900 [thread overview]
Message-ID: <aJ4DUJD8SXdB3gjn@gmail.com> (raw)
In-Reply-To: <20250729070620.527482-1-seokwoo.chung130@gmail.com>
Hi all,
Just wondering if there’s any feedback on this patch.
Thanks,
Ryan Chung
On Tue, Jul 29, 2025 at 04:06:03PM +0900, Ryan Chung wrote:
> Updates the perf duration warning to use the unsigned 64‑bit format specifier `%llu` instead of `%lld`, ensuring the format matches the `u64` types.
>
> No functional change intended.
>
> Signed-off-by: Ryan Chung <seokwoo.chung130@gmail.com>
> ---
> kernel/events/core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 22fdf0c187cd..b8d7c4a64c44 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -602,7 +602,7 @@ static u64 __report_allowed;
> static void perf_duration_warn(struct irq_work *w)
> {
> printk_ratelimited(KERN_INFO
> - "perf: interrupt took too long (%lld > %lld), lowering "
> + "perf: interrupt took too long (%llu > %llu), lowering "
> "kernel.perf_event_max_sample_rate to %d\n",
> __report_avg, __report_allowed,
> sysctl_perf_event_sample_rate);
> @@ -655,7 +655,7 @@ void perf_sample_event_took(u64 sample_len_ns)
> perf_sample_period_ns = NSEC_PER_SEC / sysctl_perf_event_sample_rate;
>
> if (!irq_work_queue(&perf_duration_work)) {
> - early_printk("perf: interrupt took too long (%lld > %lld), lowering "
> + early_printk("perf: interrupt took too long (%llu > %llu), lowering "
> "kernel.perf_event_max_sample_rate to %d\n",
> __report_avg, __report_allowed,
> sysctl_perf_event_sample_rate);
> --
> 2.43.0
>
prev parent reply other threads:[~2025-08-14 15:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 7:06 [PATCH] event/core.c: fix warning format specifier to use %llu instead of %lld for u64 values Ryan Chung
2025-08-14 15:40 ` Ryan Chung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJ4DUJD8SXdB3gjn@gmail.com \
--to=seokwoo.chung130@gmail.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).