From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C201F155A30; Wed, 20 Aug 2025 23:47:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755733644; cv=none; b=nujH/ei9sweoOsRo9CT7sRoRf6VXQBcJrkS6hAbpH1oonuSWq6EpkO/EE+1YAOfOCVVUUzPxVxZQAo2dzDH7vIGcPlk41/knwRHuBTsoQItLE+FiWPfHy6bGAUM5+1gbX2HlJp4Or6L87ip83iJSfeqfyCsrIv7VTSaeYXZvbV4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755733644; c=relaxed/simple; bh=N/XuieC4GDQ/uRzkiAvRb09ScbLTX6DyDyU2IJAnWO8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gpO/+oDmuTiCzgxmptmClLC+wGSua/bA7J7q1SxsrLrn0ssKCf3XjsQh8Xf36ajdWlDeqvnlsNCvZUTacp0EPOsrjE7EGOrodadHvTaGl4l6ZgbYnfIjG62osXw6goPWstxdQ6B765AKxgTRuBwYc9haMJwJFpsajMFIHu4VBW8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ek057XVt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ek057XVt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E46E2C4CEE7; Wed, 20 Aug 2025 23:47:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755733644; bh=N/XuieC4GDQ/uRzkiAvRb09ScbLTX6DyDyU2IJAnWO8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ek057XVtr3l+yiX6Qd6rJdrRBK3KtkbBgMi4M7mlBjgZYCpPfvZLBDqIGC0tt5pfb knhSH5dU0K2FVShcXCzGVNYfaAnInWXPQf5f3GKv4fGf1EaiNuvdjYK+PelFn/aW3C j32gXTP7NLTPB0fI6DVljjvXxcKgMFDVbxLdQqUS4zlDlR7XHeryBuitFey9FCl8eG BMgkR8KzJeTnOOGuADcVMix0nSynbzbY19yzvOz1wm2YKeF15dIfrEpjBGXeCC0Nld Ehx+bai/7rvGTP6tLdsXG7RJ2alz+G4iJUUBHe3pkbGgqkB1sm68MKK+s8TKi5Cmde QP8Tyin9F1HyQ== Date: Wed, 20 Aug 2025 16:47:20 -0700 From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ian Rogers , Kan Liang , Jiri Olsa , Adrian Hunter , Peter Zijlstra , Ingo Molnar , LKML , linux-perf-users@vger.kernel.org Subject: Re: [PATCHSET v5 00/12] perf annotate: Support --code-with-type on TUI Message-ID: References: <20250816031635.25318-1-namhyung@kernel.org> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Wed, Aug 20, 2025 at 06:43:03PM -0300, Arnaldo Carvalho de Melo wrote: > On Wed, Aug 20, 2025 at 06:40:53PM -0300, Arnaldo Carvalho de Melo wrote: > > On Fri, Aug 15, 2025 at 08:16:23PM -0700, Namhyung Kim wrote: > > > > > > Hello, > > > > > > The --code-with-type option is to show normal annotate output with type > > > information. It was supported only on --stdio, but this change adds it > > > to TUI as well. > > > > > > Arnaldo, please tell me if you still don't like the > > > __hist_entry__tui_annotate() but I don't have a better idea for now. > > > > Not a problem, I tested everything, all seems to work as advertised. > > > > The minor suggestions I made I can do while merging, if you don't mind > > and agree with them. > > I mean the scope of a variable, a missing line before an if line, not > the other more involved one as the alignment of the type comments, etc. > :-) I've left comments in each thread. > > - Arnaldo > > > Please let me know. > > > > Tested-by: Arnaldo Carvalho de Melo Thanks for your review and tests! Namhyung > > > > - Arnaldo > > > > > v5 changes) > > > * use a copy of hist entry for perf top (Ian) > > > * split disasm_line__write() change (Ian) > > > * constify annotation_write_ops parameter (Ian) > > > * update printed length calculation (Ian) > > > * remove annotation_print_data.start > > > * add a hashmap to skip duplicate processing > > > > > > v4 changes) > > > * add dso__debuginfo() helper (Ian) > > > > > > v3 changes) > > > * hide stack operation and stack canary by default > > > > > > v2 changes) > > > * use 'T' key to toggle data type display (Arnaldo) > > > * display '[Type]' in the title line when it's enabled (Arnaldo) > > > * show warning when debug info is not available (Arnaldo) > > > * fix a typo (Arnaldo) > > > > > > Actually the command line option sets the default behavior and users can > > > change it by pressing 'T' key in the TUI annotate browser. > > > > > > The code is also available at 'perf/annotate-code-type-tui-v5' branch at > > > https://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git > > > > > > Thanks, > > > Namhyung > > > > > > > > > Namhyung Kim (12): > > > perf annotate: Rename to __hist_entry__tui_annotate() > > > perf annotate: Remove annotation_print_data.start > > > perf annotate: Remove __annotation_line__write() > > > perf annotate: Pass annotation_print_data to annotation_line__write() > > > perf annotate: Simplify width calculation in annotation_line__write() > > > perf annotate: Return printed number from disasm_line__write() > > > perf annotate: Add --code-with-type support for TUI > > > perf annotate: Add 'T' hot key to toggle data type display > > > perf annotate: Show warning when debuginfo is not available > > > perf annotate: Hide data-type for stack operation and canary > > > perf annotate: Add dso__debuginfo() helper > > > perf annotate: Use a hashmap to save type data > > > > > > tools/perf/Documentation/perf-annotate.txt | 1 - > > > tools/perf/builtin-annotate.c | 5 - > > > tools/perf/ui/browsers/annotate.c | 117 ++++++++++++-- > > > tools/perf/ui/browsers/hists.c | 2 +- > > > tools/perf/util/annotate.c | 178 +++++++++++++++------ > > > tools/perf/util/annotate.h | 29 ++-- > > > tools/perf/util/dso.h | 21 +++ > > > tools/perf/util/hist.h | 12 +- > > > 8 files changed, 273 insertions(+), 92 deletions(-) > > > > > > -- > > > 2.50.1