From: Namhyung Kim <namhyung@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
James Clark <james.clark@linaro.org>,
Collin Funk <collin.funk1@gmail.com>,
"Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
Stephen Brennan <stephen.s.brennan@oracle.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Haibo Xu <haibo1.xu@intel.com>,
Dmitry Vyukov <dvyukov@google.com>, Song Liu <song@kernel.org>,
Thomas Falcon <thomas.falcon@intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/2] Build ID mmap related fixes
Date: Mon, 25 Aug 2025 15:06:58 -0700 [thread overview]
Message-ID: <aKzeglUaXc1rFr4k@google.com> (raw)
In-Reply-To: <20250823000024.724394-1-irogers@google.com>
Hi Ian,
On Fri, Aug 22, 2025 at 05:00:22PM -0700, Ian Rogers wrote:
> Now that build ID mmap is the default I was seeing hangs during event
> synthesis in the perftool-testsuite_report. The hang was happening due
> to data pages giving block device file paths and opening the file to
> read a build ID was blocking in the open. In investigating this issue
> a bug in symbol-minimal was found. These 2 patches fix both issues. As
> the issues are present in v6.17-rc2, I think it would be worthwhile to
> add the patches as v6.17 fixes.
Looks good to me. I'll add them for v6.17.
Thanks,
Namhyung
>
> Ian Rogers (2):
> perf symbol-minimal: Fix ehdr reading in filename__read_build_id
> perf symbol: Add blocking argument to filename__read_build_id
>
> tools/perf/bench/inject-buildid.c | 2 +-
> tools/perf/builtin-buildid-cache.c | 8 ++--
> tools/perf/builtin-inject.c | 4 +-
> tools/perf/tests/sdt.c | 2 +-
> tools/perf/util/build-id.c | 4 +-
> tools/perf/util/debuginfo.c | 8 +++-
> tools/perf/util/dsos.c | 4 +-
> tools/perf/util/symbol-elf.c | 9 +++--
> tools/perf/util/symbol-minimal.c | 59 +++++++++++++++---------------
> tools/perf/util/symbol.c | 8 ++--
> tools/perf/util/symbol.h | 2 +-
> tools/perf/util/synthetic-events.c | 2 +-
> 12 files changed, 58 insertions(+), 54 deletions(-)
>
> --
> 2.51.0.rc2.233.g662b1ed5c5-goog
>
prev parent reply other threads:[~2025-08-25 22:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-23 0:00 [PATCH v1 0/2] Build ID mmap related fixes Ian Rogers
2025-08-23 0:00 ` [PATCH v1 1/2] perf symbol-minimal: Fix ehdr reading in filename__read_build_id Ian Rogers
2025-08-23 0:00 ` [PATCH v1 2/2] perf symbol: Add blocking argument to filename__read_build_id Ian Rogers
2025-08-25 22:06 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKzeglUaXc1rFr4k@google.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=collin.funk1@gmail.com \
--cc=dvyukov@google.com \
--cc=haibo1.xu@intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=palmer@dabbelt.com \
--cc=peterz@infradead.org \
--cc=song@kernel.org \
--cc=stephen.s.brennan@oracle.com \
--cc=thomas.falcon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).