From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
James Clark <james.clark@linaro.org>,
Chun-Tse Shao <ctshao@google.com>,
Thomas Falcon <thomas.falcon@intel.com>,
Yang Li <yang.lee@linux.alibaba.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/4] Test fixes and debug logging
Date: Fri, 19 Sep 2025 17:45:47 -0300 [thread overview]
Message-ID: <aM3A-2kYse8nMP9K@x1> (raw)
In-Reply-To: <20250914182900.1960567-1-irogers@google.com>
On Sun, Sep 14, 2025 at 11:28:56AM -0700, Ian Rogers wrote:
> Testing in a hypervisor guest showed some issues that these patches
> try to address, or improve the debug situation upon.
>
> Ian Rogers (4):
> perf test: Be tolerant of missing json metric none value
> perf parse-events: Add debug logging to perf_event
> perf test: Don't fail if user rdpmc returns 0 when disabled
> perf stat-shadow: Display metric-only for 0 counters
Applied, but while checking before/after on a host, I see that these are
quite unstable:
root@x1:~# perf test -r10 linter
94: perf stat CSV output linter : FAILED!
94: perf stat CSV output linter : FAILED!
94: perf stat CSV output linter : FAILED!
94: perf stat CSV output linter : FAILED!
94: perf stat CSV output linter : FAILED!
94: perf stat CSV output linter : FAILED!
94: perf stat CSV output linter : FAILED!
94: perf stat CSV output linter : FAILED!
94: perf stat CSV output linter : FAILED!
94: perf stat CSV output linter : FAILED!
97: perf stat JSON output linter : Ok
97: perf stat JSON output linter : Ok
97: perf stat JSON output linter : Ok
97: perf stat JSON output linter : Ok
97: perf stat JSON output linter : Ok
97: perf stat JSON output linter : Ok
97: perf stat JSON output linter : Ok
97: perf stat JSON output linter : Ok
97: perf stat JSON output linter : Ok
97: perf stat JSON output linter : Ok
99: perf stat STD output linter : Ok
99: perf stat STD output linter : Ok
99: perf stat STD output linter : Ok
99: perf stat STD output linter : FAILED!
99: perf stat STD output linter : FAILED!
99: perf stat STD output linter : Ok
99: perf stat STD output linter : FAILED!
99: perf stat STD output linter : Ok
99: perf stat STD output linter : Ok
99: perf stat STD output linter : FAILED!
root@x1:~#
root@x1:~# for a in $(seq 20) ; do perf test linter ; echo "------" ; done
94: perf stat CSV output linter : FAILED!
97: perf stat JSON output linter : Ok
99: perf stat STD output linter : Ok
------
94: perf stat CSV output linter : FAILED!
97: perf stat JSON output linter : Ok
99: perf stat STD output linter : Ok
------
94: perf stat CSV output linter : FAILED!
97: perf stat JSON output linter : Ok
99: perf stat STD output linter : FAILED!
------
94: perf stat CSV output linter : FAILED!
97: perf stat JSON output linter : Ok
99: perf stat STD output linter : Ok
------
94: perf stat CSV output linter : FAILED!
97: perf stat JSON output linter : Ok
99: perf stat STD output linter : Ok
------
94: perf stat CSV output linter : FAILED!
97: perf stat JSON output linter : Ok
99: perf stat STD output linter : Ok
------
94: perf stat CSV output linter : FAILED!
97: perf stat JSON output linter : Ok
99: perf stat STD output linter : Ok
------
94: perf stat CSV output linter : FAILED!
97: perf stat JSON output linter : Ok
99: perf stat STD output linter : Ok
------
94: perf stat CSV output linter : FAILED!
97: perf stat JSON output linter : Ok
99: perf stat STD output linter : Ok
------
94: perf stat CSV output linter : FAILED!
97: perf stat JSON output linter : Ok
99: perf stat STD output linter : Ok
------
94: perf stat CSV output linter : FAILED!
97: perf stat JSON output linter : Ok
99: perf stat STD output linter : Ok
------
94: perf stat CSV output linter : FAILED!
97: perf stat JSON output linter : Ok
99: perf stat STD output linter : Ok
------
94: perf stat CSV output linter : FAILED!
97: perf stat JSON output linter : Ok
99: perf stat STD output linter : Ok
------
94: perf stat CSV output linter : FAILED!
97: perf stat JSON output linter : Ok
99: perf stat STD output linter : Ok
------
94: perf stat CSV output linter : FAILED!
97: perf stat JSON output linter : Ok
99: perf stat STD output linter : Ok
------
94: perf stat CSV output linter : FAILED!
97: perf stat JSON output linter : Ok
99: perf stat STD output linter : Ok
------
94: perf stat CSV output linter : FAILED!
97: perf stat JSON output linter : Ok
99: perf stat STD output linter : FAILED!
------
94: perf stat CSV output linter : FAILED!
97: perf stat JSON output linter : Ok
99: perf stat STD output linter : Ok
------
94: perf stat CSV output linter : FAILED!
97: perf stat JSON output linter : Ok
99: perf stat STD output linter : Ok
------
94: perf stat CSV output linter : FAILED!
97: perf stat JSON output linter : Ok
99: perf stat STD output linter : Ok
------
root@x1:~#
root@x1:~# uname -a
Linux x1 6.16.5-200.fc42.x86_64 #1 SMP PREEMPT_DYNAMIC Thu Sep 4 16:37:21 UTC 2025 x86_64 GNU/Linux
root@x1:~# grep -m1 "model name" /proc/cpuinfo
model name : 13th Gen Intel(R) Core(TM) i7-1365U
root@x1:~#
All is well on AMD land:
root@number:~# perf test linter
94: perf stat CSV output linter : Ok
97: perf stat JSON output linter : Ok
99: perf stat STD output linter : Ok
root@number:~# perf test -r 5 linter
94: perf stat CSV output linter : Ok
94: perf stat CSV output linter : Ok
94: perf stat CSV output linter : Ok
94: perf stat CSV output linter : Ok
94: perf stat CSV output linter : Ok
97: perf stat JSON output linter : Ok
97: perf stat JSON output linter : Ok
97: perf stat JSON output linter : Ok
97: perf stat JSON output linter : Ok
97: perf stat JSON output linter : Ok
99: perf stat STD output linter : Ok
99: perf stat STD output linter : Ok
99: perf stat STD output linter : Ok
99: perf stat STD output linter : Ok
99: perf stat STD output linter : Ok
root@number:~# uname -a
Linux number 6.16.7-200.fc42.x86_64 #1 SMP PREEMPT_DYNAMIC Thu Sep 11 17:46:54 UTC 2025 x86_64 GNU/Linux
root@number:~# grep -m1 "model name" /proc/cpuinfo
model name : AMD Ryzen 9 9950X3D 16-Core Processor
root@number:~#
acme@number:~/git/perf-tools-next$ git log --oneline -5
58c26aeac5132152 (HEAD -> perf-tools-next, perf-tools-next/tmp.perf-tools-next) perf stat-shadow: Display metric-only for 0 counters
f46533cc149e39bd perf test: Don't fail if user rdpmc returns 0 when disabled
9bb146fd8a342ae1 perf parse-events: Add debug logging to perf_event
64b3eae288bb4370 perf test: Be tolerant of missing json metric none value
0dc96cae063cbf9e perf build-id: Ensure snprintf string is empty when size is 0
acme@number:~/git/perf-tools-next$ sudo su -
root@number:~# perf -v
perf version 6.17.rc6.g58c26aeac513
root@number:~#
- Arnaldo
next prev parent reply other threads:[~2025-09-19 20:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-14 18:28 [PATCH v1 0/4] Test fixes and debug logging Ian Rogers
2025-09-14 18:28 ` [PATCH v1 1/4] perf test: Be tolerant of missing json metric none value Ian Rogers
2025-09-14 18:28 ` [PATCH v1 2/4] perf parse-events: Add debug logging to perf_event Ian Rogers
2025-09-14 18:28 ` [PATCH v1 3/4] perf test: Don't fail if user rdpmc returns 0 when disabled Ian Rogers
2025-09-14 18:29 ` [PATCH v1 4/4] perf stat-shadow: Display metric-only for 0 counters Ian Rogers
2025-09-19 20:45 ` Arnaldo Carvalho de Melo [this message]
2025-09-19 20:46 ` [PATCH v1 0/4] Test fixes and debug logging Arnaldo Carvalho de Melo
2025-09-20 15:21 ` Ian Rogers
2025-09-24 9:57 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aM3A-2kYse8nMP9K@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ctshao@google.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=thomas.falcon@intel.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox