From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
Ravi Bangoria <ravi.bangoria@amd.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Collin Funk <collin.funk1@gmail.com>,
James Clark <james.clark@linaro.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] perf test: AMD IBS swfilt skip kernel tests if paranoia is >1
Date: Tue, 16 Sep 2025 11:30:06 -0300 [thread overview]
Message-ID: <aMl0brRnnyW_ofs4@x1> (raw)
In-Reply-To: <CAP-5=fWQUE4YxbAK4-qV44WFXYjo_EPy1XcVSrOYVP=rTspKnQ@mail.gmail.com>
On Fri, Sep 12, 2025 at 04:37:59PM -0700, Ian Rogers wrote:
> On Fri, Sep 12, 2025 at 2:53 PM Arnaldo Carvalho de Melo
> <acme@kernel.org> wrote:
> >
> > On Mon, Sep 08, 2025 at 04:35:11PM -0700, Namhyung Kim wrote:
> > > Hi Ian,
> > >
> > > On Mon, Sep 08, 2025 at 03:17:27PM -0700, Ian Rogers wrote:
> > > > If not root and the perf_event_paranoid is set >1 swfilt will fail to
> > > > open the event failing the test. Add check to skip the test in that
> > > > case.
> > >
> > > Thanks for the fix!
> >
> > I'm taking this as an Acked-by, ok?
>
> I have a new version but I'm discovering quite a few other issues on
> the way. There are 7 patches on top of this here:
> https://github.com/googleprodkernel/linux-perf/commits/google_tools_master/
I just checked and b4 picked the latest version of this patch as what I
have now in perf-tools-next is the same as in:
https://github.com/googleprodkernel/linux-perf/blob/google_tools_master/tools/perf/tests/shell/amd-ibs-swfilt.sh
- Arnaldo
> I'll send the new version now, but I'd been tardy as it wasn't clear I
> was done with fixes yet.
>
> Thanks,
> Ian
prev parent reply other threads:[~2025-09-16 14:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 22:17 [PATCH v1] perf test: AMD IBS swfilt skip kernel tests if paranoia is >1 Ian Rogers
2025-09-08 23:35 ` Namhyung Kim
2025-09-12 21:53 ` Arnaldo Carvalho de Melo
2025-09-12 23:37 ` Ian Rogers
2025-09-16 14:30 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMl0brRnnyW_ofs4@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=collin.funk1@gmail.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).