From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Trevor Allison <tallison@redhat.com>,
Thomas Falcon <thomas.falcon@intel.com>,
linux-perf-users@vger.kernel.org, peterz@infradead.org,
mingo@redhat.com, namhyung@kernel.org, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
adrian.hunter@intel.com, kan.liang@linux.intel.com
Subject: Re: [PATCH] perf test attr: Add missing int_mist.uop_dropping event to test-stat files
Date: Wed, 17 Sep 2025 09:49:05 -0300 [thread overview]
Message-ID: <aMquQS_5PuC2el1f@x1> (raw)
In-Reply-To: <CAP-5=fXdxNLA4Ey51HdMCrY0SZuzp1WUc5A+n9EFLtaajtYEiA@mail.gmail.com>
On Tue, Sep 16, 2025 at 01:23:54PM -0700, Ian Rogers wrote:
> On Tue, Sep 16, 2025 at 12:31 PM Trevor Allison <tallison@redhat.com> wrote:
> >
> > Setup struct perf-event-attr test was failing on EMR cpu because perf stat
> > was providing an event that was not included in the test. Type 4 Config 4269
> > or 10ad, int_misc.uop_dropping.
> >
> > Add event type=4 config=4269 to test-stat-default and test-stat-detailed-*
> > files with optional=1 so EMR machines can pass test
> >
> > Signed-off-by: Trevor Allison <tallison@redhat.com>
>
> Thanks! I wonder why this wasn't seen on SapphireRapids.
>
> Reviewed-by: Ian Rogers <irogers@google.com>
> Fixes: 50e2eb259650 perf vendor events: Update emeraldrapids events/metrics
You mean:
commit d9a6bb9e359e6f816c746fc8d6aa0999f4594a0c
Author: Ian Rogers <irogers@google.com>
Date: Mon Aug 18 12:04:02 2025 -0700
perf vendor events: Update emeraldrapids events/metrics
Update events from v1.14 to v1.16. Update metrics from TMA 5.0 to 5.1.
The event updates come from:
https://github.com/intel/perfmon/commit/9020e49e790349f86141a1f6ef6f009f189a0f48
https://github.com/intel/perfmon/commit/a0567b56185fea4b968391aae344e9d8ed9782d8
?
As I didn't find 50e2eb259650 in upstream or perf-tools-next.
⬢ [acme@toolbx perf-tools-next]$ git log --oneline tools/perf/pmu-events/arch/x86/emeraldrapids/
d9a6bb9e359e6f81 perf vendor events: Update emeraldrapids events/metrics
31c8714cf5b91da6 perf vendor events: Update EmeraldRapids events
4ecf9eab4a04c75d perf vendor events: Update emeraldrapids events/metrics
5ee60fbf7375abeb perf vendor events: Update EmeraldRapids events/metrics
40ccd6aa3e2e05be perf vendor events: Add/update emeraldrapids events/metrics
36f353a1ebf88280 perf vendor events intel: Update emeraldrapids to 1.06
ea518afc992032f7 perf vendor events intel: Update emeraldrapids events to v1.03
576d7fed09c7edba perf vendor events intel: Update emeraldrapids events to v1.02
8a94d3bfaf45e799 perf vendor events intel: Update emeraldrapids to v1.01
8c994eff8fcfe8ec perf vendor events intel: Add emeraldrapids, update sapphirerapids to v1.16
⬢ [acme@toolbx perf-tools-next]$
- Arnaldo
> Ian
>
> > ---
> > tools/perf/tests/shell/attr/test-stat-default | 7 +++++++
> > tools/perf/tests/shell/attr/test-stat-detailed-1 | 7 +++++++
> > tools/perf/tests/shell/attr/test-stat-detailed-2 | 7 +++++++
> > tools/perf/tests/shell/attr/test-stat-detailed-3 | 7 +++++++
> > 4 files changed, 28 insertions(+)
> >
> > diff --git a/tools/perf/tests/shell/attr/test-stat-default b/tools/perf/tests/shell/attr/test-stat-default
> > index e47fb4944679..8dd27c1fb661 100644
> > --- a/tools/perf/tests/shell/attr/test-stat-default
> > +++ b/tools/perf/tests/shell/attr/test-stat-default
> > @@ -227,3 +227,10 @@ fd=28
> > type=4
> > config=270
> > optional=1
> > +
> > +# PERF_TYPE_RAW / INT_MISC.UOP_DROPPING
> > +[event29:base-stat]
> > +fd=29
> > +type=4
> > +config=4269
> > +optional=1
> > \ No newline at end of file
> > diff --git a/tools/perf/tests/shell/attr/test-stat-detailed-1 b/tools/perf/tests/shell/attr/test-stat-detailed-1
> > index 3d500d3e0c5c..12a2ebf4e64a 100644
> > --- a/tools/perf/tests/shell/attr/test-stat-detailed-1
> > +++ b/tools/perf/tests/shell/attr/test-stat-detailed-1
> > @@ -269,3 +269,10 @@ fd=32
> > type=3
> > config=65538
> > optional=1
> > +
> > +# PERF_TYPE_RAW / INT_MISC.UOP_DROPPING
> > +[event33:base-stat]
> > +fd=33
> > +type=4
> > +config=4269
> > +optional=1
> > \ No newline at end of file
> > diff --git a/tools/perf/tests/shell/attr/test-stat-detailed-2 b/tools/perf/tests/shell/attr/test-stat-detailed-2
> > index 01777a63752f..66ea25b7d38f 100644
> > --- a/tools/perf/tests/shell/attr/test-stat-detailed-2
> > +++ b/tools/perf/tests/shell/attr/test-stat-detailed-2
> > @@ -329,3 +329,10 @@ fd=38
> > type=3
> > config=65540
> > optional=1
> > +
> > +# PERF_TYPE_RAW / INT_MISC.UOP_DROPPING
> > +[event39:base-stat]
> > +fd=39
> > +type=4
> > +config=4269
> > +optional=1
> > \ No newline at end of file
> > diff --git a/tools/perf/tests/shell/attr/test-stat-detailed-3 b/tools/perf/tests/shell/attr/test-stat-detailed-3
> > index 8400abd7e1e4..4a27bbfb9f87 100644
> > --- a/tools/perf/tests/shell/attr/test-stat-detailed-3
> > +++ b/tools/perf/tests/shell/attr/test-stat-detailed-3
> > @@ -349,3 +349,10 @@ fd=40
> > type=3
> > config=66048
> > optional=1
> > +
> > +# PERF_TYPE_RAW / INT_MISC.UOP_DROPPING
> > +[event41:base-stat]
> > +fd=41
> > +type=4
> > +config=4269
> > +optional=1
> > \ No newline at end of file
> > --
> > 2.39.5 (Apple Git-154)
> >
prev parent reply other threads:[~2025-09-17 12:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 19:30 [PATCH] perf test attr: Add missing int_mist.uop_dropping event to test-stat files Trevor Allison
2025-09-16 20:23 ` Ian Rogers
2025-09-17 12:49 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMquQS_5PuC2el1f@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tallison@redhat.com \
--cc=thomas.falcon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).