linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RFC/PATCH 1/2] perf check: Add 'system' subcommand
@ 2025-09-18  6:39 Namhyung Kim
  2025-09-18  6:39 ` [RFC/PATCH 2/2] perf check: Add 'pmu' subcommand Namhyung Kim
  2025-09-18 15:48 ` [RFC/PATCH 1/2] perf check: Add 'system' subcommand Ian Rogers
  0 siblings, 2 replies; 8+ messages in thread
From: Namhyung Kim @ 2025-09-18  6:39 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo, Ian Rogers, Kan Liang
  Cc: Jiri Olsa, Adrian Hunter, Peter Zijlstra, Ingo Molnar, LKML,
	linux-perf-users

The 'perf check system' is to check sysctl settings related to perf.
By default it'd print the following output.

  $ perf check system
  perf_event_paranoid  = 2	# non-root can profile user code only
  perf_event_max_stack = 127	# maximum callchain length
  perf_event_mlock_kb  = 516	# maximum ring buffer size (including a header page) for non-root
  nmi_watchdog         = 1	# a hardware PMU counter may be used by the kernel
  kptr_restrict        = 0	# kernel pointers are printed as-is

The -q option suppresses the description.  It can also take command line
argument to match specific items.

  $ perf check system -q nmi
  nmi_watchdog         = 1

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/Documentation/perf-check.txt |  20 ++++
 tools/perf/builtin-check.c              | 116 +++++++++++++++++++++++-
 2 files changed, 135 insertions(+), 1 deletion(-)

diff --git a/tools/perf/Documentation/perf-check.txt b/tools/perf/Documentation/perf-check.txt
index ee92042082f73121..34dccc29d90d2fdf 100644
--- a/tools/perf/Documentation/perf-check.txt
+++ b/tools/perf/Documentation/perf-check.txt
@@ -10,6 +10,7 @@ SYNOPSIS
 [verse]
 'perf check' [<options>]
 'perf check' {feature <feature_list>} [<options>]
+'perf check' {system <setting_list>} [<options>]
 
 DESCRIPTION
 -----------
@@ -22,6 +23,9 @@ compiled-in/built-in or not.
 Also, 'perf check feature' returns with exit status 0 if the feature
 is built-in, otherwise returns with exit status 1.
 
+If the subcommand 'system' is used, then system settins are printed on
+the standard output with explanation.
+
 SUBCOMMANDS
 -----------
 
@@ -69,6 +73,22 @@ SUBCOMMANDS
                 zlib                    /  HAVE_ZLIB_SUPPORT
                 zstd                    /  HAVE_ZSTD_SUPPORT
 
+system::
+
+	Print system settings (sysctl) that affect perf behaviors.
+
+	Example Usage:
+		perf check system
+		perf check system watchdog
+
+	Supported settings:
+		perf_event_paranoid
+		perf_event_max_stack
+		perf_event_mlock_kb
+		nmi_watchdog
+		kptr_restrict
+
+
 OPTIONS
 -------
 -q::
diff --git a/tools/perf/builtin-check.c b/tools/perf/builtin-check.c
index b1e205871ab17a77..1c7c6bb5da5ccbf2 100644
--- a/tools/perf/builtin-check.c
+++ b/tools/perf/builtin-check.c
@@ -3,24 +3,30 @@
 #include "color.h"
 #include "util/debug.h"
 #include "util/header.h"
+#include <api/fs/fs.h>
 #include <tools/config.h>
 #include <stdbool.h>
 #include <stdio.h>
 #include <string.h>
 #include <subcmd/parse-options.h>
 
-static const char * const check_subcommands[] = { "feature", NULL };
+static const char * const check_subcommands[] = { "feature", "system", NULL };
 static struct option check_options[] = {
 	OPT_BOOLEAN('q', "quiet", &quiet, "do not show any warnings or messages"),
 	OPT_END()
 };
 static struct option check_feature_options[] = { OPT_PARENT(check_options) };
+static struct option check_system_options[] = { OPT_PARENT(check_options) };
 
 static const char *check_usage[] = { NULL, NULL };
 static const char *check_feature_usage[] = {
 	"perf check feature <feature_list>",
 	NULL
 };
+static const char *check_system_usage[] = {
+	"perf check system",
+	NULL
+};
 
 #define FEATURE_STATUS(name_, macro_) {    \
 	.name = name_,                     \
@@ -166,6 +172,112 @@ static int subcommand_feature(int argc, const char **argv)
 	return !feature_enabled;
 }
 
+static int read_sysctl_kernel_int(const char *name)
+{
+	char path[128];
+	int value;
+
+	scnprintf(path, sizeof(path), "kernel/%s", name);
+	if (sysctl__read_int(path, &value))
+		return INT_MAX;
+
+	return value;
+}
+
+static const char *system_help_perf_event_paranoid(int value)
+{
+	if (value == 2)
+		return "non-root can profile user code only";
+	if (value == 1)
+		return "non-root can profile kernel and user code";
+	if (value == 0)
+		return "non-root can profile system-wide w/o tracepoints data";
+	if (value < 0)
+		return "no restrictions";
+
+	return "non-root cannot use perf event";
+}
+
+static const char *system_help_perf_event_max_stack(int value __maybe_unused)
+{
+	return "maximum callchain length";
+}
+
+static const char *system_help_perf_event_mlock_kb(int value __maybe_unused)
+{
+	return "maximum ring buffer size (including a header page) for non-root";
+}
+
+static const char *system_help_nmi_watchdog(int value)
+{
+	if (value)
+		return "a hardware PMU counter may be used by the kernel";
+
+	return "perf can use full PMU counters";
+}
+
+static const char *system_help_kptr_restrict(int value)
+{
+	if (value == 0)
+		return "kernel pointers are printed as-is";
+	if (value == 1)
+		return "non-root cannot see the kernel pointers";
+	if (value == 2)
+		return "root may not see some kernel pointers";
+
+	return "unknown value";
+}
+
+/**
+ * Usage: 'perf check system <settings>'
+ *
+ * Show system settings that affect perf behavior.
+ */
+static int subcommand_system(int argc, const char **argv)
+{
+#define PERF_SYSCTL(name) { #name, system_help_##name }
+	struct {
+		const char *name;
+		const char *(*help)(int value);
+	} sysctls[] = {
+		PERF_SYSCTL(perf_event_paranoid),
+		PERF_SYSCTL(perf_event_max_stack),
+		PERF_SYSCTL(perf_event_mlock_kb),
+		PERF_SYSCTL(nmi_watchdog),
+		PERF_SYSCTL(kptr_restrict),
+	};
+#undef PERF_SYSCTL
+
+	argc = parse_options(argc, argv, check_system_options,
+			     check_system_usage, 0);
+
+	for (size_t i = 0; i < ARRAY_SIZE(sysctls); i++) {
+		int value;
+
+		if (argc) {
+			bool found = false;
+
+			/* only show entries match to command line arguments */
+			for (int k = 0; k < argc; k++) {
+				if (strstr(sysctls[i].name, argv[k])) {
+					found = true;
+					break;
+				}
+			}
+			if (!found)
+				continue;
+		}
+
+		value = read_sysctl_kernel_int(sysctls[i].name);
+		printf("%-20s = %d", sysctls[i].name, value);
+		if (!quiet)
+			printf("\t# %s", sysctls[i].help(value));
+		printf("\n");
+	}
+
+	return 0;
+}
+
 int cmd_check(int argc, const char **argv)
 {
 	argc = parse_options_subcommand(argc, argv, check_options,
@@ -176,6 +288,8 @@ int cmd_check(int argc, const char **argv)
 
 	if (strcmp(argv[0], "feature") == 0)
 		return subcommand_feature(argc, argv);
+	if (strcmp(argv[0], "system") == 0)
+		return subcommand_system(argc, argv);
 
 	/* If no subcommand matched above, print usage help */
 	pr_err("Unknown subcommand: %s\n", argv[0]);
-- 
2.51.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2025-09-20 14:05 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-18  6:39 [RFC/PATCH 1/2] perf check: Add 'system' subcommand Namhyung Kim
2025-09-18  6:39 ` [RFC/PATCH 2/2] perf check: Add 'pmu' subcommand Namhyung Kim
2025-09-18 15:33   ` Ian Rogers
2025-09-19 20:27     ` Namhyung Kim
2025-09-20 14:04       ` Ian Rogers
2025-09-18 15:48 ` [RFC/PATCH 1/2] perf check: Add 'system' subcommand Ian Rogers
2025-09-18 20:12   ` Arnaldo Carvalho de Melo
2025-09-19 20:21   ` Namhyung Kim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).