From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Suchit Karunakaran <suchitkarunakaran@gmail.com>,
peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org,
mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@kernel.org, adrian.hunter@intel.com,
kan.liang@linux.intel.com, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org
Subject: Re: [PATCH] perf/annotate: Use architecture-agnostic register limit
Date: Wed, 1 Oct 2025 11:14:57 -0300 [thread overview]
Message-ID: <aN03YZ-GkfTyOD8Z@x1> (raw)
In-Reply-To: <CAP-5=fXVFBewYhSmjVCGTbzEN82apECRLRnSeit8rqydCBJ1bg@mail.gmail.com>
On Tue, Sep 23, 2025 at 12:11:27PM -0700, Ian Rogers wrote:
> On Tue, Sep 23, 2025 at 10:43 AM Suchit Karunakaran
> <suchitkarunakaran@gmail.com> wrote:
> >
> > Remove the arch-specific guard around TYPE_STATE_MAX_REGS and define it
> > as 32 for all architectures. The architecture that perf is built on may
> > not match the architecture that produced the perf.data file, so relying
> > on __powerpc__ or similar is fragile. Using 32 as a fixed upper bound is
> > safe since it is greater than the previous maximum of 16.
> > Add a comment to clarify that TYPE_STATE_MAX_REGS is an arch-independent
> > maximum rather than a build-time choice.
> >
> > Suggested-by: Ian Rogers <irogers@google.com>
> > Signed-off-by: Suchit Karunakaran <suchitkarunakaran@gmail.com>
>
> Reviewed-by: Ian Rogers <irogers@google.com>
Thanks, applied to perf-tools-next,
- Arnaldo
prev parent reply other threads:[~2025-10-01 14:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 17:42 [PATCH] perf/annotate: Use architecture-agnostic register limit Suchit Karunakaran
2025-09-23 19:11 ` Ian Rogers
2025-10-01 14:14 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aN03YZ-GkfTyOD8Z@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=skhan@linuxfoundation.org \
--cc=suchitkarunakaran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).