From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Dapeng Mi <dapeng1.mi@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Dapeng Mi <dapeng1.mi@intel.com>
Subject: Re: [Patch v3 0/6] Perf kvm commands bug fix
Date: Thu, 2 Oct 2025 15:30:55 -0300 [thread overview]
Message-ID: <aN7E3wnC4tZ8jenN@x1> (raw)
In-Reply-To: <20250919021659.1263351-1-dapeng1.mi@linux.intel.com>
On Fri, Sep 19, 2025 at 10:16:53AM +0800, Dapeng Mi wrote:
> This patch-set fixes perf kvm commands issues, like missed memory
> allocation check/free, out of range memory access and especially the
> issue that fails to sample guest with "perf kvm record/top" commands on
> Intel platforms.
>
> Since the change "KVM: x86/pmu: Add basic support to enable guest PEBS
> via DS"[1] starts, host loses the capability to sample guest with PEBS
> since all PEBS related MSRs are switched to guest value after vm-entry,
> like IA32_DS_AREA MSR is switched to guest GVA at vm-entry. This leads
> to PEBS events can't be used to sample guest by host, otherwise no guest
> PEBS records can be really sampled. The patches 5-6/6 fix this issue by
> using "cycles" event instead of PEBS event "cycles:P" to sample guest on
> Intel platforms.
>
> Changes:
> v2 -> v3:
> * Correct the fixes tag in patch 5-6/6.
> * Add "acked-by" tag from Namhyung.
>
Thanks, applied to perf-tools-next,
- Arnaldo
prev parent reply other threads:[~2025-10-02 18:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 2:16 [Patch v3 0/6] Perf kvm commands bug fix Dapeng Mi
2025-09-19 2:16 ` [Patch v3 1/6] perf tools kvm: Add missed memory allocation check and free Dapeng Mi
2025-09-19 2:16 ` [Patch v3 2/6] perf tools kwork: " Dapeng Mi
2025-09-19 2:16 ` [Patch v3 3/6] perf tools kvm: Fix the potential out of range memory access issue Dapeng Mi
2025-09-19 2:16 ` [Patch v3 4/6] perf tools: Add helper x86__is_intel_cpu() Dapeng Mi
2025-09-19 2:16 ` [Patch v3 5/6] perf tools kvm: Use "cycles" to sample guest for "kvm record" on Intel Dapeng Mi
2025-09-19 19:21 ` Arnaldo Carvalho de Melo
2025-09-22 6:47 ` Mi, Dapeng
2025-09-19 2:16 ` [Patch v3 6/6] perf tools kvm: Use "cycles" to sample guest for "kvm top" " Dapeng Mi
2025-10-02 18:30 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aN7E3wnC4tZ8jenN@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=dapeng1.mi@intel.com \
--cc=dapeng1.mi@linux.intel.com \
--cc=irogers@google.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).