* [PATCH v1] perf build: Move libopcode disasm tests to BUILD_NONDISTRO
@ 2025-10-03 2:39 Ian Rogers
2025-10-03 19:18 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 2+ messages in thread
From: Ian Rogers @ 2025-10-03 2:39 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Alexander Shishkin, Jiri Olsa, Ian Rogers,
Adrian Hunter, linux-perf-users, linux-kernel
The disasm feature tests feature-disassembler-four-args and
feature-disassembler-init-styled link against libopcodes part of
binutils which is license incompatible (GPLv3) with perf. Moving these
tests out of the common config will help improve build time.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/Makefile.config | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
index 6e7c057b8ecf..0d4a62869855 100644
--- a/tools/perf/Makefile.config
+++ b/tools/perf/Makefile.config
@@ -933,6 +933,14 @@ ifdef BUILD_NONDISTRO
else
$(warning Old version of libbfd/binutils things like PE executable profiling will not be available)
endif
+
+ ifeq ($(feature-disassembler-four-args), 1)
+ CFLAGS += -DDISASM_FOUR_ARGS_SIGNATURE
+ endif
+
+ ifeq ($(feature-disassembler-init-styled), 1)
+ CFLAGS += -DDISASM_INIT_STYLED
+ endif
endif
ifndef NO_LIBLLVM
@@ -1024,14 +1032,6 @@ ifdef HAVE_KVM_STAT_SUPPORT
CFLAGS += -DHAVE_KVM_STAT_SUPPORT
endif
-ifeq ($(feature-disassembler-four-args), 1)
- CFLAGS += -DDISASM_FOUR_ARGS_SIGNATURE
-endif
-
-ifeq ($(feature-disassembler-init-styled), 1)
- CFLAGS += -DDISASM_INIT_STYLED
-endif
-
ifeq (${IS_64_BIT}, 1)
ifndef NO_PERF_READ_VDSO32
$(call feature_check,compile-32)
--
2.51.0.618.g983fd99d29-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] perf build: Move libopcode disasm tests to BUILD_NONDISTRO
2025-10-03 2:39 [PATCH v1] perf build: Move libopcode disasm tests to BUILD_NONDISTRO Ian Rogers
@ 2025-10-03 19:18 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2025-10-03 19:18 UTC (permalink / raw)
To: Ian Rogers
Cc: Peter Zijlstra, Ingo Molnar, Namhyung Kim, Alexander Shishkin,
Jiri Olsa, Adrian Hunter, linux-perf-users, linux-kernel
On Thu, Oct 02, 2025 at 07:39:28PM -0700, Ian Rogers wrote:
> The disasm feature tests feature-disassembler-four-args and
> feature-disassembler-init-styled link against libopcodes part of
> binutils which is license incompatible (GPLv3) with perf. Moving these
> tests out of the common config will help improve build time.
Thanks, applied to perf-tools-next,
- Arnaldo
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/Makefile.config | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> index 6e7c057b8ecf..0d4a62869855 100644
> --- a/tools/perf/Makefile.config
> +++ b/tools/perf/Makefile.config
> @@ -933,6 +933,14 @@ ifdef BUILD_NONDISTRO
> else
> $(warning Old version of libbfd/binutils things like PE executable profiling will not be available)
> endif
> +
> + ifeq ($(feature-disassembler-four-args), 1)
> + CFLAGS += -DDISASM_FOUR_ARGS_SIGNATURE
> + endif
> +
> + ifeq ($(feature-disassembler-init-styled), 1)
> + CFLAGS += -DDISASM_INIT_STYLED
> + endif
> endif
>
> ifndef NO_LIBLLVM
> @@ -1024,14 +1032,6 @@ ifdef HAVE_KVM_STAT_SUPPORT
> CFLAGS += -DHAVE_KVM_STAT_SUPPORT
> endif
>
> -ifeq ($(feature-disassembler-four-args), 1)
> - CFLAGS += -DDISASM_FOUR_ARGS_SIGNATURE
> -endif
> -
> -ifeq ($(feature-disassembler-init-styled), 1)
> - CFLAGS += -DDISASM_INIT_STYLED
> -endif
> -
> ifeq (${IS_64_BIT}, 1)
> ifndef NO_PERF_READ_VDSO32
> $(call feature_check,compile-32)
> --
> 2.51.0.618.g983fd99d29-goog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-03 19:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-03 2:39 [PATCH v1] perf build: Move libopcode disasm tests to BUILD_NONDISTRO Ian Rogers
2025-10-03 19:18 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).