From: Sean Christopherson <seanjc@google.com>
To: Dapeng Mi <dapeng1.mi@linux.intel.com>
Cc: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"intel-xe@lists.freedesktop.org"
<intel-xe@lists.freedesktop.org>,
Suresh Kumar Kurmi <suresh.kumar.kurmi@intel.com>,
Jani Saarinen <jani.saarinen@intel.com>,
lucas.demarchi@intel.com, linux-perf-users@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: REGRESSION on linux-next (next-20250919)
Date: Thu, 9 Oct 2025 05:58:35 -0700 [thread overview]
Message-ID: <aOexe4LNpmJnHTm9@google.com> (raw)
In-Reply-To: <e9e8f087-60f6-455a-b0e0-e5c29fc54129@linux.intel.com>
On Thu, Oct 09, 2025, Dapeng Mi wrote:
>
> On 10/7/2025 2:22 PM, Borah, Chaitanya Kumar wrote:
> > Hi,
> >
> > On 10/6/2025 1:33 PM, Borah, Chaitanya Kumar wrote:
> >> Thank you for your responses.
> >>
> >> Following change fixes the issue for us.
> >>
> >>
> >> diff --git a/arch/x86/kvm/pmu.c b/arch/x86/kvm/pmu.c
> >> index 40ac4cb44ed2..487ad19a236e 100644
> >> --- a/arch/x86/kvm/pmu.c
> >> +++ b/arch/x86/kvm/pmu.c
> >> @@ -108,16 +108,18 @@ void kvm_init_pmu_capability(const struct
> >> kvm_pmu_ops *pmu_ops)
> >> bool is_intel = boot_cpu_data.x86_vendor == X86_VENDOR_INTEL;
> >> int min_nr_gp_ctrs = pmu_ops->MIN_NR_GP_COUNTERS;
> >>
> >> - perf_get_x86_pmu_capability(&kvm_host_pmu);
> >> -
> >> /*
> >> * Hybrid PMUs don't play nice with virtualization without careful
> >> * configuration by userspace, and KVM's APIs for reporting
> >> supported
> >> * vPMU features do not account for hybrid PMUs. Disable vPMU
> >> support
> >> * for hybrid PMUs until KVM gains a way to let userspace opt-in.
> >> */
> >> - if (cpu_feature_enabled(X86_FEATURE_HYBRID_CPU))
> >> + if (cpu_feature_enabled(X86_FEATURE_HYBRID_CPU)) {
> >> enable_pmu = false;
> >> + memset(&kvm_host_pmu, 0, sizeof(kvm_host_pmu));
> >> + } else {
> >> + perf_get_x86_pmu_capability(&kvm_host_pmu);
> >> + }
> > Can we expect a formal patch soon?
>
> I'd like to post a patch to fix this tomorrow if Sean has no bandwidth on
> this. Thanks.
Sorry, my bad, I was waiting for you to post a patch, but that wasn't at all
clear. So yeah, go ahead and post one :-)
next prev parent reply other threads:[~2025-10-09 12:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-30 5:30 REGRESSION on linux-next (next-20250919) Borah, Chaitanya Kumar
2025-09-30 8:03 ` Mi, Dapeng
2025-09-30 15:09 ` Sean Christopherson
2025-10-06 8:03 ` Borah, Chaitanya Kumar
2025-10-07 6:22 ` Borah, Chaitanya Kumar
2025-10-09 1:34 ` Mi, Dapeng
2025-10-09 12:58 ` Sean Christopherson [this message]
2025-10-10 0:47 ` Mi, Dapeng
2025-10-06 8:27 ` Mi, Dapeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aOexe4LNpmJnHTm9@google.com \
--to=seanjc@google.com \
--cc=chaitanya.kumar.borah@intel.com \
--cc=dapeng1.mi@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.saarinen@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=suresh.kumar.kurmi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).