From: Namhyung Kim <namhyung@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: "Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@kernel.org>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"John Garry" <john.g.garry@oracle.com>,
"Will Deacon" <will@kernel.org>,
"James Clark" <james.clark@linaro.org>,
"Mike Leach" <mike.leach@linaro.org>,
"Leo Yan" <leo.yan@linux.dev>,
"Suzuki K Poulose" <suzuki.poulose@arm.com>,
"Yicong Yang" <yangyicong@hisilicon.com>,
"Jonathan Cameron" <jonathan.cameron@huawei.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Darren Hart" <dvhart@infradead.org>,
"Davidlohr Bueso" <dave@stgolabs.net>,
"André Almeida" <andrealmeid@igalia.com>,
"Tomas Glozar" <tglozar@redhat.com>,
"Quentin Monnet" <qmo@kernel.org>,
"Yuzhuo Jing" <yuzhuo@google.com>,
"Blake Jones" <blakejones@google.com>,
"Charlie Jenkins" <charlie@rivosinc.com>,
"Yeoreum Yun" <yeoreum.yun@arm.com>,
"Athira Rajeev" <atrajeev@linux.ibm.com>,
"Ravi Bangoria" <ravi.bangoria@amd.com>,
"Collin Funk" <collin.funk1@gmail.com>,
"Dapeng Mi" <dapeng1.mi@linux.intel.com>,
"Thomas Richter" <tmricht@linux.ibm.com>,
"Dmitry Vyukov" <dvyukov@google.com>,
"Andi Kleen" <ak@linux.intel.com>,
"Howard Chu" <howardchu95@gmail.com>,
"Zecheng Li" <zecheng@google.com>, tanze <tanze@kylinos.cn>,
"Gabriele Monaco" <gmonaco@redhat.com>,
"GuoHan Zhao" <zhaoguohan@kylinos.cn>,
"Markus Elfring" <Markus.Elfring@web.de>,
"Colin Ian King" <colin.i.king@gmail.com>,
"Kan Liang" <kan.liang@linux.intel.com>,
"Dr. David Alan Gilbert" <linux@treblig.org>,
"Jean-Philippe Romain" <jean-philippe.romain@foss.st.com>,
"Yang Li" <yang.lee@linux.alibaba.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v1 0/5] Remove NO_AUXTRACE build option
Date: Mon, 10 Nov 2025 22:21:27 -0800 [thread overview]
Message-ID: <aRLV50z1L9A3YRFF@google.com> (raw)
In-Reply-To: <20251110013152.3099080-1-irogers@google.com>
Hi Ian,
On Sun, Nov 09, 2025 at 05:31:47PM -0800, Ian Rogers wrote:
> Switch the __get_cpuid feature for intel-pt to use the provided cpuid
> function in perf, this removes the need for NO_AUXTRACE when the
> feature detection fails. Remove the now unnecessary feature
> detection. Remove NO_AUXTRACE as it just builds a more broken version
Can you please elaborate what the broken part is?
Thanks,
Namhyung
> of perf and isn't guarding dependencies on any libraries, etc. Clean
> up headers files for auxtrace.h.
>
> This was prompted by needing to make a v2 patch set of:
> https://lore.kernel.org/lkml/20251107170712.2302714-1-irogers@google.com/
> due to a broken NO_AUXTRACE configuration.
>
> Ian Rogers (5):
> perf intel-pt: Use the perf provided "cpuid.h"
> perf build: Don't add NO_AUXTRACE if missing feature-get_cpuid
> tool build: Remove __get_cpuid feature test
> perf build: Remove NO_AUXTRACE build option
> perf auxtrace: Remove errno.h from auxtrace.h and fix transitive
> dependencies
>
> tools/build/Makefile.feature | 2 -
> tools/build/feature/Makefile | 4 -
> tools/build/feature/test-all.c | 5 -
> tools/build/feature/test-get_cpuid.c | 8 -
> tools/perf/Documentation/perf-check.txt | 1 -
> tools/perf/Makefile.config | 13 --
> tools/perf/Makefile.perf | 2 -
> tools/perf/arch/arm/annotate/instructions.c | 1 +
> tools/perf/arch/arm/util/Build | 2 +-
> tools/perf/arch/arm/util/auxtrace.c | 1 +
> tools/perf/arch/arm/util/pmu.c | 2 -
> tools/perf/arch/arm64/annotate/instructions.c | 1 +
> tools/perf/arch/arm64/util/Build | 19 +-
> tools/perf/arch/arm64/util/arm-spe.c | 1 +
> tools/perf/arch/arm64/util/hisi-ptt.c | 1 +
> tools/perf/arch/powerpc/util/Build | 2 +-
> tools/perf/arch/powerpc/util/auxtrace.c | 2 +-
> tools/perf/arch/s390/util/Build | 2 +-
> tools/perf/arch/s390/util/auxtrace.c | 1 +
> tools/perf/arch/x86/tests/Build | 4 +-
> tools/perf/arch/x86/tests/arch-tests.c | 4 -
> tools/perf/arch/x86/tests/intel-pt-test.c | 6 +-
> tools/perf/arch/x86/tests/topdown.c | 1 +
> tools/perf/arch/x86/util/Build | 6 +-
> tools/perf/arch/x86/util/intel-pt.c | 4 +-
> tools/perf/arch/x86/util/pmu.c | 2 -
> tools/perf/arch/x86/util/topdown.c | 1 +
> tools/perf/bench/evlist-open-close.c | 1 +
> tools/perf/bench/futex.c | 1 +
> tools/perf/bench/pmu-scan.c | 1 +
> tools/perf/bench/synthesize.c | 1 +
> tools/perf/builtin-check.c | 1 -
> tools/perf/builtin-inject.c | 15 --
> tools/perf/builtin-mem.c | 1 +
> tools/perf/builtin-record.c | 36 ---
> tools/perf/builtin-script.c | 12 -
> tools/perf/tests/hwmon_pmu.c | 1 +
> tools/perf/tests/make | 4 +-
> tools/perf/tests/parse-metric.c | 1 +
> tools/perf/tests/pfm.c | 1 +
> tools/perf/ui/hist.c | 1 +
> tools/perf/util/Build | 24 +-
> tools/perf/util/annotate-data.c | 2 +-
> tools/perf/util/arm-spe-decoder/Build | 2 +-
> tools/perf/util/auxtrace.h | 221 +-----------------
> tools/perf/util/bpf-filter.h | 2 +
> tools/perf/util/bpf-trace-summary.c | 1 +
> tools/perf/util/bpf_counter_cgroup.c | 1 +
> tools/perf/util/bpf_ftrace.c | 3 +-
> tools/perf/util/bpf_map.c | 1 +
> tools/perf/util/cgroup.c | 1 +
> tools/perf/util/cs-etm-decoder/Build | 2 +-
> tools/perf/util/drm_pmu.c | 1 +
> tools/perf/util/evswitch.c | 1 +
> tools/perf/util/hisi-ptt-decoder/Build | 2 +-
> tools/perf/util/intel-pt-decoder/Build | 8 +-
> tools/perf/util/intel-tpebs.c | 1 +
> tools/perf/util/kvm-stat.h | 1 +
> tools/perf/util/mmap.c | 1 +
> tools/perf/util/pfm.c | 1 +
> tools/perf/util/powerpc-vpadtl.c | 1 +
> tools/perf/util/stat-shadow.c | 1 +
> tools/perf/util/synthetic-events.h | 15 --
> 63 files changed, 77 insertions(+), 391 deletions(-)
> delete mode 100644 tools/build/feature/test-get_cpuid.c
>
> --
> 2.51.2.1041.gc1ab5b90ca-goog
>
prev parent reply other threads:[~2025-11-11 6:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 1:31 [PATCH v1 0/5] Remove NO_AUXTRACE build option Ian Rogers
2025-11-10 1:31 ` [PATCH v1 1/5] perf intel-pt: Use the perf provided "cpuid.h" Ian Rogers
2025-11-10 1:31 ` [PATCH v1 2/5] perf build: Don't add NO_AUXTRACE if missing feature-get_cpuid Ian Rogers
2025-11-10 1:31 ` [PATCH v1 3/5] tool build: Remove __get_cpuid feature test Ian Rogers
2025-11-10 1:31 ` [PATCH v1 4/5] perf build: Remove NO_AUXTRACE build option Ian Rogers
2025-11-10 1:31 ` [PATCH v1 5/5] perf auxtrace: Remove errno.h from auxtrace.h and fix transitive dependencies Ian Rogers
2025-11-11 6:21 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRLV50z1L9A3YRFF@google.com \
--to=namhyung@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrealmeid@igalia.com \
--cc=atrajeev@linux.ibm.com \
--cc=blakejones@google.com \
--cc=charlie@rivosinc.com \
--cc=colin.i.king@gmail.com \
--cc=collin.funk1@gmail.com \
--cc=dapeng1.mi@linux.intel.com \
--cc=dave@stgolabs.net \
--cc=dvhart@infradead.org \
--cc=dvyukov@google.com \
--cc=gmonaco@redhat.com \
--cc=howardchu95@gmail.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jean-philippe.romain@foss.st.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux@treblig.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=qmo@kernel.org \
--cc=ravi.bangoria@amd.com \
--cc=suzuki.poulose@arm.com \
--cc=tanze@kylinos.cn \
--cc=tglozar@redhat.com \
--cc=tglx@linutronix.de \
--cc=tmricht@linux.ibm.com \
--cc=will@kernel.org \
--cc=yang.lee@linux.alibaba.com \
--cc=yangyicong@hisilicon.com \
--cc=yeoreum.yun@arm.com \
--cc=yuzhuo@google.com \
--cc=zecheng@google.com \
--cc=zhaoguohan@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).