linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	James Clark <james.clark@linaro.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf stat: Align metric output without events
Date: Wed, 12 Nov 2025 09:57:19 -0800	[thread overview]
Message-ID: <aRTKf6iw0sRuC0ww@google.com> (raw)
In-Reply-To: <20251106072834.1750880-1-namhyung@kernel.org>

On Wed, Nov 05, 2025 at 11:28:34PM -0800, Namhyung Kim wrote:
> One of my concern in the perf stat output was the alignment in the
> metrics and shadow stats.  I think it missed to calculate the basic
> output length using COUNTS_LEN and EVNAME_LEN but missed to add the
> unit length like "msec" and surround 2 spaces.  I'm not sure why it's
> not printed below though.
> 
> But anyway, now it shows correctly aligned metric output.
> 
>   $ perf stat true
> 
>    Performance counter stats for 'true':
> 
>              859,772      task-clock                       #    0.395 CPUs utilized
>                    0      context-switches                 #    0.000 /sec
>                    0      cpu-migrations                   #    0.000 /sec
>                   56      page-faults                      #   65.134 K/sec
>            1,075,022      instructions                     #    0.86  insn per cycle
>            1,255,911      cycles                           #    1.461 GHz
>              220,573      branches                         #  256.548 M/sec
>                7,381      branch-misses                    #    3.35% of all branches
>                           TopdownL1                        #     19.2 %  tma_retiring
>                                                            #     28.6 %  tma_backend_bound
>                                                            #      9.5 %  tma_bad_speculation
>                                                            #     42.6 %  tma_frontend_bound
> 
>          0.002174871 seconds time elapsed                  ^
>                                                            |
>          0.002154000 seconds user                          |
>          0.000000000 seconds sys                          here
> 
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>

Applied to perf-tools-next, thanks!

Best regards,
Namhyung


      parent reply	other threads:[~2025-11-12 17:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-06  7:28 [PATCH] perf stat: Align metric output without events Namhyung Kim
2025-11-11 17:26 ` Ian Rogers
2025-11-12 17:57 ` Namhyung Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aRTKf6iw0sRuC0ww@google.com \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).