From: Namhyung Kim <namhyung@kernel.org>
To: Anubhav Shelat <ashelat@redhat.com>
Cc: Ian Rogers <irogers@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Thomas Falcon <thomas.falcon@intel.com>,
Howard Chu <howardchu95@gmail.com>,
James Clark <james.clark@linaro.org>,
Zhongqiu Han <quic_zhonhan@quicinc.com>,
Ravi Bangoria <ravi.bangoria@amd.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/3] perf pmu: Add PMU kind to simplify differentiating
Date: Mon, 24 Nov 2025 12:22:36 -0800 [thread overview]
Message-ID: <aSS-jMEgzX30fe1p@google.com> (raw)
In-Reply-To: <CA+G8Dh+wLx+FvjjoEkypqvXhbzWEQVpykovzrsHi2_eQjHkzQA@mail.gmail.com>
Hello,
On Mon, Nov 24, 2025 at 12:34:11PM +0000, Anubhav Shelat wrote:
> On Fri, Nov 14, 2025 at 10:06 PM Ian Rogers <irogers@google.com> wrote:
> > +static inline enum pmu_kind perf_pmu__kind(const struct perf_pmu *pmu)
> > +{
> > + __u32 type;
> > +
> > + if (!pmu)
> > + return PERF_PMU_KIND_PE;
> > +
> > + type = pmu->type;
> > + if (type <= PERF_PMU_TYPE_PE_END)
> > + return PERF_PMU_KIND_PE;
> > + if (type <= PERF_PMU_TYPE_DRM_END)
> > + return PERF_PMU_KIND_DRM;
> > + if (type <= PERF_PMU_TYPE_DRM_END)
> > + return PERF_PMU_KIND_DRM;
> > + if (type <= PERF_PMU_TYPE_HWMON_END)
> > + return PERF_PMU_KIND_HWMON;
> > + if (type == PERF_PMU_TYPE_TOOL)
> > + return PERF_PMU_KIND_TOOL;
> > + return PERF_PMU_KIND_FAKE;
> > +}
> > +
>
> Looks like there's a duplicate check for PERF_PMU_TYPE_DRM_END.
Right, can you please send a fix?
Thanks,
Namhyung
next prev parent reply other threads:[~2025-11-24 20:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 22:05 [PATCH v1 1/3] perf header: Switch "cpu" for find_core_pmu in caps feature writing Ian Rogers
2025-11-14 22:05 ` [PATCH v1 2/3] perf pmu: Add PMU kind to simplify differentiating Ian Rogers
2025-11-24 12:34 ` Anubhav Shelat
2025-11-24 20:22 ` Namhyung Kim [this message]
2025-11-25 11:41 ` [PATCH] perf pmu: fix duplicate conditional statement Anubhav Shelat
2025-11-26 1:33 ` Mi, Dapeng
2025-11-26 2:27 ` Ian Rogers
2025-11-27 20:58 ` Namhyung Kim
2025-11-14 22:05 ` [PATCH v1 3/3] perf evsel: Skip store_evsel_ids for non-perf-event PMUs Ian Rogers
2025-11-17 19:47 ` Falcon, Thomas
2025-11-20 19:02 ` [PATCH v1 1/3] perf header: Switch "cpu" for find_core_pmu in caps feature writing Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSS-jMEgzX30fe1p@google.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ashelat@redhat.com \
--cc=howardchu95@gmail.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=quic_zhonhan@quicinc.com \
--cc=ravi.bangoria@amd.com \
--cc=thomas.falcon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).