From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jon Kohler <jon@nutanix.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@linaro.org>,
Tomas Glozar <tglozar@redhat.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] perf build: build BPF skeletons with fPIC
Date: Wed, 3 Dec 2025 13:43:17 -0300 [thread overview]
Message-ID: <aTBopdY6tmmxbDuu@x1> (raw)
In-Reply-To: <20251203035526.1237602-1-jon@nutanix.com>
On Tue, Dec 02, 2025 at 08:55:26PM -0700, Jon Kohler wrote:
> Fix Makefile.perf to ensure that bpf skeletons are built with fPIC.
>
> When building with BUILD_BPF_SKEL=1, bpf_skel's was not getting built
> with fPIC, seeing compilation failures like:
>
> /usr/bin/ld: /builddir/.../tools/perf/util/bpf_skel/.tmp/bootstrap/main.o:
> relocation R_X86_64_32 against `.rodata.str1.8' can not be used when
> making a PIE object; recompile with -fPIE
>
> Bisected down to 6.18 commit a39516805992 ("tools build: Don't assume
> libtracefs-devel is always available").
>
> Fixes: a39516805992 ("tools build: Don't assume libtracefs-devel is always available")
How come, this patch is just:
diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
index 9c1a69d26f5121fd..531f8fc4f7df9943 100644
--- a/tools/build/Makefile.feature
+++ b/tools/build/Makefile.feature
@@ -83,7 +83,6 @@ FEATURE_TESTS_BASIC := \
libpython \
libslang \
libtraceevent \
- libtracefs \
libcpupower \
pthread-attr-setaffinity-np \
pthread-barrier \
diff --git a/tools/build/feature/test-all.c b/tools/build/feature/test-all.c
index e1847db6f8e63750..2df593593b6ec15e 100644
--- a/tools/build/feature/test-all.c
+++ b/tools/build/feature/test-all.c
@@ -150,10 +150,6 @@
# include "test-libtraceevent.c"
#undef main
-#define main main_test_libtracefs
-# include "test-libtracefs.c"
-#undef main
-
int main(int argc, char *argv[])
{
main_test_libpython();
@@ -187,7 +183,6 @@ int main(int argc, char *argv[])
main_test_reallocarray();
main_test_libzstd();
main_test_libtraceevent();
- main_test_libtracefs();
return 0;
}
----
And your patch is touching building bpftool? Seems very unrelated :-\
- Arnaldo
> Cc: stable@vger.kernel.org
> Signed-off-by: Jon Kohler <jon@nutanix.com>
> ---
> tools/perf/Makefile.perf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index 02f87c49801f..4557c2e89e88 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -1211,7 +1211,7 @@ endif
>
> $(BPFTOOL): | $(SKEL_TMP_OUT)
> $(Q)CFLAGS= $(MAKE) -C ../bpf/bpftool \
> - OUTPUT=$(SKEL_TMP_OUT)/ bootstrap
> + EXTRA_CFLAGS="-fPIC" OUTPUT=$(SKEL_TMP_OUT)/ bootstrap
>
> # Paths to search for a kernel to generate vmlinux.h from.
> VMLINUX_BTF_ELF_PATHS ?= $(if $(O),$(O)/vmlinux) \
> --
> 2.43.0
next prev parent reply other threads:[~2025-12-03 16:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 3:55 [PATCH] perf build: build BPF skeletons with fPIC Jon Kohler
2025-12-03 16:43 ` Arnaldo Carvalho de Melo [this message]
2025-12-03 16:48 ` Jon Kohler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTBopdY6tmmxbDuu@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bpf@vger.kernel.org \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=jon@nutanix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=tglozar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox