linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Jones <tonyj@suse.de>
To: James Clark <james.clark@linaro.org>
Cc: Ian Rogers <irogers@google.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Howard Chu <howardchu95@gmail.com>,
	Stephen Brennan <stephen.s.brennan@oracle.com>,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v1] perf addr2line: Add a libdw implementation
Date: Thu, 11 Dec 2025 15:35:23 -0800	[thread overview]
Message-ID: <aTtVO7Iykc8oTl8c@suse.de> (raw)
In-Reply-To: <f85dacc5-5d81-4ee7-acf3-8aa053c42dab@linaro.org>

On Thu, Nov 27, 2025 at 12:16:29PM +0000, James Clark wrote:

> If the llvm addr2line implementation is also supposed to be slow, it just
> means we're trading speed with accuracy with this change. Hard to say what
> the default should be in that case.

I originally inquired about this (and was going to code up a patch
using libdw but Ian beat me to it) as we had a customer bug 
complaining about the performance of the binutils (/usr/bin/addr2line) 
forking solution and llvm isn't presently an option for us.

Using the forked addr2line the customer data set takes real: 54m15.023s 
user: 40m57.719s sys: 11m22.461s for perf script -F ip,srcline (with 
numerous time-out errors). 

Versus real: 6m6.598s user: 5m32.603s sys: 0m1.768s with this
proposed libdw patch.

I'm also unfortunately seeing similar wrong file/line# issues. This
said I think given that libdw is being used anyways and how poor the 
/usr/bin/addr2line performance is that it's worth digging deeper into 
what the issues are with libdw.

I'll try to look at it some more next week.

Thanks for the patch Ian!

Tony

---------
Tony Jones
SUSE Kernel Performance Team

  parent reply	other threads:[~2025-12-11 23:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-22  9:39 [PATCH v1] perf addr2line: Add a libdw implementation Ian Rogers
2025-11-24 11:21 ` James Clark
2025-11-26 18:27 ` Namhyung Kim
2025-11-27 11:43   ` Ian Rogers
2025-11-27 12:16     ` James Clark
2025-11-27 13:19       ` Ian Rogers
2025-11-27 13:48         ` James Clark
2025-11-28  9:00           ` Ian Rogers
2025-11-28 14:25             ` James Clark
2025-12-11 23:35       ` Tony Jones [this message]
     [not found]         ` <CAP-5=fUbZ1pjvcbF0do8BrC0NAzkOJeQUAozQhXKpGuosrW3ew@mail.gmail.com>
2025-12-12 16:34           ` Tony Jones
2025-11-27 20:53     ` Namhyung Kim
2025-11-28  8:42       ` Ian Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aTtVO7Iykc8oTl8c@suse.de \
    --to=tonyj@suse.de \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=howardchu95@gmail.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=stephen.s.brennan@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).