From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Nicolas Schier <n.schier@avm.de>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@linaro.org>,
Michael Petlan <mpetlan@redhat.com>,
Jakub Brnak <jbrnak@redhat.com>,
Veronika Molnarova <vmolnaro@redhat.com>,
Philipp Hahn <p.hahn@avm.de>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Nicolas Schier <nsc@kernel.org>
Subject: Re: [PATCH v3] perf build: Raise minimum shellcheck version to 0.7.2
Date: Mon, 12 Jan 2026 15:54:21 -0300 [thread overview]
Message-ID: <aWVDXUv0Jdon_nFB@x1> (raw)
In-Reply-To: <20260108-perf-raise-minimum-shellcheck-version-v3-1-36028909e7d0@avm.de>
On Thu, Jan 08, 2026 at 12:29:10PM +0100, Nicolas Schier wrote:
> Raise the minimum shellcheck version for perf builds to 0.7.2, so that
> systems with shellcheck versions below 0.7.2 will automatically skip the
> shell script checking, even if NO_SHELLCHECK is unset.
>
> Since commit 241f21be7d0f ("perf test perftool_testsuite: Use absolute
> paths"), shellcheck versions before 0.7.2 break the perf build with
> several SC1090 [2] warnings due to its too strict dynamic source
> handling [1], e.g.:
>
> In tests/shell/base_probe/test_line_semantics.sh line 20:
> . "$DIR_PATH/../common/init.sh"
> ^---------------------------^ SC1090: Can't follow non-constant source. Use a directive to specify location.
>
> Fixes: 241f21be7d0f ("perf test perftool_testsuite: Use absolute paths")
Thanks, applied to perf-tools-next,
- Arnaldo
prev parent reply other threads:[~2026-01-12 18:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 11:29 [PATCH v3] perf build: Raise minimum shellcheck version to 0.7.2 Nicolas Schier
2026-01-12 18:54 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWVDXUv0Jdon_nFB@x1 \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jbrnak@redhat.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=mpetlan@redhat.com \
--cc=n.schier@avm.de \
--cc=namhyung@kernel.org \
--cc=nsc@kernel.org \
--cc=p.hahn@avm.de \
--cc=peterz@infradead.org \
--cc=vmolnaro@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox