public inbox for linux-perf-users@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ian Rogers <irogers@google.com>,
	James Clark <james.clark@linaro.org>,
	Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2 1/2] perf inject: Add --convert-callchain option
Date: Tue, 13 Jan 2026 18:24:51 -0300	[thread overview]
Message-ID: <aWa4IzM1QIxH5Z57@x1> (raw)
In-Reply-To: <aWa12lGzx5ulhvIs@google.com>

On Tue, Jan 13, 2026 at 01:15:06PM -0800, Namhyung Kim wrote:
> On Tue, Jan 13, 2026 at 04:38:31PM -0300, Arnaldo Carvalho de Melo wrote:
> > On Fri, Jan 09, 2026 at 05:17:14PM -0800, Namhyung Kim wrote:
> > > There are applications not built with frame pointers, so DWARF is needed
> > > to get the stack traces.  So `perf record --call-graph dwarf` saves the
> > > stack and register data for each sample to get the stacktrace offline.
> > > But sometimes those data may have sensitive information and we don't
> > > want to keep them in the file.
 
> > > This perf inject --convert-callchain option parses the callchains and
> > > discard the stack and register after that.  This will save storage space
> > > and processing time for the new data file.  Of course, users should
> > > remove the original data file. :)

> > This made me think for a while to finally realize this is not a general
> > purpose "convert callchain" option, but one that converts to ip-based
> > callchains specificaly, useful and probably can stay with this name, or
> > maybe we could use --resolve-callchains as we use
> > thread__resolve_callchain() for that anyway?
 
> IIUC resolving callchain is to get DSO/map and symbol from raw data.
> But I admit the name is general but have no other idea. :)

Naming is difficult, I think we can keep as --convert-callchain, if we
ever want to do other kind of conversion than from DWARF to IP we can
just pass arguments to this option, with it without options, as is now,
meaning the most common convertion, the one being done in your patch.

I'll apply the patch as is, thanks.

- Arnaldo

  reply	other threads:[~2026-01-13 21:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-10  1:17 [PATCH v2 1/2] perf inject: Add --convert-callchain option Namhyung Kim
2026-01-10  1:17 ` [PATCH v2 2/2] perf test: Add DWARF callchain conversion test Namhyung Kim
2026-01-12 23:15   ` Ian Rogers
2026-01-12 23:15 ` [PATCH v2 1/2] perf inject: Add --convert-callchain option Ian Rogers
2026-01-13 19:38 ` Arnaldo Carvalho de Melo
2026-01-13 21:15   ` Namhyung Kim
2026-01-13 21:24     ` Arnaldo Carvalho de Melo [this message]
2026-01-13 21:35 ` Arnaldo Carvalho de Melo
2026-01-13 22:45   ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWa4IzM1QIxH5Z57@x1 \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox