* [PATCH] tools/perf/util/addr_location.c: update outdated comment
@ 2025-12-30 16:52 Julia Lawall
2026-01-02 0:07 ` Ian Rogers
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2025-12-30 16:52 UTC (permalink / raw)
To: Peter Zijlstra
Cc: yunbolyu, kexinsun, ratnadiraw, xutong.ma, Ingo Molnar,
Arnaldo Carvalho de Melo, Namhyung Kim, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Ian Rogers, Adrian Hunter,
linux-perf-users, linux-kernel
The function addr_location__put() was renamed addr_location__exit()
in commit 0dd5041c9a0e ("perf addr_location: Add init/exit/copy
functions"). Make the comment preceding the function consistent with
the function itself.
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
---
tools/perf/util/addr_location.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/addr_location.c b/tools/perf/util/addr_location.c
index 007a2f5df9a6..81a0b79c5e10 100644
--- a/tools/perf/util/addr_location.c
+++ b/tools/perf/util/addr_location.c
@@ -24,7 +24,7 @@ void addr_location__init(struct addr_location *al)
* The preprocess_sample method will return with reference counts for the
* in it, when done using (and perhaps getting ref counts if needing to
* keep a pointer to one of those entries) it must be paired with
- * addr_location__put(), so that the refcounts can be decremented.
+ * addr_location__exit(), so that the refcounts can be decremented.
*/
void addr_location__exit(struct addr_location *al)
{
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] tools/perf/util/addr_location.c: update outdated comment
2025-12-30 16:52 [PATCH] tools/perf/util/addr_location.c: update outdated comment Julia Lawall
@ 2026-01-02 0:07 ` Ian Rogers
2026-01-13 20:48 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: Ian Rogers @ 2026-01-02 0:07 UTC (permalink / raw)
To: Julia Lawall
Cc: Peter Zijlstra, yunbolyu, kexinsun, ratnadiraw, xutong.ma,
Ingo Molnar, Arnaldo Carvalho de Melo, Namhyung Kim, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Adrian Hunter, linux-perf-users,
linux-kernel
On Tue, Dec 30, 2025 at 8:52 AM Julia Lawall <Julia.Lawall@inria.fr> wrote:
>
> The function addr_location__put() was renamed addr_location__exit()
> in commit 0dd5041c9a0e ("perf addr_location: Add init/exit/copy
> functions"). Make the comment preceding the function consistent with
> the function itself.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Reviewed-by: Ian Rogers <irogers@google.com>
Thanks,
Ian
> ---
> tools/perf/util/addr_location.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/addr_location.c b/tools/perf/util/addr_location.c
> index 007a2f5df9a6..81a0b79c5e10 100644
> --- a/tools/perf/util/addr_location.c
> +++ b/tools/perf/util/addr_location.c
> @@ -24,7 +24,7 @@ void addr_location__init(struct addr_location *al)
> * The preprocess_sample method will return with reference counts for the
> * in it, when done using (and perhaps getting ref counts if needing to
> * keep a pointer to one of those entries) it must be paired with
> - * addr_location__put(), so that the refcounts can be decremented.
> + * addr_location__exit(), so that the refcounts can be decremented.
> */
> void addr_location__exit(struct addr_location *al)
> {
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] tools/perf/util/addr_location.c: update outdated comment
2026-01-02 0:07 ` Ian Rogers
@ 2026-01-13 20:48 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2026-01-13 20:48 UTC (permalink / raw)
To: Ian Rogers
Cc: Julia Lawall, Peter Zijlstra, yunbolyu, kexinsun, ratnadiraw,
xutong.ma, Ingo Molnar, Namhyung Kim, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Adrian Hunter, linux-perf-users,
linux-kernel
On Thu, Jan 01, 2026 at 04:07:07PM -0800, Ian Rogers wrote:
> On Tue, Dec 30, 2025 at 8:52 AM Julia Lawall <Julia.Lawall@inria.fr> wrote:
> >
> > The function addr_location__put() was renamed addr_location__exit()
> > in commit 0dd5041c9a0e ("perf addr_location: Add init/exit/copy
> > functions"). Make the comment preceding the function consistent with
> > the function itself.
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
>
> Reviewed-by: Ian Rogers <irogers@google.com>
Thanks, applied to perf-tools-next,
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-13 20:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-30 16:52 [PATCH] tools/perf/util/addr_location.c: update outdated comment Julia Lawall
2026-01-02 0:07 ` Ian Rogers
2026-01-13 20:48 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox