From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@linaro.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] perf tests sched: Avoid error in cleanup on loaded machines
Date: Fri, 23 Jan 2026 13:50:37 -0300 [thread overview]
Message-ID: <aXOm3bctXs8i6cfC@x1> (raw)
In-Reply-To: <20260122175337.591403-1-irogers@google.com>
On Thu, Jan 22, 2026 at 09:53:37AM -0800, Ian Rogers wrote:
> The stop_noploops function will kill the noploop processes that are
> running for 10 seconds. On a loaded machine they may have already
> terminated meaning the kill will return an error of no such
> process. This doesn't matter and so ignore the error to avoid the test
> terminating in the cleanup.
>
> Fixes: 0e22c5ca44e6 ("perf test: Add sched latency and script shell tests")
Thanks, applied to perf-tools-next,
- Arnaldo
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/tests/shell/sched.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/tests/shell/sched.sh b/tools/perf/tests/shell/sched.sh
> index b9b81eaf856e..b9637069adb1 100755
> --- a/tools/perf/tests/shell/sched.sh
> +++ b/tools/perf/tests/shell/sched.sh
> @@ -53,7 +53,7 @@ start_noploops() {
> }
>
> cleanup_noploops() {
> - kill "$PID1" "$PID2"
> + kill "$PID1" "$PID2" || true
> }
>
> test_sched_record() {
> --
> 2.52.0.457.g6b5491de43-goog
prev parent reply other threads:[~2026-01-23 16:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 17:53 [PATCH v1] perf tests sched: Avoid error in cleanup on loaded machines Ian Rogers
2026-01-23 16:50 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXOm3bctXs8i6cfC@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox