public inbox for linux-perf-users@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] perf tests sched: Avoid error in cleanup on loaded machines
@ 2026-01-22 17:53 Ian Rogers
  2026-01-23 16:50 ` Arnaldo Carvalho de Melo
  0 siblings, 1 reply; 2+ messages in thread
From: Ian Rogers @ 2026-01-22 17:53 UTC (permalink / raw)
  To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
	Namhyung Kim, Alexander Shishkin, Jiri Olsa, Ian Rogers,
	Adrian Hunter, James Clark, linux-perf-users, linux-kernel

The stop_noploops function will kill the noploop processes that are
running for 10 seconds. On a loaded machine they may have already
terminated meaning the kill will return an error of no such
process. This doesn't matter and so ignore the error to avoid the test
terminating in the cleanup.

Fixes: 0e22c5ca44e6 ("perf test: Add sched latency and script shell tests")
Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/tests/shell/sched.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/tests/shell/sched.sh b/tools/perf/tests/shell/sched.sh
index b9b81eaf856e..b9637069adb1 100755
--- a/tools/perf/tests/shell/sched.sh
+++ b/tools/perf/tests/shell/sched.sh
@@ -53,7 +53,7 @@ start_noploops() {
 }
 
 cleanup_noploops() {
-  kill "$PID1" "$PID2"
+  kill "$PID1" "$PID2" || true
 }
 
 test_sched_record() {
-- 
2.52.0.457.g6b5491de43-goog


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v1] perf tests sched: Avoid error in cleanup on loaded machines
  2026-01-22 17:53 [PATCH v1] perf tests sched: Avoid error in cleanup on loaded machines Ian Rogers
@ 2026-01-23 16:50 ` Arnaldo Carvalho de Melo
  0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2026-01-23 16:50 UTC (permalink / raw)
  To: Ian Rogers
  Cc: Peter Zijlstra, Ingo Molnar, Namhyung Kim, Alexander Shishkin,
	Jiri Olsa, Adrian Hunter, James Clark, linux-perf-users,
	linux-kernel

On Thu, Jan 22, 2026 at 09:53:37AM -0800, Ian Rogers wrote:
> The stop_noploops function will kill the noploop processes that are
> running for 10 seconds. On a loaded machine they may have already
> terminated meaning the kill will return an error of no such
> process. This doesn't matter and so ignore the error to avoid the test
> terminating in the cleanup.
> 
> Fixes: 0e22c5ca44e6 ("perf test: Add sched latency and script shell tests")



Thanks, applied to perf-tools-next,

- Arnaldo

> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
>  tools/perf/tests/shell/sched.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/tests/shell/sched.sh b/tools/perf/tests/shell/sched.sh
> index b9b81eaf856e..b9637069adb1 100755
> --- a/tools/perf/tests/shell/sched.sh
> +++ b/tools/perf/tests/shell/sched.sh
> @@ -53,7 +53,7 @@ start_noploops() {
>  }
>  
>  cleanup_noploops() {
> -  kill "$PID1" "$PID2"
> +  kill "$PID1" "$PID2" || true
>  }
>  
>  test_sched_record() {
> -- 
> 2.52.0.457.g6b5491de43-goog

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-01-23 16:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-22 17:53 [PATCH v1] perf tests sched: Avoid error in cleanup on loaded machines Ian Rogers
2026-01-23 16:50 ` Arnaldo Carvalho de Melo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox