From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Michael Petlan <mpetlan@redhat.com>,
Jakub Brnak <jbrnak@redhat.com>,
acme@redhat.com, linux-perf-users@vger.kernel.org,
namhyung@kernel.org
Subject: Re: [PATCH v5 0/7] Introduce structure for shell tests
Date: Mon, 26 Jan 2026 17:37:35 -0300 [thread overview]
Message-ID: <aXfQj5sIKtKWLeu3@x1> (raw)
In-Reply-To: <CAP-5=fU3Xi1CT+YsaY+7Akq2Afh6m4hUwU3SkJvKPM2s1oR0ZA@mail.gmail.com>
On Fri, Jan 23, 2026 at 09:02:13AM -0800, Ian Rogers wrote:
> On Fri, Jan 23, 2026 at 8:29 AM Arnaldo Carvalho de Melo
> <acme@kernel.org> wrote:
> >
> > On Fri, Jan 23, 2026 at 03:26:54PM +0100, Michael Petlan wrote:
> > > Hello Ian and Namhyung,
> > >
> > > kindly reminding this patchset. Could we get it merged soon please?
> > > Or is there still anything to address?
> > >
> > > Thanks in advance!
> >
> > Just test applied and it went cleanly, will try to review it after
> > lunch.
>
> I think patch 4 has an issue as the clean up is in the wrong place.
> There are also some file descriptor leaks. Other than those happy to
> have my:
>
> Reviewed-by: Ian Rogers <irogers@google.com>
>
> on the series. Probably should get patch 4 fixed though.
Yeah, the first one I would fix myself, those leaks, but patch 4 needs
some more work, Michael, Jakub, can you please take a look and address
Ian review comments?
- Arnaldo
prev parent reply other threads:[~2026-01-26 20:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 15:56 [PATCH v5 0/7] Introduce structure for shell tests Jakub Brnak
2025-11-25 15:56 ` [PATCH v5 1/7] perf tests: Create a " Jakub Brnak
2026-01-23 16:51 ` Ian Rogers
2025-11-25 15:56 ` [PATCH v5 2/7] perf test: Provide setup for the shell test suite Jakub Brnak
2025-11-25 15:56 ` [PATCH v5 3/7] perftool-testsuite: Add empty setup for base_probe Jakub Brnak
2025-11-25 15:56 ` [PATCH v5 4/7] perf test: Introduce storing logs for shell tests Jakub Brnak
2026-01-23 16:57 ` Ian Rogers
2025-11-25 15:56 ` [PATCH v5 5/7] perf test: Format log directories " Jakub Brnak
2025-11-25 15:56 ` [PATCH v5 6/7] perf test: Remove perftool drivers Jakub Brnak
2025-11-25 15:56 ` [PATCH v5 7/7] perf test: Fix relative path for 'stderr-whitelist.txt' Jakub Brnak
2026-01-23 14:26 ` [PATCH v5 0/7] Introduce structure for shell tests Michael Petlan
2026-01-23 16:29 ` Arnaldo Carvalho de Melo
2026-01-23 17:02 ` Ian Rogers
2026-01-26 20:37 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXfQj5sIKtKWLeu3@x1 \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=irogers@google.com \
--cc=jbrnak@redhat.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox