From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
Thomas Richter <tmricht@linux.ibm.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] perf test record.sh: Fix shellcheck warning
Date: Sun, 8 Feb 2026 11:27:27 -0300 [thread overview]
Message-ID: <aYidT9oKKB9LVvw6@x1> (raw)
In-Reply-To: <20260207230452.1886143-1-irogers@google.com>
On Sat, Feb 07, 2026 at 03:04:52PM -0800, Ian Rogers wrote:
> Add quotes to avoid the following warning:
> ```
> In tests/shell/record.sh line 264:
> [ $(uname -m) = "s390x" ] && {
> ^---------^ SC2046 (warning): Quote this to prevent word splitting.
>
> For more information:
> https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
> ```
>
> Fixes: c73a56ed3c97 ("perf test: Fix test case Leader sampling on s390")
Thanks, applied to perf-tools-next,
- Arnaldo
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/tests/shell/record.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
> index 46b96d565680..7cb81cf3444a 100755
> --- a/tools/perf/tests/shell/record.sh
> +++ b/tools/perf/tests/shell/record.sh
> @@ -261,7 +261,7 @@ test_uid() {
> test_leader_sampling() {
> echo "Basic leader sampling test"
> events="{cycles,cycles}:Su"
> - [ $(uname -m) = "s390x" ] && {
> + [ "$(uname -m)" = "s390x" ] && {
> [ ! -d /sys/devices/cpum_sf ] && {
> echo "No CPUMF [Skipped record]"
> return
> --
> 2.53.0.239.g8d8fc8a987-goog
>
prev parent reply other threads:[~2026-02-08 14:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-07 23:04 [PATCH v1] perf test record.sh: Fix shellcheck warning Ian Rogers
2026-02-08 14:27 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYidT9oKKB9LVvw6@x1 \
--to=acme@kernel.org \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox