public inbox for linux-perf-users@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] perf tests workload: Formatting for code_with_type.rs
@ 2026-02-09 14:05 Dmitrii Dolgov
  2026-02-09 17:27 ` Ian Rogers
  2026-02-10  8:56 ` Miguel Ojeda
  0 siblings, 2 replies; 5+ messages in thread
From: Dmitrii Dolgov @ 2026-02-09 14:05 UTC (permalink / raw)
  To: linux-perf-users, Arnaldo Carvalho de Melo, Namhyung Kim,
	Ian Rogers, Miguel Ojeda
  Cc: Linux Kernel Mailing List, Dmitrii Dolgov, kernel test robot

One part of the rust code for code_with_type workload wasn't properly
formatted. Pass it through rustfmt to fix that.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202602091357.oyRv6hgQ-lkp@intel.com/
Signed-off-by: Dmitrii Dolgov <9erthalion6@gmail.com>
---
 tools/perf/tests/workloads/code_with_type.rs | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tools/perf/tests/workloads/code_with_type.rs b/tools/perf/tests/workloads/code_with_type.rs
index 3b91e51919d..3dab39b22dd 100644
--- a/tools/perf/tests/workloads/code_with_type.rs
+++ b/tools/perf/tests/workloads/code_with_type.rs
@@ -10,7 +10,11 @@ struct Buf {
 
 #[no_mangle]
 pub extern "C" fn test_rs(count: u32) {
-    let mut b =  Buf { data1: 0, data2: String::from("data"), data3: 0};
+    let mut b = Buf {
+        data1: 0,
+        data2: String::from("data"),
+        data3: 0,
+    };
 
     for _ in 1..count {
         b.data1 += 1;

base-commit: 335047109d7d488bf5ad32a4076e1a011994cd0e
-- 
2.52.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v1] perf tests workload: Formatting for code_with_type.rs
  2026-02-09 14:05 [PATCH v1] perf tests workload: Formatting for code_with_type.rs Dmitrii Dolgov
@ 2026-02-09 17:27 ` Ian Rogers
  2026-02-10  8:56 ` Miguel Ojeda
  1 sibling, 0 replies; 5+ messages in thread
From: Ian Rogers @ 2026-02-09 17:27 UTC (permalink / raw)
  To: Dmitrii Dolgov
  Cc: linux-perf-users, Arnaldo Carvalho de Melo, Namhyung Kim,
	Miguel Ojeda, Linux Kernel Mailing List, kernel test robot

On Mon, Feb 9, 2026 at 6:05 AM Dmitrii Dolgov <9erthalion6@gmail.com> wrote:
>
> One part of the rust code for code_with_type workload wasn't properly
> formatted. Pass it through rustfmt to fix that.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202602091357.oyRv6hgQ-lkp@intel.com/
> Signed-off-by: Dmitrii Dolgov <9erthalion6@gmail.com>

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/tests/workloads/code_with_type.rs | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/tests/workloads/code_with_type.rs b/tools/perf/tests/workloads/code_with_type.rs
> index 3b91e51919d..3dab39b22dd 100644
> --- a/tools/perf/tests/workloads/code_with_type.rs
> +++ b/tools/perf/tests/workloads/code_with_type.rs
> @@ -10,7 +10,11 @@ struct Buf {
>
>  #[no_mangle]
>  pub extern "C" fn test_rs(count: u32) {
> -    let mut b =  Buf { data1: 0, data2: String::from("data"), data3: 0};
> +    let mut b = Buf {
> +        data1: 0,
> +        data2: String::from("data"),
> +        data3: 0,
> +    };
>
>      for _ in 1..count {
>          b.data1 += 1;
>
> base-commit: 335047109d7d488bf5ad32a4076e1a011994cd0e
> --
> 2.52.0
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v1] perf tests workload: Formatting for code_with_type.rs
  2026-02-09 14:05 [PATCH v1] perf tests workload: Formatting for code_with_type.rs Dmitrii Dolgov
  2026-02-09 17:27 ` Ian Rogers
@ 2026-02-10  8:56 ` Miguel Ojeda
  2026-02-10 13:57   ` Mark Brown
  2026-02-10 20:58   ` Arnaldo Carvalho de Melo
  1 sibling, 2 replies; 5+ messages in thread
From: Miguel Ojeda @ 2026-02-10  8:56 UTC (permalink / raw)
  To: Dmitrii Dolgov, Arnaldo Carvalho de Melo, Mark Brown
  Cc: linux-perf-users, Namhyung Kim, Ian Rogers, Miguel Ojeda,
	Linux Kernel Mailing List, kernel test robot,
	Linux-Next Mailing List

On Mon, Feb 9, 2026 at 3:05 PM Dmitrii Dolgov <9erthalion6@gmail.com> wrote:
>
> One part of the rust code for code_with_type workload wasn't properly
> formatted. Pass it through rustfmt to fix that.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202602091357.oyRv6hgQ-lkp@intel.com/
> Signed-off-by: Dmitrii Dolgov <9erthalion6@gmail.com>

Could this please be applied (or fixed in-place)?

It is now in next-20260209, and we check this in different CIs. It
also makes LKP give spurious reports, e.g.:

  https://lore.kernel.org/all/202602100751.ldfRitCJ-lkp@intel.com/

Thanks!

Fixes: 2e05bb52a12d ("perf test workload: Add code_with_type test workload")

Cc'ing Mark since I think the plan is to check in linux-next.

Cheers,
Miguel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v1] perf tests workload: Formatting for code_with_type.rs
  2026-02-10  8:56 ` Miguel Ojeda
@ 2026-02-10 13:57   ` Mark Brown
  2026-02-10 20:58   ` Arnaldo Carvalho de Melo
  1 sibling, 0 replies; 5+ messages in thread
From: Mark Brown @ 2026-02-10 13:57 UTC (permalink / raw)
  To: Miguel Ojeda
  Cc: Dmitrii Dolgov, Arnaldo Carvalho de Melo, linux-perf-users,
	Namhyung Kim, Ian Rogers, Miguel Ojeda, Linux Kernel Mailing List,
	kernel test robot, Linux-Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

On Tue, Feb 10, 2026 at 09:56:36AM +0100, Miguel Ojeda wrote:

> Cc'ing Mark since I think the plan is to check in linux-next.

Yes, I was going to revisit this after the merge window - hopefully all
the fixes will have landed by then (clippy was the main thing IIRC).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v1] perf tests workload: Formatting for code_with_type.rs
  2026-02-10  8:56 ` Miguel Ojeda
  2026-02-10 13:57   ` Mark Brown
@ 2026-02-10 20:58   ` Arnaldo Carvalho de Melo
  1 sibling, 0 replies; 5+ messages in thread
From: Arnaldo Carvalho de Melo @ 2026-02-10 20:58 UTC (permalink / raw)
  To: Miguel Ojeda
  Cc: Dmitrii Dolgov, Mark Brown, linux-perf-users, Namhyung Kim,
	Ian Rogers, Miguel Ojeda, Linux Kernel Mailing List,
	kernel test robot, Linux-Next Mailing List

On Tue, Feb 10, 2026 at 09:56:36AM +0100, Miguel Ojeda wrote:
> On Mon, Feb 9, 2026 at 3:05 PM Dmitrii Dolgov <9erthalion6@gmail.com> wrote:
> >
> > One part of the rust code for code_with_type workload wasn't properly
> > formatted. Pass it through rustfmt to fix that.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202602091357.oyRv6hgQ-lkp@intel.com/
> > Signed-off-by: Dmitrii Dolgov <9erthalion6@gmail.com>
> 
> Could this please be applied (or fixed in-place)?

Its merged and pushed out, should be clean now,

- Arnaldo
 
> It is now in next-20260209, and we check this in different CIs. It
> also makes LKP give spurious reports, e.g.:
> 
>   https://lore.kernel.org/all/202602100751.ldfRitCJ-lkp@intel.com/
> 
> Thanks!
> 
> Fixes: 2e05bb52a12d ("perf test workload: Add code_with_type test workload")
> 
> Cc'ing Mark since I think the plan is to check in linux-next.
> 
> Cheers,
> Miguel

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-02-10 20:58 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-09 14:05 [PATCH v1] perf tests workload: Formatting for code_with_type.rs Dmitrii Dolgov
2026-02-09 17:27 ` Ian Rogers
2026-02-10  8:56 ` Miguel Ojeda
2026-02-10 13:57   ` Mark Brown
2026-02-10 20:58   ` Arnaldo Carvalho de Melo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox