From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Dmitrii Dolgov <9erthalion6@gmail.com>
Cc: linux-perf-users@vger.kernel.org,
Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>, Miguel Ojeda <ojeda@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] tools build: Fix feature test for rust compiler
Date: Wed, 11 Feb 2026 09:23:31 -0300 [thread overview]
Message-ID: <aYx0w8AnkK2-c11z@x1> (raw)
In-Reply-To: <20260211095807.132855-1-9erthalion6@gmail.com>
On Wed, Feb 11, 2026 at 10:58:01AM +0100, Dmitrii Dolgov wrote:
> Currently a dummy rust code is compiled to detect if the rust feature
> could be enabled. It turns out that in this case rust emits a dependency
> file without any external references:
>
> /perf/feature/test-rust.d: test-rust.rs
>
> /perf/feature/test-rust.bin: test-rust.rs
>
> test-rust.rs:
>
> This can lead to a situation, when rustc was removed after a successful build,
> but the build process still thinks it's there and the feature is enabled on
> subsequent runs.
>
> Instead simply check the compiler presence to detect the feature, as
> suggested by Arnaldo Carvalho de Melo. This way no actual test-rust.bin
> will be created, meaning the feature check will not be cached and always
> performed. That's exactly what we want, and the overhead of doing this
> every time is minimal.
>
> Tested with multiple rounds of install/remove of the rust package.
Yeah, seems to work, applied.
- Arnaldo
prev parent reply other threads:[~2026-02-11 12:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 9:58 [PATCH v1] tools build: Fix feature test for rust compiler Dmitrii Dolgov
2026-02-11 10:41 ` Miguel Ojeda
2026-02-11 12:11 ` Arnaldo Carvalho de Melo
2026-02-11 12:23 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYx0w8AnkK2-c11z@x1 \
--to=acme@kernel.org \
--cc=9erthalion6@gmail.com \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=ojeda@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox