From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12A22332917 for ; Mon, 2 Mar 2026 10:33:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772447632; cv=none; b=eovtAQLO5FrcBrzqjabf72EDZZDaO1DSxEiKV9eC1oNGOWGvrRkW1cNBaMQUmcPuYfgPF1Cccbrq9NAe5ElSzEhoJIXSmAYaIrvxCytlG8knW6VI48urSREBgfFmTMnvb8pJ/5YoCpOlGeEQMqaIM+Z/QUG1G1byZWWsCnHwexk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772447632; c=relaxed/simple; bh=QEn+El7Z+bL/DWqeCCzlYqCfrkxihEN+xIGAxOA2r98=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=TXPvbAweYRrsfV121zm4lD3OEn62qJfmioiDYlVF5cXv46YycVzWGMwxsxoFEsFAkKDzzyl4H+e9IcYVdpo6ZDvZo7asPCEv8yjGMPteIWj+cHhy/Mn516LR6NCIgnZ+FmeIqS2PPyCjHn2vrdZeSWUh4k3Bl6UmcZdhT2kg4pY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=rq4xdrlu; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="rq4xdrlu" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-48378c4a79fso36135705e9.0 for ; Mon, 02 Mar 2026 02:33:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772447626; x=1773052426; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=EnMgJMcaQgCDj7i00Uawlj/G1rJtXPwe1sCLwvhoFHI=; b=rq4xdrlutDZNzchgca2LpBR52y6AVtdV4PS2i7Okgss3v9KH1sO1XKDitIIPzPn/hI IIqBvmSXgRGHTGiuZ2XWX5Pua3XkiI1cc6lsjEoJf15THOIKyZkqFuCYgr+6DkhGcWbq zmNhmcRRpDjeE4c/lOsqWaUl7ccq5LIpH087AwRE7M6mp8jAvMMQTC0dLUrRHa5N6j+y qnQVaZXoQ+z5FqKmO3oODPKlACGy9IKYFof51fLeqJh/4dwg7jhlPr9QlqoUYGSz8FbL yQAzPFa8B5RV1degHbdqhI7/iD092kEARW9Nm78z08vqGCxZw109+IAio3IZyqGc1FDw 0tZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772447626; x=1773052426; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EnMgJMcaQgCDj7i00Uawlj/G1rJtXPwe1sCLwvhoFHI=; b=eqQoqu9y9ZuY5e3XuSQ9RlXhoraI8n6M0ErKOurcvdORmVExmL0vUdKfoHVzIE0zIk FBk7bFzWki2Enj+pP4J5YWZ2AWbgXt+A13PbZpxdmJAOXFliTB/y/DzrUKMFHXOfFO7Z EXe2Ht53YIgTXcWMjrftb7afPH70C1bAKeLblgoWaHV1JeSgkU8JTkolGG7Nis41bs3e C/FF1Awq8V5t7+JpAl8YOOP2ukY9abFPzWJ2Q9Xk5PxTPZ9r5vRQFjWLxGdStrx1NxPB hgklzwCIiaRg8SbLEAICW/nxNS5wZNFN82OYETTb1jZu0IAQ914VtP5t8DkWEKNMwUtN 6oaA== X-Forwarded-Encrypted: i=1; AJvYcCVe138xSidcSNW55eZvRHV5aaTdq+TWwWTHmeU35jHRJXtNT0ZRxHejHuDIPgvVy3322W4BaP5ub72zBNBf+xMf@vger.kernel.org X-Gm-Message-State: AOJu0YxO0BsMLGpfnQ0eRd9AU/usMYGHiYUufL6te42EAnUmQwT+7H5P DqcrhhLw07soHrJwr2yrFPK15zZ6nRvxqgj6IiejVvqc0NK3lSsk6TALsh0uxYDM22bv7MFVM1q RSM521HBiwa+KRxv2/A== X-Received: from wmdd1.prod.google.com ([2002:a05:600c:a201:b0:480:3227:a124]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:6383:b0:47d:3ead:7440 with SMTP id 5b1f17b1804b1-483c9bdb683mr186031315e9.32.1772447625915; Mon, 02 Mar 2026 02:33:45 -0800 (PST) Date: Mon, 2 Mar 2026 10:33:45 +0000 In-Reply-To: Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260227200848.114019-1-david@kernel.org> <20260227200848.114019-3-david@kernel.org> <8a27e9ac-2025-4724-a46d-0a7c90894ba7@kernel.org> Message-ID: Subject: Re: [PATCH v1 02/16] mm/memory: remove "zap_details" parameter from zap_page_range_single() From: Alice Ryhl To: "David Hildenbrand (Arm)" Cc: linux-kernel@vger.kernel.org, "linux-mm @ kvack . org" , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , David Rientjes , Shakeel Butt , "Matthew Wilcox (Oracle)" , Madhavan Srinivasan , Michael Ellerman , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Greg Kroah-Hartman , "Arve =?utf-8?B?SGrDuG5uZXbDpWc=?=" , Todd Kjos , Christian Brauner , Carlos Llamas , Ian Abbott , H Hartley Sweeten , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Jason Gunthorpe , Leon Romanovsky , Dimitri Sivanich , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Andy Lutomirski , Vincenzo Frascino , Eric Dumazet , Neal Cardwell , "David S. Miller" , David Ahern , Jakub Kicinski , Paolo Abeni , Miguel Ojeda , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-sgx@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, rust-for-linux@vger.kernel.org, x86@kernel.org Content-Type: text/plain; charset="utf-8" On Mon, Mar 02, 2026 at 11:27:40AM +0100, David Hildenbrand (Arm) wrote: > On 3/2/26 11:01, Alice Ryhl wrote: > > On Mon, Mar 02, 2026 at 09:18:45AM +0100, David Hildenbrand (Arm) wrote: > >> On 2/28/26 13:38, Alice Ryhl wrote: > >>> > >>> > >>> Please run rustfmt on Rust changes. Here, rustfmt leads to this being > >>> formatted on a single line: > >> > >> Having to run tooling I don't even have installed when removing a single > >> function parameter; did not expect that :) > > > > Well, rustfmt comes with the compiler, and it would be ideal to build > > test changes before sending them :) > > At least on Ubuntu on my notebook where I do most of the coding+patch > submissions it's a separate package? > > I do all my builds on a different (more powerful) machine where the > whole rust machinery's in place. Further, build bots that run on my > private branches did not report any issues. There are some build bots that check for rustfmt, though not all of them. > > But no worries, I took care of testing it. Thanks for taking the time to > > update the Rust code as well. > > I just did an allyesconfig and it does not report any warnings. > > So apparently, rustfmt problems not result in the compiler complaining? > > Or something else is off here that rust/kernel/mm/virt.rs won't get > compiled on my machine, even with allyesconfig. I can definitely see > some RUSTC stuff happening in the logs, like > > RUSTC L rust/kernel.o > > Thanks for the review and for pointing out rustfmt! Similar to kerneldoc and other similar targets, formatting isn't checked in the normal build, but make can be invoked on the rustfmtcheck target to check it. Alice