From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A95ACA5537 for ; Wed, 13 Sep 2023 10:32:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233578AbjIMKct (ORCPT ); Wed, 13 Sep 2023 06:32:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236362AbjIMKcs (ORCPT ); Wed, 13 Sep 2023 06:32:48 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5ABCF1989; Wed, 13 Sep 2023 03:32:44 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 34E451FB; Wed, 13 Sep 2023 03:33:21 -0700 (PDT) Received: from [192.168.1.3] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 033813F5A1; Wed, 13 Sep 2023 03:32:40 -0700 (PDT) Message-ID: Date: Wed, 13 Sep 2023 11:32:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 5/7] perf pmu: Move pmu__find_core_pmu() to pmus.c Content-Language: en-US From: James Clark To: Arnaldo Carvalho de Melo Cc: linux-perf-users@vger.kernel.org, irogers@google.com, John Garry , Will Deacon , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Kan Liang , Jing Zhang , Haixin Yu , Kajol Jain , Ravi Bangoria , Yang Jihong , Eduard Zingerman , Chen Zhongjin , Miguel Ojeda , Liam Howlett , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230831151632.124985-1-james.clark@arm.com> <20230831151632.124985-6-james.clark@arm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On 13/09/2023 11:20, James Clark wrote: > > > On 12/09/2023 20:26, Arnaldo Carvalho de Melo wrote: >> Em Thu, Aug 31, 2023 at 04:16:16PM +0100, James Clark escreveu: >>> pmu__find_core_pmu() more logically belongs in pmus.c because it >>> iterates over all PMUs, so move it to pmus.c >>> >>> At the same time rename it to perf_pmus__find_core_pmu() to match the >>> naming convention in this file. >>> >>> Signed-off-by: James Clark >> >> So, this one is hitting this: >> >> CC /tmp/build/perf-tools-next/util/expr.o >> In file included from /var/home/acme/git/perf-tools-next/tools/include/linux/list.h:7, >> from util/pmus.c:2: >> In function ‘perf_pmus__scan_core’, >> inlined from ‘perf_pmus__find_core_pmu’ at util/pmus.c:601:16: >> /var/home/acme/git/perf-tools-next/tools/include/linux/kernel.h:36:45: error: array subscript 0 is outside array bounds of ‘struct list_head[1]’ [-Werror=array-bounds] >> 36 | const typeof(((type *)0)->member) * __mptr = (ptr); \ >> | ^~~~~~ >> /var/home/acme/git/perf-tools-next/tools/include/linux/list.h:352:9: note: in expansion of macro ‘container_of’ >> 352 | container_of(ptr, type, member) >> | ^~~~~~~~~~~~ >> /var/home/acme/git/perf-tools-next/tools/include/linux/list.h:404:9: note: in expansion of macro ‘list_entry’ >> 404 | list_entry((pos)->member.next, typeof(*(pos)), member) >> | ^~~~~~~~~~ >> /var/home/acme/git/perf-tools-next/tools/include/linux/list.h:494:20: note: in expansion of macro ‘list_next_entry’ >> 494 | for (pos = list_next_entry(pos, member); \ >> | ^~~~~~~~~~~~~~~ >> util/pmus.c:274:9: note: in expansion of macro ‘list_for_each_entry_continue’ >> 274 | list_for_each_entry_continue(pmu, &core_pmus, list) >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> util/pmus.c: In function ‘perf_pmus__find_core_pmu’: >> util/pmus.c:35:18: note: at offset -128 into object ‘core_pmus’ of size 16 >> 35 | static LIST_HEAD(core_pmus); >> | ^~~~~~~~~ >> /var/home/acme/git/perf-tools-next/tools/include/linux/list.h:23:26: note: in definition of macro ‘LIST_HEAD’ >> 23 | struct list_head name = LIST_HEAD_INIT(name) >> | ^~~~ >> cc1: all warnings being treated as errors >> make[4]: *** [/var/home/acme/git/perf-tools-next/tools/build/Makefile.build:97: /tmp/build/perf-tools-next/util/pmus.o] Error 1 >> make[4]: *** Waiting for unfinished jobs.... >> LD /tmp/build/perf-tools-next/ui/browsers/perf-in.o >> >> >> So I applied up to 4/7 >> >> Please continue from what will be in tmp.perf-tools-next in some >> jiffies. >> >> - Arnaldo > > I wasn't able to reproduce this on x86 or Arm, with either Clang or GCC. > > That was with this patch applied onto 999b81b907e on tmp.perf-tools-next > and a pretty normal "make WERROR=1" command. > > It seems like the 0 here is just to get the type rather than access > anything, if that's the 0 that the "array subscript 0" error is about, > so something seems a bit strange: > >> /var/home/acme/git/perf-tools-next/tools/include/linux/kernel.h:36:45: > error: array subscript 0 is outside array bounds of ‘struct > list_head[1]’ [-Werror=array-bounds] >> 36 | const typeof(((type *)0)->member) * __mptr = (ptr); \ Nevermind, I managed to reproduce it. With a DEBUG=1 build on x86 there is no error, it only happens with a non debug one. I will look into it.